From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80852C433F5 for ; Thu, 11 Nov 2021 18:21:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F2A061268 for ; Thu, 11 Nov 2021 18:21:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F2A061268 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D82AC83A34; Thu, 11 Nov 2021 19:20:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="PBgLD+Kg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 440CC83A36; Thu, 11 Nov 2021 19:20:56 +0100 (CET) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2C7CD83A25 for ; Thu, 11 Nov 2021 19:20:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id d2so1716319qki.12 for ; Thu, 11 Nov 2021 10:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HQX6JJUXg83d7KTItFfBPhkeBdGwt3Bdnd2kIR/v2OM=; b=PBgLD+KgjpbBmSMStdjfPopJt2B+my5Tz4rg5Qp6KeN2ppmTc8QEKinDV0pehqG0AJ 7Rt9s8XvUHcaeiw8fjKzIVzfSnF2D9Psxtrw94zsBbx34cvUtrFwvYfsTwbyKN03kN46 iuEYILHABcn8Ic3hAnQkmSjiXFXmtBvRaHPp8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HQX6JJUXg83d7KTItFfBPhkeBdGwt3Bdnd2kIR/v2OM=; b=qCvkFtpkcaxE9zoLAb9YkVwo8gMAv3WU8urZV9JRBP7/+eD4pZJCG8Gfajtu6tA3bI ugRYMYt+2xIgttv8hamqWKiaq9Kgk2TFKPiIvdFfxi4TneuUlb62Q0JMoQ35/F1is2uu Qe77eBZM3Sr1I+GaAEXinSbexPgRzgd9gYyhBxotTpRY2dp3AfasEUE/7kIK3uberTKH eO9tFpanwmNfuXRg4CSGTCxoOUkIgPxBwPkDq4zkeXQkjieNdkhVIWwMF3uCxlULZOpb XDDkU4tUgKF1EItutRBIqgndUwhyvcERWKbYrQce+yDhkKm5yZLPq0PGUZ6y5NMGSa4I Fc6w== X-Gm-Message-State: AOAM533Hssfh2SVuIt3qO2/8Ix0+HkSm39/8jn355NMFyc/hKDVNqdJl /1iMHNfVC3GdBcHlhIevpM6bFQ== X-Google-Smtp-Source: ABdhPJxr7ka+G3mVdiX3C78Ep4NxrdWt/yo48OCFSUOxZpUhcaS4gPyruZbtSH58EMRnjU+S5L+3mQ== X-Received: by 2002:a37:9703:: with SMTP id z3mr7462454qkd.517.1636654849785; Thu, 11 Nov 2021 10:20:49 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-0560-a46c-4644-38cb.res6.spectrum.com. [2603:6081:7b01:cbda:560:a46c:4644:38cb]) by smtp.gmail.com with ESMTPSA id x1sm1881062qtw.84.2021.11.11.10.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 10:20:49 -0800 (PST) Date: Thu, 11 Nov 2021 13:20:46 -0500 From: Tom Rini To: Mathew McBride Cc: u-boot@lists.denx.de, Priyanka Jain Subject: Re: [PATCH v2 2/2] board: traverse: add initial Ten64 support Message-ID: <20211111182046.GU24579@bill-the-cat> References: <20211110044639.7070-1-matt@traverse.com.au> <20211110044639.7070-3-matt@traverse.com.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ofGRIQre7xkQTGW7" Content-Disposition: inline In-Reply-To: <20211110044639.7070-3-matt@traverse.com.au> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --ofGRIQre7xkQTGW7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 10, 2021 at 04:46:39AM +0000, Mathew McBride wrote: > The Ten64 is a networking-oriented MiniITX board > using the NXP LS1088A SoC. >=20 > This patch provides the bare minimum to support > Ten64 boards under U-Boot for distroboot. >=20 > Some related drivers have not yet been submitted > and this basic support lacks some of the > opinionated defaults provided by our firmware > distribution. >=20 > Signed-off-by: Mathew McBride > --- > arch/arm/Kconfig | 16 ++ > arch/arm/dts/Makefile | 2 + > arch/arm/dts/fsl-ls1088a-ten64.dts | 377 +++++++++++++++++++++++++ What is the status of this dts with upstream Linux? [snip] > +CONFIG_BOOTARGS=3D"console=3DttyS0,115200 root=3D/dev/ram0 earlycon=3Dua= rt8250,mmio,0x21c0500 ramdisk_size=3D0x3000000 default_hugepagesz=3D2m huge= pagesz=3D2m hugepages=3D256" Note that ramdisk information will be passed along correctly via DT and should not generally be set in this manner. [snip] > +CONFIG_MTDPARTS_DEFAULT=3D"mtdparts=3Dspi-nand0:8m(reserved),32m(recover= y),108m(ubia),108m(ubib);nor1:1m(bl2),2m(bl3),2m(mcfirmware),512k(ubootenv)= ,256k(dpl),256k(dpc),256k(devicetree)" This should be the same as the fixed-partition in the dts and then not needed here. > diff --git a/include/configs/ten64.h b/include/configs/ten64.h > new file mode 100644 > index 0000000000..54e65f29f1 > --- /dev/null > +++ b/include/configs/ten64.h Please make sure there's no already migrated CONFIG symbols in this. A quick 'git log configs' should make it clear what's been migrated to Kconfig since you last checked this. > +#define QSPI_NOR_BOOTCOMMAND "run distro_bootcmd" > +#define SD_BOOTCOMMAND "run distro_bootcmd" You should just set CONFIG_USE_BOOTCOMMAND and then CONFIG_BOOTCOMMAND will be "run distro_bootcmd". Thanks! --=20 Tom --ofGRIQre7xkQTGW7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGNXvkACgkQFHw5/5Y0 tywYZwv9E6qfeiBaEBYIc2OYY9RPHUv/qE/GJq3plRC3qC+DmiLwjmzmGWmfIz4+ 7MHf+WbnqEp7NNvsJY5tXvwKWZk3KAGYeQyM+5+gr6DKrMArMY2SAIPJnEuO0yq7 zqufvFs/DtM1dmDOm0xkZNxEoKlXEw/gmX/IdJfpw90BWruAAJAkMjoPylfCpVHd xUZebxq/nGBlJVqjf9TNcc2lMZuJo1oOYcR6z+fUIzda6VPki45CAZIDLWhn90Y8 ZAvcM0GhI3YRSc5I9rQ7AXL6Jckt3CJkDGq2L48Y4uhbCGnUG1M7Y9ENwqnKjkjm h9BOKkJiME0bmWSegrMecEL59aOE6DRY/O2TDIZYTJTebCqf+IgBMqU2T2RHWlDn Hiu+agCdbeRRlkH8JE4vjB3x7Y8iiu9/R5Soyc1OXOyRwNM73QFT7oEJfalyTI1d Br9s8BpZTJYLjTJyfbUPg+BQFBI9cmAbSdeRZpIFMfjnFqbhOtzuHwvWcJeh+Pug +kSGR7Ds =9BDt -----END PGP SIGNATURE----- --ofGRIQre7xkQTGW7--