From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724BDC433F5 for ; Thu, 11 Nov 2021 18:33:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FFBF61241 for ; Thu, 11 Nov 2021 18:33:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234434AbhKKSf5 (ORCPT ); Thu, 11 Nov 2021 13:35:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234001AbhKKSf4 (ORCPT ); Thu, 11 Nov 2021 13:35:56 -0500 Received: from relay03.th.seeweb.it (relay03.th.seeweb.it [IPv6:2001:4b7a:2000:18::164]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DF4CC061766 for ; Thu, 11 Nov 2021 10:33:07 -0800 (PST) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 4E6251F633; Thu, 11 Nov 2021 19:33:05 +0100 (CET) Date: Thu, 11 Nov 2021 19:33:03 +0100 From: Marijn Suijten To: Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, jamipkettunen@somainline.org, Alex Elder , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/ipa: ipa_resource: Fix wrong for loop range Message-ID: <20211111183303.avx45fu5mk5wnglj@SoMainline.org> References: <20211111173401.551408-1-konrad.dybcio@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211111173401.551408-1-konrad.dybcio@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-11-11 18:34:00, Konrad Dybcio wrote: > The destrination group count was mistakenly assigned to both dst and src loops. There's an unnecessary `r` in destRination... Apart that I think you meant to say "source" here since both assignments to group_count use(d) rsrc_group_src_count, not the destination. > Fix it to make IPA probe and work again. > This is missing: Fixes: 4fd704b3608a ("net: ipa: record number of groups in data") For backporting to 5.13 and above. Before that commit src and dst were correctly used. Apart that, after fixing this all: Reviewed-by: Marijn Suijten > Signed-off-by: Konrad Dybcio > --- > drivers/net/ipa/ipa_resource.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c > index e3da95d69409..06cec7199382 100644 > --- a/drivers/net/ipa/ipa_resource.c > +++ b/drivers/net/ipa/ipa_resource.c > @@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa, > return false; > } > > - group_count = data->rsrc_group_src_count; > + group_count = data->rsrc_group_dst_count; > if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX) > return false; > > -- > 2.33.0 >