Re: [PATCH net-next v4] net: marvell: prestera: add firmware v4.0 support

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next v4] net: marvell: prestera: add firmware v4.0 support
Date: Fri, 12 Nov 2021 03:48:43 +0800	[thread overview]
Message-ID: <202111120313.kZJSR8Dh-lkp@intel.com> (raw)
In-Reply-To: <1635485889-27504-1-git-send-email-volodymyr.mytnyk@plvision.eu>

[-- Attachment #1: Type: text/plain, Size: 2993 bytes --]

Hi Volodymyr,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Volodymyr-Mytnyk/net-marvell-prestera-add-firmware-v4-0-support/20211029-134025
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7df621a3eea6761bc83e641aaca6963210c7290d
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b50d5c511379fc2b67d7ee496d62c76ecb06da34
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Volodymyr-Mytnyk/net-marvell-prestera-add-firmware-v4-0-support/20211029-134025
        git checkout b50d5c511379fc2b67d7ee496d62c76ecb06da34
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/marvell/prestera/prestera_hw.c:284:1: error: alignment 1 of 'union prestera_msg_port_param' is less than 4 [-Werror=packed-not-aligned]
     284 | } __packed;
         | ^
   cc1: all warnings being treated as errors

vim +284 drivers/net/ethernet/marvell/prestera/prestera_hw.c

   234	
   235	union prestera_msg_port_param {
   236		u8 admin_state;
   237		u8 oper_state;
   238		__le32 mtu;
   239		u8 mac[ETH_ALEN];
   240		u8 accept_frm_type;
   241		__le32 speed;
   242		u8 learning;
   243		u8 flood;
   244		__le32 link_mode;
   245		u8 type;
   246		u8 duplex;
   247		u8 fec;
   248		u8 fc;
   249	
   250		union {
   251			struct {
   252				u8 admin:1;
   253				u8 fc;
   254				u8 ap_enable;
   255				union {
   256					struct {
   257						__le32 mode;
   258						u8  inband:1;
   259						__le32 speed;
   260						u8  duplex;
   261						u8  fec;
   262						u8  fec_supp;
   263					} __packed reg_mode;
   264					struct {
   265						__le32 mode;
   266						__le32 speed;
   267						u8  fec;
   268						u8  fec_supp;
   269					} __packed ap_modes[PRESTERA_AP_PORT_MAX];
   270				} __packed;
   271			} __packed mac;
   272			struct {
   273				u8 admin:1;
   274				u8 adv_enable;
   275				__le64 modes;
   276				__le32 mode;
   277				u8 mdix;
   278			} __packed phy;
   279		} __packed link;
   280	
   281		struct prestera_msg_port_cap_param cap;
   282		struct prestera_msg_port_flood_param flood_ext;
   283		struct prestera_msg_event_port_param link_evt;
 > 284	} __packed;
   285	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 69552 bytes --]