From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5607C433F5 for ; Fri, 12 Nov 2021 15:39:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2E3960F0F for ; Fri, 12 Nov 2021 15:39:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2E3960F0F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A5F0583000; Fri, 12 Nov 2021 16:39:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FxSSQZQZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 26F2182FF0; Fri, 12 Nov 2021 16:39:10 +0100 (CET) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7DDFE82FF0 for ; Fri, 12 Nov 2021 16:39:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x729.google.com with SMTP id t83so7056040qke.8 for ; Fri, 12 Nov 2021 07:39:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=A9rYPQOlDP/UPzqY/T6XjgH2fm6rU4T4Sf3YRdRWmEE=; b=FxSSQZQZdUpBsDGyEwfO99wpyF5VzU/wRybZzhMx3+l2/Oh5c4HRGD3qYMc8jAA5Cc McbmfU5TPnTBtzwES2hEZzl3vRHhU0bUVo5AzquOdaU8i1wJTWdFGNPNWa65rHHJprIH B0x1mKCFNTfr0LqM/3og8M+p18+567UNIvr68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=A9rYPQOlDP/UPzqY/T6XjgH2fm6rU4T4Sf3YRdRWmEE=; b=gezjGvoh9eYx7wWs1LVy5l6Ny50WkzVpxTZUXjlDObPl8rP3cgTfeGSHnCU7me5rtn ygXsyATMLWwuBTVPe1sMygfm5IsQ7ID1Zw8L9I85OlYodzvp2vqQrOzjA9OR/qUY3gdg tGRBBvU8GsiHzipS1Qy1EfiSqoKJ8SwZw5bg1nmlATwAjIvpdKcMbVpiDIO+JENjs590 gXlpK5uBKUyQl3dd3l1hXhhZ14Q3grdBe0CbqDPYNgx2fYQmmV32yjbNw1sH2hUIJ4ZN s3SSm207ZA6ABfHBzpCR53vF/IeLMQzeM0GcKCh9WzalETKL6jWUwPfB1tKuTDxo5ca4 mIAQ== X-Gm-Message-State: AOAM5306DvW8KvxZAGqFPsFcZpSrUogh8/W8KCO+z1Tepu7szDIwad3C oonAMVUTPlVqSzKBrDNT/s0ghQ== X-Google-Smtp-Source: ABdhPJyu3pZt6pRknewt5G0MghUK9akBUf9Ti0eqlzEPphjpazxmlZp6tXowBUWP9AYb+DGVOFpi4w== X-Received: by 2002:a37:44d7:: with SMTP id r206mr12877299qka.127.1636731541379; Fri, 12 Nov 2021 07:39:01 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-99df-60fa-a7c9-fbd2.res6.spectrum.com. [2603:6081:7b01:cbda:99df:60fa:a7c9:fbd2]) by smtp.gmail.com with ESMTPSA id d15sm3148675qtd.70.2021.11.12.07.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 07:39:00 -0800 (PST) Date: Fri, 12 Nov 2021 10:38:58 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Subject: Re: [PATCH v3 02/18] pxe: Move API comments to the header files Message-ID: <20211112153858.GA24579@bill-the-cat> References: <20211014184811.482560-1-sjg@chromium.org> <20211014184811.482560-3-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Am7d0+LhToPCvfhw" Content-Disposition: inline In-Reply-To: <20211014184811.482560-3-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Am7d0+LhToPCvfhw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 14, 2021 at 12:47:55PM -0600, Simon Glass wrote: > Put the function comments in the header file so that the full API can we > examined in one place. >=20 > Expand the comments to cover parameters and return values. >=20 > Signed-off-by: Simon Glass > Reviewed-by: Artem Lapkin > Tested-by: Artem Lapkin > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! --=20 Tom --Am7d0+LhToPCvfhw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGOipIACgkQFHw5/5Y0 tyxBdgwAtUTi3t2jzxFLldv6eRYvh+rwEp4z8YoNXaRHoXp0VuotjXW2YjKfHUCD h0IEWFBZruMqB8kNyJMjq1ZHYIg6dmlScesr6xXWG+FHa22T+dmVKRjk+glLjhCO gvfpMwEXi76L76wZyYxioKq++jR8Ng3zbfj7zs5i0KzEn+WPLz6Bfq2QOE59Izdb a2oh1lIKNAbKjtCdndB0ythvTsgYKtjdYPYmwKsjZeJQsOf61rFZWiHw3w+Pni/5 eJtPlMi7Pu6oTFYWOLn566xDQi/yZvJSTOZWMNDq/cZJmeBLertLiAcwQtGnWubL uvwr+O/0eRGlTOsr+SFQBgb67xcg4qiABPeMb6l9uFzv3szRD/mqkMvi1bvOfp71 L8VlIWPjNv3/3kM0tJbcG60GCaRaofyUOZji57pF3s3QCULlmsJ1/lIbzvwZ3F7e Z+bmJo2ZhojOC3k5aIK+5N3gI9bc3McywiaJSPI2aMGdtcv9/2X5Zn+YytIcSv5w MSTqIko1 =ovqP -----END PGP SIGNATURE----- --Am7d0+LhToPCvfhw--