From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B015C433EF for ; Fri, 12 Nov 2021 15:41:06 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8A7560F41 for ; Fri, 12 Nov 2021 15:41:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E8A7560F41 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 23F6B82FF6; Fri, 12 Nov 2021 16:40:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="lQFTvG/c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3BE1882FFB; Fri, 12 Nov 2021 16:40:24 +0100 (CET) Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8D13A8301B for ; Fri, 12 Nov 2021 16:39:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf29.google.com with SMTP id kl8so1993125qvb.3 for ; Fri, 12 Nov 2021 07:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6AbOLQqqKYBcuRVnE+AdzilJ9bJeDK7Kpnf5LfhyHK0=; b=lQFTvG/cuDl8nxsZhiFK5SFUmMy76VGX0xBOg862ZD7x7en2A8IOHJ3bZfl+7Yh5b9 wyJ74WzQNA5v0Rv1TaZGESYCkx4atl1fai+DSz3YE3vezkCZsBjLOI9eSeXxX9OSL0s5 lRCSIps6gvg49oXigp/u6pyjkZyGut50q4zK8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6AbOLQqqKYBcuRVnE+AdzilJ9bJeDK7Kpnf5LfhyHK0=; b=S24nxRdcHRpVDQlc5tGAYJxqepOkTtfhwkDJSk6koIYcAGNVeGs9hfB37wFQmtVmNH JIRQ2uD4pZsD0/7rM+A6YWXE6wf5FOnv8wXZ2Y98iP+JwPKa2EnJSsZNS84FL+8DMm77 UBxbs64RO8wEDShsOA5g72S4uy2ME/vDjw8YenSbwFJrwwTvSLPg1QCAYsVgSfDPi1S3 Ii54VEMrFsCfdXs91kIU5A1IfUtUtPVq+mS4vVnPTd10DVSbZa9uhtlSPBuQeTfGAZER tfoLRiS2aFFQgk5ZSZVIS5f/UQE7pd4LzSW73zUSSJGRYmUq766spMWusn7Jq1w9tJmv eRQA== X-Gm-Message-State: AOAM532Q/3xlJP0O3NiB6h6Jg1HtEYhjXjUSzMit50wkTqzcOfdSBUk8 nUrYdYZYSVYaetp6aXtKHpF9Fg== X-Google-Smtp-Source: ABdhPJz0NM8+p16U2MBhajZ7Bnrz4DaK1HNw1i2uc1v84mm3SG1ZEwkbKqcBm2fKj4SD8xKVoLnZuw== X-Received: by 2002:ad4:41c3:: with SMTP id a3mr15560885qvq.51.1636731596479; Fri, 12 Nov 2021 07:39:56 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-99df-60fa-a7c9-fbd2.res6.spectrum.com. [2603:6081:7b01:cbda:99df:60fa:a7c9:fbd2]) by smtp.gmail.com with ESMTPSA id x11sm3323094qta.90.2021.11.12.07.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 07:39:55 -0800 (PST) Date: Fri, 12 Nov 2021 10:39:53 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Subject: Re: [PATCH v3 11/18] pxe: Clean up the use of bootfile Message-ID: <20211112153953.GJ24579@bill-the-cat> References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.11.I6a01e73ef114448e39cb6899c21f6c169e4da216@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qBHmSV+TH27iWIXh" Content-Disposition: inline In-Reply-To: <20211014124803.v3.11.I6a01e73ef114448e39cb6899c21f6c169e4da216@changeid> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --qBHmSV+TH27iWIXh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 14, 2021 at 12:48:04PM -0600, Simon Glass wrote: > The 'bootfile' environment variable is read in the bowels of pxe_util to > provide a directory to which all loaded files are relative. >=20 > This is not obvious from the API to PXE and it is strange to make the > caller set an environment variable rather than pass this as a parameter. >=20 > The code is also convoluted, which this feature implemented by > get_bootfile_path(). >=20 > Update the API to improve this. Unfortunately this means that > pxe_setup_ctx() can fail, so add error checking. >=20 > Signed-off-by: Simon Glass > Reviewed-by: Artem Lapkin > Tested-by: Artem Lapkin > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! --=20 Tom --qBHmSV+TH27iWIXh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGOiskACgkQFHw5/5Y0 tyw2TQv/RPBitF9Z1XWqJfpR/3CWdA0Ql5fE6N27EpaICSWZ7Fk9chlPJA0kXMf3 EDwYM0xytvjWgM0xY1CBCHmg345Zcnog3W7osb3AirNzBnMg3+bAWDd5T5sZ8tfv K5y0Y1g2/VosELhlZvYUZWvnKdvpqt5AOQaJcxKofBFAy5mAG9WtlQ7UXkjKu/rb bE0IKeAmXFWoTSXl0X+UuyVsBKjkj9HE423AheK7wRCKHYBRfqTSnfukunK9A41l sKGiktgRxGgKYJN4Uro9lRWgfTpZCv16WmpLNu555dbOSwuAdyI/0AAeP+wPReB9 gppxF+G+B/fUWcOJYuD7iOq6O+fWkDYHFZ0XDNGy1CRsM78J2HYnh5jRAA/PuSHC 8cSV9aeKDQ2vMuKpueFHQ2B04pdIRO3YGAfZAXdYjgq5CRyOjhbPvjTn5mVmvfgA hTDeooCV7s9aDPylVIuhlU+Iy+92Ttkrw0e1FqpcfzHS2yaUSWqFETEHCuXdO0JM Y1YFRPcv =p+e4 -----END PGP SIGNATURE----- --qBHmSV+TH27iWIXh--