From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFCD2C433F5 for ; Fri, 12 Nov 2021 15:41:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5422360F41 for ; Fri, 12 Nov 2021 15:41:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5422360F41 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4D0F98305A; Fri, 12 Nov 2021 16:41:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qrE3Oi5G"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 331BC83020; Fri, 12 Nov 2021 16:40:44 +0100 (CET) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8F55D83012 for ; Fri, 12 Nov 2021 16:40:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id de30so9510810qkb.0 for ; Fri, 12 Nov 2021 07:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JoiRjdeBmbbe+e3PumE4ynOzK2GsSdsadLoUlHwfVK0=; b=qrE3Oi5G2YvJshPjcQis9eMIYv2ttemJe/V7cfM5+Gl0dBV3QwDZ3PmYFeijqHAPdD bFxD9xFNcM2dK4qB5IwDmyiaGuMbclMtKJeJj4PYhoX0PwftxGaQYpt4+i3HNPW58Ej9 vAGCZwVn3lPxad1bW6vrepOhR3bfRHZ+AX3QU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JoiRjdeBmbbe+e3PumE4ynOzK2GsSdsadLoUlHwfVK0=; b=p9fflPCPQrxOIS/VCE0BeKVVqvUFQ0MoAV4twYuv8mUzmKPgv5Is1lchhrU85HhOpS JTnaBSWNaYUBIN2rBuDgrfC/N8mBmEyK/fd5NRLni76iWFmp2SBkOhOQwCtZyv6LzS73 jrgei06yj4UCZQ7hDIDzz/uwylpFUS+YPuGoI0ghXqPYflh/rSoGqeyHXQpohPpO0Ni2 3wDGCLJxhFkFjKQZmjjIipH1YEaCiHLDsKgiV78SXb984ygDrYlfldRUEyBOBfv6V6Hc 00fhFY4SaUSnMysXTwlEKgcfKm/SifDP8SOIeGCaR+U2O0stMwieb+HdIh+2J3+AkAih 2icg== X-Gm-Message-State: AOAM530NhZgLy2zBskFHOueVo6FUiipDnAzSC+jW5asUmMI0Xp9LJfmU O4//ztO/nxGP5ykwfk1MxjcM/g== X-Google-Smtp-Source: ABdhPJzW6m14zMvXPkvRA3bVBUR4z3OUG/kpWhNxuSRd7gJNQ9wBzSpZONzsmBHLz0nItRNQyg1w6w== X-Received: by 2002:ae9:eb10:: with SMTP id b16mr13833413qkg.191.1636731620456; Fri, 12 Nov 2021 07:40:20 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-99df-60fa-a7c9-fbd2.res6.spectrum.com. [2603:6081:7b01:cbda:99df:60fa:a7c9:fbd2]) by smtp.gmail.com with ESMTPSA id m9sm2939881qkn.59.2021.11.12.07.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 07:40:19 -0800 (PST) Date: Fri, 12 Nov 2021 10:40:17 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Subject: Re: [PATCH v3 15/18] pxe: Return the file size from the getfile() function Message-ID: <20211112154017.GN24579@bill-the-cat> References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.15.I5ea9daa8a0f8ddcedd99a7dcf136c195b5c9eb50@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7KxaDdL7ID0rxyuZ" Content-Disposition: inline In-Reply-To: <20211014124803.v3.15.I5ea9daa8a0f8ddcedd99a7dcf136c195b5c9eb50@changeid> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --7KxaDdL7ID0rxyuZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 14, 2021 at 12:48:08PM -0600, Simon Glass wrote: > It is pretty strange that the pxe code uses the 'filesize' environment > variable find the size of a file it has just read. >=20 > Partly this is because it uses the command-line interpreter to parse its > request to load the file. >=20 > As a first step towards unwinding this, return it directly from the > getfile() function. This makes the code a bit longer, for now, but will be > cleaned up in future patches. >=20 > Signed-off-by: Simon Glass > Reviewed-by: Artem Lapkin > Tested-by: Artem Lapkin > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! --=20 Tom --7KxaDdL7ID0rxyuZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGOiuEACgkQFHw5/5Y0 tywjaAv8CMOvahE4kkB3g76vKzMYc/Hj/wxnx6DnV04rm2SBtyKt7mB/iwh0vQZ2 aGE5+AFmype/xs8RFJEfMavAO8prwhk6KfIKgzuKZXgCaqg+5Awh4du9fZYeLza0 5qiP1icbR2to/uZEYncZlebjc9YzpRCCGN6/X/2zU05NfROswfn8OffPeXb4yaYe 6YD+xwVfnfUKxb/jopUAnxgkp+spgfOgKd54Qwn8+b1stZ1Xohf7jliRCFgmIQmM GlSaG9PUhvpv3bu0e5rAKfq6yTr20uy1t7T9lIOwXG83BDyJFOV5NwErP2Ti58Kh XFn4ZxVpMEI5vTiaT6ZNPqaHtWnX9eBcY9BrVDmVOK7VggcLt+UZMjeXseGTBCs+ vx8PXa3HCowHdCxk7rrk9dsL3iXMMWHCvey4Nzr6Aq2LeA+uyWXz6ezQNlleXimd WNOz2xf5X9ZRIsofD42T/YnVlpnuhiMAevb9nb2GgL4Ous2BNoasPi18ZVSCJm4e x63+eZzg =qZfX -----END PGP SIGNATURE----- --7KxaDdL7ID0rxyuZ--