From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BABBC433EF for ; Fri, 12 Nov 2021 15:42:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0278660296 for ; Fri, 12 Nov 2021 15:42:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0278660296 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 866F783051; Fri, 12 Nov 2021 16:42:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="OcaU9tVU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 16BFA8301B; Fri, 12 Nov 2021 16:40:44 +0100 (CET) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7BF348301C for ; Fri, 12 Nov 2021 16:40:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id u16so6494300qvk.4 for ; Fri, 12 Nov 2021 07:40:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=11iOe5ol3EfnBIBi1C/mDY+mjC+L9rTAY9MSiF9kalM=; b=OcaU9tVU8ERGhD4hwrMzsaEH79WhMeh40d9AB+2ph8KpG2q2YjLmZwBWZYW3N2PjjW AZY4euoiCsY/HuzS+3xSLb7bwGZ7U3xQe9cMlgc8xZkr9Xu3nK5asDa+JBZE0Q5MNXUr 59tZcq0NQRLCElSNOFK8tN2boZgD9kEcsdVRw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=11iOe5ol3EfnBIBi1C/mDY+mjC+L9rTAY9MSiF9kalM=; b=I10Yun5rbA/LiQkiolcGT/e1j0aakqUhxx+EDfDUeKBPaQR6kpyYZXjAmsEOo2H36x FbdB8VGHfHWPp+gKiwLWADNUOlV19Vo7FrfQFmMqy3OeOY97AUcAgrPUvz4yGqfV9q7G 21TtMCvySwbGJjJxxoWTRwJwMZ7mkXU6Bw1njeHYEO65OYp91q1sN2xVRXuIfxNWC+VM YBdEOkz9z4qx8UDRtHGoNWfklq8C5VeHfaivPXxnmLreemmybk1RB+v+AwPSs8jeluO7 PpveGQECqNYqPvGpN9Xy9RJcfR9xCSvV1c+TZBDQxSqexYnHxssam++OnSKJnxX9birC u9OQ== X-Gm-Message-State: AOAM533Oh5DPbdDe71tYTIdibf+K1PPgaNLkZGncoNKfIiU0flHSeUKX OVrBviir+vx+25CKa4/Q47vefA== X-Google-Smtp-Source: ABdhPJy4arB1l+qxIYui/Y5UqmuMG5j9DAkWIxaNyMJnBHnAfjCQrfx9s54JWIEkDI76vc3LR7J4SA== X-Received: by 2002:a05:6214:18e2:: with SMTP id ep2mr15212532qvb.45.1636731626195; Fri, 12 Nov 2021 07:40:26 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-99df-60fa-a7c9-fbd2.res6.spectrum.com. [2603:6081:7b01:cbda:99df:60fa:a7c9:fbd2]) by smtp.gmail.com with ESMTPSA id o190sm2801521qka.16.2021.11.12.07.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 07:40:25 -0800 (PST) Date: Fri, 12 Nov 2021 10:40:23 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Subject: Re: [PATCH v3 16/18] pxe: Refactor sysboot to have one helper Message-ID: <20211112154023.GO24579@bill-the-cat> References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.16.Ibd54f1a4872bc99ab0822d2c44492dc6c7581b60@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QI2YrJeuoEIMUVBX" Content-Disposition: inline In-Reply-To: <20211014124803.v3.16.Ibd54f1a4872bc99ab0822d2c44492dc6c7581b60@changeid> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --QI2YrJeuoEIMUVBX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 14, 2021 at 12:48:09PM -0600, Simon Glass wrote: > The only difference between the three helpers is the filesystem type. > Factor this out and call the filesystem functions directly, instead of > through the command-line interpreter. This allows the file size to be > obtained directly, instead of via an environment variable. >=20 > We cannot do the same thing with PXE's tftpboot since there is no API > at present to obtain information about the file that was read. So there > is no point in changing pxe_getfile_func to use a ulong for the address, > for example. >=20 > This is as far as the refactoring can go for the present. >=20 > Signed-off-by: Simon Glass > Reviewed-by: Artem Lapkin > Tested-by: Artem Lapkin > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! --=20 Tom --QI2YrJeuoEIMUVBX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGOiucACgkQFHw5/5Y0 tyyZ9wv9FW8FZ8lmxfxBDePDOouAcYdZpglRYe2GfK3B2cmbE+0f7PWVKv2JiT9l IC7mTFEq3Pbvvb50+SG3J+L0u7YaevbXdwjhAGAYtojo2FEkGTEEnOLhNGROigj3 yyQejrqzK0VLYEiOobpCMFQhtAs8T4hb5Oef3c6l3BzAOC8jag8lqGsEERO9SewO 7ZmzRysom/4fxqXmC97Yhtr/L7NDru779p56XAC5bHmKV3Y3YyPCmEJ9ifMPI6ts +S/J4UVaX5ALO9lPuBDoi/rTceH9t7+/APAOXGM4bW7mXKwEYiI/X/jMfcCNCsd0 iCAOOPI5afUTf7vzDSid00TwW4XhNjTxBDyI7N95joed/JCFNk9VejjRSglGDI8g XQWTTopMe05S8paW3u6oa7C6zFBl2sA93dPnqEKCYet2Ig9zvH9aK7WFmOeEc0Ba esju35XC3i8cgv7lLjV/4JBbO8X8xscrGG+2I8siXSyOZ8OCKGZFsLLw9/hmozkx uYxQLzoq =1Lxw -----END PGP SIGNATURE----- --QI2YrJeuoEIMUVBX--