From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Anton Bambura <jenneron@protonmail.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] media: staging: tegra-vde: Support reference picture marking
Date: Mon, 15 Nov 2021 15:44:03 +0300 [thread overview]
Message-ID: <20211115124402.GE26989@kadam> (raw)
In-Reply-To: <42b24cd0-ac37-3cfe-1fb2-d6292015318a@gmail.com>
On Mon, Nov 15, 2021 at 01:34:18AM +0300, Dmitry Osipenko wrote:
> 15.11.2021 01:23, Dmitry Osipenko пишет:
> > + vde->secure_bo = tegra_vde_alloc_bo(vde, DMA_FROM_DEVICE, 4096);
> > + if (!vde->secure_bo) {
> > + dev_err(dev, "Failed to allocate secure BO\n");
> > + goto err_pm_runtime;
> > + }
>
> My eye just caught that by accident err variable isn't assigned to
> -ENOMEM here. I'll make v2 shortly.
Smatch has a check for this so we would have caught it. :)
regards,
dan carpenter
next prev parent reply other threads:[~2021-11-15 12:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 22:23 [PATCH v1 0/3] Add NVIDIA Tegra114 support to video decoder driver Dmitry Osipenko
2021-11-14 22:23 ` [PATCH v1 1/3] media: staging: tegra-vde: Support reference picture marking Dmitry Osipenko
2021-11-14 22:34 ` Dmitry Osipenko
2021-11-15 12:44 ` Dan Carpenter [this message]
2021-11-15 14:34 ` Dmitry Osipenko
2021-11-15 15:48 ` Dan Carpenter
2021-11-17 16:19 ` Dmitry Osipenko
2021-11-18 6:07 ` Dan Carpenter
2021-11-18 6:14 ` Dan Carpenter
2021-11-18 6:21 ` Joe Perches
2021-11-18 6:53 ` Dan Carpenter
2021-11-18 6:55 ` Dan Carpenter
2021-11-18 13:56 ` Dmitry Osipenko
2021-11-19 12:30 ` Dan Carpenter
2021-11-19 16:14 ` Dmitry Osipenko
2021-11-14 22:23 ` [PATCH v1 2/3] media: staging: tegra-vde: Properly mark invalid entries Dmitry Osipenko
2021-11-14 22:23 ` [PATCH v1 3/3] media: staging: tegra-vde: Reorder misc device registration Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115124402.GE26989@kadam \
--to=dan.carpenter@oracle.com \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=jenneron@protonmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.