From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Kory Maincent <kory.maincent@bootlin.com>,
phil.eichinger@gmail.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/psplash: add support to missing configure options
Date: Mon, 15 Nov 2021 16:50:44 +0100 [thread overview]
Message-ID: <20211115165044.5a524d4b@windsurf> (raw)
In-Reply-To: <87r1bhl97g.fsf@tarshish>
On Mon, 15 Nov 2021 17:37:49 +0200
Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Thomas,
>
> On Mon, Nov 15 2021, Thomas Petazzoni wrote:
> > On Mon, 15 Nov 2021 14:30:00 +0100
> > Kory Maincent <kory.maincent@bootlin.com> wrote:
> >
> >> Add support to three configure options:
> >> --disable-startup-msg: Disable text banner output on startup
> >> --disable-progress-bar: Disable progress bar
> >> --enable-img-fullscreen: Enable the logo image in fullscreen mode
> >>
> >> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> >> ---
> >> package/psplash/.Config.in.swp | Bin 0 -> 12288 bytes
> >
> > Are you sure we want this file in Buildroot ? :-)
>
> A file of this name is already in current master branch. Introduced in
> commit 70440e28c8eef ("package/python-pudb: bump to version 2021.1").
I was confused initially, I thought you said
package/psplash/.Config.in.swp already existed, but it's .Config.in.swp
in the python-pudb package. We definitely want to get rid of it, indeed.
As an Emacs user, should I also suggest to forbid the usage of vim? :-)
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-15 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 13:29 [Buildroot] [PATCH 1/2] package/psplash: bump to revision 44afb75 Kory Maincent
2021-11-15 13:30 ` [Buildroot] [PATCH 2/2] package/psplash: add support to missing configure options Kory Maincent
2021-11-15 13:47 ` Quentin Schulz
2021-11-15 15:21 ` Köry Maincent
2021-11-15 14:38 ` Thomas Petazzoni
2021-11-15 15:37 ` Baruch Siach via buildroot
2021-11-15 15:50 ` Thomas Petazzoni [this message]
2021-11-15 16:01 ` Baruch Siach via buildroot
2021-11-15 16:48 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115165044.5a524d4b@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=baruch@tkos.co.il \
--cc=buildroot@buildroot.org \
--cc=kory.maincent@bootlin.com \
--cc=phil.eichinger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.