From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5351FC433F5 for ; Tue, 16 Nov 2021 10:04:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DF44619E3 for ; Tue, 16 Nov 2021 10:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233798AbhKPKHK (ORCPT ); Tue, 16 Nov 2021 05:07:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:39916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233795AbhKPKHI (ORCPT ); Tue, 16 Nov 2021 05:07:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A7A496152B; Tue, 16 Nov 2021 10:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637057051; bh=HFL0Gw1RVO32KPabNgK9ghbEvylzrRiWzcYgj8e+oDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A4cm7xF1rEIxsuQafQtnK18GJwO38WxptPtsHov6hg1Mwd2/e4i+L0OPiGCtiw2D0 8k7l5MWn9SK74kcD7m50Z1I4Y0mSnp+4gR2nd320npBdlkxHPO6mY9JiyJOY+ASGX8 bm6mFtcdnG2JyernNFvxML+l/ULiPclC5b3PIUsy6SBcd2Qf29cUAxw2o0wmDCjWMe JyMcWU3sCcThI9R++1pXtMan4rUnr4u99QKo7CWhN1OeaFkxgU17mNN5W6mR+L+J8G PuMg64KXXWmfpDo7RQHc9RN4lOWDfcQzgSDMU5AmAHMZPI9wcgm4kV65qh1p+GuGO5 1eqvAWxIrqIpA== Date: Tue, 16 Nov 2021 10:04:07 +0000 From: Will Deacon To: Mark Rutland Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Borislav Petkov , Catalin Marinas , Thomas Gleixner Subject: Re: [PATCH] scripts/sorttable: Unify arm64 & x86 sort functions Message-ID: <20211116100406.GA9851@willie-the-truck> References: <20211108114220.32796-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211108114220.32796-1-mark.rutland@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 08, 2021 at 11:42:20AM +0000, Mark Rutland wrote: > The format of the arm64 and x86 exception table entries is essentially > the same as of commits: > > 46d28947d9876fc0 ("x86/extable: Rework the exception table mechanics") > d6e2cc5647753825 ("arm64: extable: add `type` and `data` fields") > > Both use a 12-byte entry consisting of two 32-bit relative offsets and > 32 bits of (absolute) data, and their sort functions are identical aside > from commentary, with arm64 saying: > > /* Don't touch the fixup type or data */ > > ... and x86 saying: > > /* Don't touch the fixup type */ > > Unify the two behind a common sort_relative_table_with_data() function, > retaining the arm64 commentary. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Ard Biesheuvel > Cc: Borislav Petkov > Cc: Catalin Marinas > Cc: Thomas Gleixner > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > scripts/sorttable.c | 36 +++--------------------------------- > 1 file changed, 3 insertions(+), 33 deletions(-) Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A47C433EF for ; Tue, 16 Nov 2021 10:05:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47B556187F for ; Tue, 16 Nov 2021 10:05:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 47B556187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I0BBidTPAcupEunw3MEnJtWZ/m0FsXbEV1hV3Ut5Ohs=; b=uspYD/T9Hg3KZW NAVPAuuqzrrppwtYfA7sAP0GQ+E0Ns7ITPDNgDRWnOExT8Os4Us3dxRradR3EpmEoctyMt/TJ837H 7XYt1bCuyTejnikZeFkmNBdBzOy+bygWvts5kEyS/3PmysXqmT0mFCsStx5hY7VnySTCW/xFG8ARU Ua0QjA2Y+/PRTX+UFyderraSlG9h6m/7C7yqur2tIKKlfk3gKDQ7WCcYketDdhH0o0tZVzGHnW7kR EsdJQjFNT5cHBgMIijm2caVHKJHEhDAWUVqDknNctl1+yQHD312qZ2EPmEauwFie7n3HCzPoGZuZH n7hR4o21zZvfnMgXlFhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmvK8-0014mD-3Y; Tue, 16 Nov 2021 10:04:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmvK0-0014k2-LZ for linux-arm-kernel@lists.infradead.org; Tue, 16 Nov 2021 10:04:14 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A7A496152B; Tue, 16 Nov 2021 10:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637057051; bh=HFL0Gw1RVO32KPabNgK9ghbEvylzrRiWzcYgj8e+oDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A4cm7xF1rEIxsuQafQtnK18GJwO38WxptPtsHov6hg1Mwd2/e4i+L0OPiGCtiw2D0 8k7l5MWn9SK74kcD7m50Z1I4Y0mSnp+4gR2nd320npBdlkxHPO6mY9JiyJOY+ASGX8 bm6mFtcdnG2JyernNFvxML+l/ULiPclC5b3PIUsy6SBcd2Qf29cUAxw2o0wmDCjWMe JyMcWU3sCcThI9R++1pXtMan4rUnr4u99QKo7CWhN1OeaFkxgU17mNN5W6mR+L+J8G PuMg64KXXWmfpDo7RQHc9RN4lOWDfcQzgSDMU5AmAHMZPI9wcgm4kV65qh1p+GuGO5 1eqvAWxIrqIpA== Date: Tue, 16 Nov 2021 10:04:07 +0000 From: Will Deacon To: Mark Rutland Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Borislav Petkov , Catalin Marinas , Thomas Gleixner Subject: Re: [PATCH] scripts/sorttable: Unify arm64 & x86 sort functions Message-ID: <20211116100406.GA9851@willie-the-truck> References: <20211108114220.32796-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211108114220.32796-1-mark.rutland@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_020412_766874_9BFE3032 X-CRM114-Status: GOOD ( 15.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 08, 2021 at 11:42:20AM +0000, Mark Rutland wrote: > The format of the arm64 and x86 exception table entries is essentially > the same as of commits: > > 46d28947d9876fc0 ("x86/extable: Rework the exception table mechanics") > d6e2cc5647753825 ("arm64: extable: add `type` and `data` fields") > > Both use a 12-byte entry consisting of two 32-bit relative offsets and > 32 bits of (absolute) data, and their sort functions are identical aside > from commentary, with arm64 saying: > > /* Don't touch the fixup type or data */ > > ... and x86 saying: > > /* Don't touch the fixup type */ > > Unify the two behind a common sort_relative_table_with_data() function, > retaining the arm64 commentary. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Ard Biesheuvel > Cc: Borislav Petkov > Cc: Catalin Marinas > Cc: Thomas Gleixner > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > scripts/sorttable.c | 36 +++--------------------------------- > 1 file changed, 3 insertions(+), 33 deletions(-) Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel