From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35956C433EF for ; Tue, 16 Nov 2021 11:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DA39633DA for ; Tue, 16 Nov 2021 11:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235369AbhKPLpy (ORCPT ); Tue, 16 Nov 2021 06:45:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235145AbhKPLpn (ORCPT ); Tue, 16 Nov 2021 06:45:43 -0500 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 410D9C061746 for ; Tue, 16 Nov 2021 03:42:46 -0800 (PST) Received: by mail-pg1-x536.google.com with SMTP id r5so11411723pgi.6 for ; Tue, 16 Nov 2021 03:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=+eBFct8iAxHFKfCYs+KQCIyGjKvclEDAeXkIXTGgTXk=; b=ENIPt9NPK4NqiDnEBIo/t6hbh+6RVn2zwPg9sLXI9teJqv/p0S18Yln61hWffTVfbl yfZ3DAjcNRPJW6xejyVfeiaXdOHKMpaebJ8GQC3tAT0hHAS/2igy3/EsTMGn2IO5Ve+A VoUNLyWIVoc+imSjnqXum9JDJmVhvWdycCZlV2epkbw+/0Wpj13RJeSgTfI0JrZMaH60 RDiZlgrUGLNporArM+LxPrkUHpwLVhGz5H7BQ1nFzBuJ7gnFNJ2T8FJGILoV/o2bxkwj qQTXvArrupVzHuoXc562LD372fz1FRH6nA1VdAqUN/uI7QopWm+k8ZM0xaAylrxEg2/S daGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+eBFct8iAxHFKfCYs+KQCIyGjKvclEDAeXkIXTGgTXk=; b=VERyuY+12QGFAhPMFV+iw/cwRlO15vuAxedJGj+TekhoOfvWHEnzrKyY6dMh2KNYOi UM9d84osTTxJbUBSd70Vy0HBC58Dvnu4sMzAEuV3tQhg6YdDAqjyCsJLGqDnb4oztmPG tdAJwB+3aLIsDbAAQ7tHJYWWMuzQgf2KKH7SodWXtyI3bPantPIjpMgIUx7hgaGV2hTW 36VHCmX2pG4Q4VbABc5hL6yEYIT8rwhGgsStLTsNWHgh6yQXF/Q7whqiLtTx1J9C5//K M+7Xsd1ZSgbvBlThygRUE0fDj9IYN952QL5m5JyF/Kr47gz5uJzQkhNR6KTrG87P2NBb dhiw== X-Gm-Message-State: AOAM532d/+bYoCLF1vuxKA7ZMyr7a/vqeTYuX6Qikmo77Ct2oIvYT29T oI64KlYUTHKEyRiGNOR3ohI= X-Google-Smtp-Source: ABdhPJwN2a80DDnNchf2wIREA84QPNhruGC7rI4jBOeL9G0P8v2MKFpPvTiol4zZq/6Iz9FALdELjA== X-Received: by 2002:a63:1d65:: with SMTP id d37mr4279998pgm.353.1637062965832; Tue, 16 Nov 2021 03:42:45 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id fs21sm2148448pjb.1.2021.11.16.03.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 03:42:45 -0800 (PST) From: Miaoqian Lin Cc: linmq006@gmail.com, Gabriel Somlo , "Michael S. Tsirkin" , qemu-devel@nongnu.org, linux-kernel@vger.kernel.org Subject: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file Date: Tue, 16 Nov 2021 11:42:33 +0000 Message-Id: <20211116114233.29462-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When kobject_init_and_add() fails, entry should be freed just like when sysfs_create_bin_file() fails. Signed-off-by: Miaoqian Lin --- drivers/firmware/qemu_fw_cfg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 172c751a4f6c..0f404777f016 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f) fw_cfg_sel_ko, "%d", entry->select); if (err) { kobject_put(&entry->kobj); + kfree(entry); return err; } -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 475E5C433EF for ; Tue, 16 Nov 2021 14:23:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C71AA61502 for ; Tue, 16 Nov 2021 14:23:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C71AA61502 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:60178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmzN3-000076-TK for qemu-devel@archiver.kernel.org; Tue, 16 Nov 2021 09:23:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmwyU-000165-7P for qemu-devel@nongnu.org; Tue, 16 Nov 2021 06:50:06 -0500 Received: from [2607:f8b0:4864:20::134] (port=43535 helo=mail-il1-x134.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmwyR-0002l7-SJ for qemu-devel@nongnu.org; Tue, 16 Nov 2021 06:50:05 -0500 Received: by mail-il1-x134.google.com with SMTP id s14so20032906ilv.10 for ; Tue, 16 Nov 2021 03:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=+eBFct8iAxHFKfCYs+KQCIyGjKvclEDAeXkIXTGgTXk=; b=ENIPt9NPK4NqiDnEBIo/t6hbh+6RVn2zwPg9sLXI9teJqv/p0S18Yln61hWffTVfbl yfZ3DAjcNRPJW6xejyVfeiaXdOHKMpaebJ8GQC3tAT0hHAS/2igy3/EsTMGn2IO5Ve+A VoUNLyWIVoc+imSjnqXum9JDJmVhvWdycCZlV2epkbw+/0Wpj13RJeSgTfI0JrZMaH60 RDiZlgrUGLNporArM+LxPrkUHpwLVhGz5H7BQ1nFzBuJ7gnFNJ2T8FJGILoV/o2bxkwj qQTXvArrupVzHuoXc562LD372fz1FRH6nA1VdAqUN/uI7QopWm+k8ZM0xaAylrxEg2/S daGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+eBFct8iAxHFKfCYs+KQCIyGjKvclEDAeXkIXTGgTXk=; b=yECWkzyeqDqrqptTKzPZAjL1F3ZrpxV9Xb8TXIzR1ZDzpNlVjQGKDGePYe1s6sflbT H2xYek7Yx0CXOYdkRcOubVPEAmyzqNBbXq2u9an3T2ZyOPygP1OfCBdzuMYjj1TEA272 aMI4/LRMNoiiXBBP6vg+ttyAAFnJ0agwgA1lnsW1e30TMqokiVTR18HJQSaSETsQiN1p N6C+5bQzfm2588fHqhsQZK9iMeOgR1gupxsTR0EgqUjMsG8clMYPp2LYXerg7CJ1XbDU 2xHE5W19rUzo3ucBGAXnFoBmMg0kvWNHDT29RipseIfen7kWPUj3K5tTDkg3Jvl9cg3J MaZw== X-Gm-Message-State: AOAM533R+Mp/wxup1AvYVesZmRsYHn4N2tJDyje/f7/FlCSiQz7038gv y1vCtOAzpxRMx8XRIfoYnvqWOpYTxRCH3zRhxUI= X-Google-Smtp-Source: ABdhPJwN2a80DDnNchf2wIREA84QPNhruGC7rI4jBOeL9G0P8v2MKFpPvTiol4zZq/6Iz9FALdELjA== X-Received: by 2002:a63:1d65:: with SMTP id d37mr4279998pgm.353.1637062965832; Tue, 16 Nov 2021 03:42:45 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id fs21sm2148448pjb.1.2021.11.16.03.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 03:42:45 -0800 (PST) From: Miaoqian Lin To: Subject: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file Date: Tue, 16 Nov 2021 11:42:33 +0000 Message-Id: <20211116114233.29462-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::134 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::134; envelope-from=linmq006@gmail.com; helo=mail-il1-x134.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 16 Nov 2021 09:19:47 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, linmq006@gmail.com, Gabriel Somlo , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" When kobject_init_and_add() fails, entry should be freed just like when sysfs_create_bin_file() fails. Signed-off-by: Miaoqian Lin --- drivers/firmware/qemu_fw_cfg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 172c751a4f6c..0f404777f016 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f) fw_cfg_sel_ko, "%d", entry->select); if (err) { kobject_put(&entry->kobj); + kfree(entry); return err; } -- 2.17.1