From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4909C433FE for ; Tue, 16 Nov 2021 11:48:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5FE961AA2 for ; Tue, 16 Nov 2021 11:48:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235599AbhKPLvb (ORCPT ); Tue, 16 Nov 2021 06:51:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235500AbhKPLum (ORCPT ); Tue, 16 Nov 2021 06:50:42 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0680C061204 for ; Tue, 16 Nov 2021 03:47:44 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id y196so16622208wmc.3 for ; Tue, 16 Nov 2021 03:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hiACY3RT/nmqVxVT6gUm+SJftE33Dn6ONZen5+wUKe4=; b=tZeXA7T7FxrH+wO2umeVX7gIv3IuM0a5aQVmrXuJ1OTHoFSzTTf2zrFF7KQtawbvWR B+VVnaU4/oqQolSpCmNu9yMal0+FxT7hUQ4DRQLI6TkkhCSmOh34qqWEJsm+ZIQuPRxs elS/Xtx+wP0nnsgT42M613bh2TG8nkgy9h9Q3AHyuxlD3CQUzIiTptq1pEbKTScRVT4l TDnwN8hENbR4CawWUtdQnyUw6cHcuiz5c5vAS046+mVeIhnfFbYRy24iN3ecN9huSA6u xNAgFo7vhyqmDasDHtr9I9K+6OaHoPr7hNQyhTKV0Laeo8cRntjfTzvE4DVdTbsGJOPK xQJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hiACY3RT/nmqVxVT6gUm+SJftE33Dn6ONZen5+wUKe4=; b=8QnYx23G1ETfjIM1o2oeBnJolD5iREQVHnkFbxBweVhanvKkgVLw7ATIh0DWSezsfH pQqq64vCSCO42tdUA1QJ0xwfpA32GG0dadnyxNEwsg8iVaw1cVQLHxwtY7id1BhZeasZ LOcSkrpwjZYfwa8Mv3g3FKOFfPtFp12mbvcWuRydpo0cAEp2QFm8nDqCxilVZjggmGZz V555Io6WV85yPH2PRdf3vfozZTEE0EB4LqsNP2skh/gX1Y8t/ope0IK0anmPtdOSvYLC p6vTGeERxo0D0DvD3LE0Eh0D+1qf09ICb5+/1sJgdCoG+1wKeOg2O7TyJlbP6wQVzCBb 4Zdw== X-Gm-Message-State: AOAM533HjBLVIZl6543XTnJMGa8BiN7QyRiy8Zeai78Y76s54vue8D7R Cz1zvoBV8iKkDWTu31m6qJXk/w== X-Google-Smtp-Source: ABdhPJyXMXt8SR0JdN8T3xvPScdTMbgiy4rZOsDKYHINmSSmOmu8w+Zjf+BXGplRetFG6okhaBxfkQ== X-Received: by 2002:a05:600c:5125:: with SMTP id o37mr6995830wms.81.1637063263631; Tue, 16 Nov 2021 03:47:43 -0800 (PST) Received: from srini-hackbox.lan (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.gmail.com with ESMTPSA id l8sm2260523wmc.40.2021.11.16.03.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 03:47:43 -0800 (PST) From: Srinivas Kandagatla To: broonie@kernel.org Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 4/5] ASoC: qdsp6: q6adm: improve error reporting Date: Tue, 16 Nov 2021 11:47:20 +0000 Message-Id: <20211116114721.12517-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20211116114721.12517-1-srinivas.kandagatla@linaro.org> References: <20211116114721.12517-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org reset value for port is -1 so printing an hex would not give us very useful debug information, so use %d instead. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6adm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6adm.c b/sound/soc/qcom/qdsp6/q6adm.c index 3d831b635524..72c5719f1d25 100644 --- a/sound/soc/qcom/qdsp6/q6adm.c +++ b/sound/soc/qcom/qdsp6/q6adm.c @@ -390,7 +390,7 @@ struct q6copp *q6adm_open(struct device *dev, int port_id, int path, int rate, int ret = 0; if (port_id < 0) { - dev_err(dev, "Invalid port_id 0x%x\n", port_id); + dev_err(dev, "Invalid port_id %d\n", port_id); return ERR_PTR(-EINVAL); } @@ -508,7 +508,7 @@ int q6adm_matrix_map(struct device *dev, int path, int port_idx = payload_map.port_id[i]; if (port_idx < 0) { - dev_err(dev, "Invalid port_id 0x%x\n", + dev_err(dev, "Invalid port_id %d\n", payload_map.port_id[i]); kfree(pkt); return -EINVAL; -- 2.21.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 201C7C433EF for ; Tue, 16 Nov 2021 11:50:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0DC0615E6 for ; Tue, 16 Nov 2021 11:50:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A0DC0615E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0E66016C1; Tue, 16 Nov 2021 12:49:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0E66016C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637063410; bh=ID1BBrAzzgvXUQx7EvACVcfs6SPJNYyUyfYetVGRzlo=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KSKAltooou9AWue1J3hPss2Bblov8n1i66DIf6NNtNqwWbegfexCAh10Qp2ASxOgP RjI1BMJ7t6TzgJ/xGJ3PMwkESsA+BwwSHHHwOg/t33m/Ym/YyHk/Fmy0oTbGAYV34Y t8uv1OG+uXnOPxZG8Kt6m8kWpPDL81p5SS4XUcTk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 80922F804FA; Tue, 16 Nov 2021 12:47:58 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 29568F80518; Tue, 16 Nov 2021 12:47:56 +0100 (CET) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A55C7F802C4 for ; Tue, 16 Nov 2021 12:47:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A55C7F802C4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tZeXA7T7" Received: by mail-wm1-x331.google.com with SMTP id az33-20020a05600c602100b00333472fef04so1687252wmb.5 for ; Tue, 16 Nov 2021 03:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hiACY3RT/nmqVxVT6gUm+SJftE33Dn6ONZen5+wUKe4=; b=tZeXA7T7FxrH+wO2umeVX7gIv3IuM0a5aQVmrXuJ1OTHoFSzTTf2zrFF7KQtawbvWR B+VVnaU4/oqQolSpCmNu9yMal0+FxT7hUQ4DRQLI6TkkhCSmOh34qqWEJsm+ZIQuPRxs elS/Xtx+wP0nnsgT42M613bh2TG8nkgy9h9Q3AHyuxlD3CQUzIiTptq1pEbKTScRVT4l TDnwN8hENbR4CawWUtdQnyUw6cHcuiz5c5vAS046+mVeIhnfFbYRy24iN3ecN9huSA6u xNAgFo7vhyqmDasDHtr9I9K+6OaHoPr7hNQyhTKV0Laeo8cRntjfTzvE4DVdTbsGJOPK xQJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hiACY3RT/nmqVxVT6gUm+SJftE33Dn6ONZen5+wUKe4=; b=PszK7m6WLV9/tPMd4J0GfJUlwFpmwPMrc4PMTJ8N+ZU2cDStbUDy70ruAlAJsszWjc zhf3B+5faXn9RVEba8GZapmKxvNn1jUikqpP+ESOwObRkxsal6mjLcGPBg6LG8SE0JZ1 IbWyfPx5++TG0YB4lzu1iyQIkQp0cVxicfpzXixfVysXppFiEGQGEHYtCpFYf/d+FS8H IP38bIkBuMJ7w347eeiefccXAqiw8NegRf9XvjMtCEViL2Q6qV0gi+YwYjjWfNFnrlaG eYzpKUD32fd7ybC2/J2ivkB6d+yEpD2LlApz//zea4gnM/v9WZpxiT+L8pTE128Rsc5s i9+w== X-Gm-Message-State: AOAM533vRZUwDA0tJURmWssr2Pbh+TNApdnZpm5eLxTlkIxzSggt0ixs lN/f1f/kt5hbQsmmtrtiqb+U1w== X-Google-Smtp-Source: ABdhPJyXMXt8SR0JdN8T3xvPScdTMbgiy4rZOsDKYHINmSSmOmu8w+Zjf+BXGplRetFG6okhaBxfkQ== X-Received: by 2002:a05:600c:5125:: with SMTP id o37mr6995830wms.81.1637063263631; Tue, 16 Nov 2021 03:47:43 -0800 (PST) Received: from srini-hackbox.lan (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.gmail.com with ESMTPSA id l8sm2260523wmc.40.2021.11.16.03.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 03:47:43 -0800 (PST) From: Srinivas Kandagatla To: broonie@kernel.org Subject: [PATCH 4/5] ASoC: qdsp6: q6adm: improve error reporting Date: Tue, 16 Nov 2021 11:47:20 +0000 Message-Id: <20211116114721.12517-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20211116114721.12517-1-srinivas.kandagatla@linaro.org> References: <20211116114721.12517-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" reset value for port is -1 so printing an hex would not give us very useful debug information, so use %d instead. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6adm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6adm.c b/sound/soc/qcom/qdsp6/q6adm.c index 3d831b635524..72c5719f1d25 100644 --- a/sound/soc/qcom/qdsp6/q6adm.c +++ b/sound/soc/qcom/qdsp6/q6adm.c @@ -390,7 +390,7 @@ struct q6copp *q6adm_open(struct device *dev, int port_id, int path, int rate, int ret = 0; if (port_id < 0) { - dev_err(dev, "Invalid port_id 0x%x\n", port_id); + dev_err(dev, "Invalid port_id %d\n", port_id); return ERR_PTR(-EINVAL); } @@ -508,7 +508,7 @@ int q6adm_matrix_map(struct device *dev, int path, int port_idx = payload_map.port_id[i]; if (port_idx < 0) { - dev_err(dev, "Invalid port_id 0x%x\n", + dev_err(dev, "Invalid port_id %d\n", payload_map.port_id[i]); kfree(pkt); return -EINVAL; -- 2.21.0