From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8CC4C433EF for ; Tue, 16 Nov 2021 12:02:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8697D61B31 for ; Tue, 16 Nov 2021 12:02:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8697D61B31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DD7B86EA51; Tue, 16 Nov 2021 12:02:18 +0000 (UTC) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by gabe.freedesktop.org (Postfix) with ESMTPS id DEE516EA51 for ; Tue, 16 Nov 2021 12:02:17 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id f7-20020a1c1f07000000b0032ee11917ceso2217871wmf.0 for ; Tue, 16 Nov 2021 04:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lDB8txmndiyc2KBELD6n3DhmgYu8EUzPVuapNCQo1zs=; b=mldJEOu5NnmqmiMKzPY9mz4IDbBaAR8ZcKLbG0mHBR1p/bymyHk4A4WmkcwvmMlC49 QXby76RujpVem0BcrrnMrZl6V/5ovityJgIR9R7IPEF0w0lN9nfNaFvG0ZcaH+odLMrV BLXG0Gj43otjSUslxvnTqFnMIdf5lgrLEgxMaJF7BAnLMjfYaLV9ccYKHnkaHna67Tc3 f+NUSLHyELqD+EhXH//cGilrC5xyNQn+yfKIGQYlMBCY4T69ZIUyZOXC7PX9sLQuUUkd 3TE726MkaJFV+JTdlj8n3RWk/IG/usYTIma6oaI5FhMfjDY0uR1acYx+8yBvUL03L8zj xviw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lDB8txmndiyc2KBELD6n3DhmgYu8EUzPVuapNCQo1zs=; b=IGAq/WnatZ8TGMjsiGNRwyO0UIy0qeq1NooK7YZkS8xVRKvuJ8PvgBu1bjasjcmdnu QEpwCqp81BrGUJAh4hK+YD0HNF3gJVgSXSCDr4vv6DuTqNWUJLVguMhGaOWJfQe8kk8M T9I1Ub6t7SZmSddGwpv+4vM/DFPVdG9nH+rxLUE4rtCmqCyopvjyFOXM+Bb8ODmjDD33 +aUpfiDlLNpbRbv8rFRPfgTW1wpQE0ljmVGC0lzaQ9ugFKdG3gI/lvaTCqZHuNn4T3ZM +evD5dKeKmR9ZoL5gRAZLTHQlY+e65xoNExHf/+DOx6W0014GKZ2Rkba5jaokrVC+cpl OkNw== X-Gm-Message-State: AOAM531A50jqALC/rz6gLZaLy9c4oNzT8Mz1A1TxDzmHCDLNF5chRi2i SC3es3BLh+yLteTj38kHTOmJHaS4eGJ8lp5E X-Google-Smtp-Source: ABdhPJy0s8g4BijfftlxD/F7elVGNq4pmmk3Cu5+zRpMwyxjgqhMYGMoZqI1RiG+YUAJq6W28VKZIg== X-Received: by 2002:a05:600c:a0b:: with SMTP id z11mr70111480wmp.147.1637064136454; Tue, 16 Nov 2021 04:02:16 -0800 (PST) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id l124sm2298443wml.8.2021.11.16.04.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 04:02:15 -0800 (PST) Date: Tue, 16 Nov 2021 12:02:13 +0000 From: Daniel Thompson To: Lee Jones Subject: Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Message-ID: <20211116120213.n7qxqfi62lrxhyl7@maple.lan> References: <20211115203459.1634079-1-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211115203459.1634079-1-marijn.suijten@somainline.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Kiran Gunda , Pavel Dubrova , Jami Kettunen , Jingoo Han , linux-arm-msm@vger.kernel.org, Bryan Wu , Konrad Dybcio , linux-kernel@vger.kernel.org, Rob Herring , Bjorn Andersson , Andy Gross , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Marijn Suijten , phone-devel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Lee On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > This patchset fixes WLED's handling of enabled-strings: besides some > cleanup it is now actually possible to specify a non-contiguous array of > enabled strings (not necessarily starting at zero) and the values from > DT are now validated to prevent possible unexpected out-of-bounds > register and array element accesses. > Off-by-one mistakes in the maximum number of strings, also causing > out-of-bounds access, have been addressed as well. They have arrived piecemeal (during v1, v2 and v3) but all patches on the set should now have my R-b: attached to them. Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15ED2C433EF for ; Tue, 16 Nov 2021 12:09:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF4D2615E2 for ; Tue, 16 Nov 2021 12:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235885AbhKPMMp (ORCPT ); Tue, 16 Nov 2021 07:12:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235929AbhKPMKo (ORCPT ); Tue, 16 Nov 2021 07:10:44 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE12BC0432D4 for ; Tue, 16 Nov 2021 04:02:17 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id az33-20020a05600c602100b00333472fef04so1722857wmb.5 for ; Tue, 16 Nov 2021 04:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lDB8txmndiyc2KBELD6n3DhmgYu8EUzPVuapNCQo1zs=; b=mldJEOu5NnmqmiMKzPY9mz4IDbBaAR8ZcKLbG0mHBR1p/bymyHk4A4WmkcwvmMlC49 QXby76RujpVem0BcrrnMrZl6V/5ovityJgIR9R7IPEF0w0lN9nfNaFvG0ZcaH+odLMrV BLXG0Gj43otjSUslxvnTqFnMIdf5lgrLEgxMaJF7BAnLMjfYaLV9ccYKHnkaHna67Tc3 f+NUSLHyELqD+EhXH//cGilrC5xyNQn+yfKIGQYlMBCY4T69ZIUyZOXC7PX9sLQuUUkd 3TE726MkaJFV+JTdlj8n3RWk/IG/usYTIma6oaI5FhMfjDY0uR1acYx+8yBvUL03L8zj xviw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lDB8txmndiyc2KBELD6n3DhmgYu8EUzPVuapNCQo1zs=; b=NBa7mTXZIQHss6ES/n3QovQiO3jyZdRkRCtoLJC1TK9v40fyu91pSwUtlcMHwmV8zZ 15dwHZxmE1qXUQ7pfP7+1VbwmPR4nRrtnqOFiaLNBwc6DQlKcQiZ7lemUuJ9FfBGKEL0 BSdn+zUKNtH9a87TRrydO2Habn3/8Rxh6dMeFGU9hyiDwOaa0OsyWmXHHyM+6xj828tA ygq5tpr2e8bvV4MT1AB9u/LEV3PlRRmFvKFJjyU02M9/SKgUEnQlmeNn0xqyrqNRBLhG a0xz20dFSfLrrQxV0aZa38nfy3Lb+WS9sXXzFzW/vCDEeJaxWgCLSKe4CLuK5VEVWli7 AUOA== X-Gm-Message-State: AOAM533gdG1IM7h83Gp/416vy7hPUh7i5PscWBxnUx5RCqoVP+23bP3B fAYEF7T6D0ExyPkPcYI1R+r5sg== X-Google-Smtp-Source: ABdhPJy0s8g4BijfftlxD/F7elVGNq4pmmk3Cu5+zRpMwyxjgqhMYGMoZqI1RiG+YUAJq6W28VKZIg== X-Received: by 2002:a05:600c:a0b:: with SMTP id z11mr70111480wmp.147.1637064136454; Tue, 16 Nov 2021 04:02:16 -0800 (PST) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id l124sm2298443wml.8.2021.11.16.04.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 04:02:15 -0800 (PST) Date: Tue, 16 Nov 2021 12:02:13 +0000 From: Daniel Thompson To: Lee Jones Cc: phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Marijn Suijten , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Bryan Wu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Message-ID: <20211116120213.n7qxqfi62lrxhyl7@maple.lan> References: <20211115203459.1634079-1-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211115203459.1634079-1-marijn.suijten@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Lee On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > This patchset fixes WLED's handling of enabled-strings: besides some > cleanup it is now actually possible to specify a non-contiguous array of > enabled strings (not necessarily starting at zero) and the values from > DT are now validated to prevent possible unexpected out-of-bounds > register and array element accesses. > Off-by-one mistakes in the maximum number of strings, also causing > out-of-bounds access, have been addressed as well. They have arrived piecemeal (during v1, v2 and v3) but all patches on the set should now have my R-b: attached to them. Daniel.