From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30667C433F5 for ; Tue, 16 Nov 2021 13:14:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9335761248 for ; Tue, 16 Nov 2021 13:14:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9335761248 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D9D4283919; Tue, 16 Nov 2021 14:14:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="d6BXynnB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6F0A083919; Tue, 16 Nov 2021 14:14:01 +0100 (CET) Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 375578390F for ; Tue, 16 Nov 2021 14:13:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf35.google.com with SMTP id g1so12047128qvd.2 for ; Tue, 16 Nov 2021 05:13:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wxmpo+mE+psH3Fm38UpvFszHtd9+xBjSSwwcRsfLVcg=; b=d6BXynnBZBpocug2ny9a4t/UGZiBZyrOAoPopaOur/AHi62+wHTi4JNLh0n0IKCrlN /j1g9ATGat7tC6ogFD1m8/v998oOhBENVawRX+GX4Pv+SRviJDcjIpL9wuWIxSUyrD0t rdhbtSLJ7ASpcaQ2gWxy8SE3tcY457O/4VE3Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wxmpo+mE+psH3Fm38UpvFszHtd9+xBjSSwwcRsfLVcg=; b=HmHHp+viaklSuf8mZdJCLoPaKnaLFimo/c8m2ffZqdz9DgEMdp96mbhQRz9Uk82zRL gCnsmzjyWSw2pC9IxzcYDwr/Pwh14epllozsD0uEBooBCZnKPiOc+GP/LnZtWq20Oi/q tVRM2VsjgprmhdxbTWdf/PSQv7a/0TlVKCMOgOBKILDAVUhdOmJLQK3v8my8bAj5xoNf QkogCgPbzEK/TZAFW+eVcctfOa/79PRiLun4nS8/Ts/LbXY+aeB4DJqivMQyFhZRFSKs //Se4UggppB0X/R7sQxhPTAZqsN0Vj7WY/mYdZ4ouPgMaZ4LvOIIl5ZVJr3rsggzd0O5 gbjw== X-Gm-Message-State: AOAM530HZ7JHqOHrDiTHWPFaYSIDb9AhbbQZ5U296iNERfPvfdKcBv+T DTxxNKZyBeQexgGxH6ta7CEFeQ== X-Google-Smtp-Source: ABdhPJyBtiOUJi03xnN+i4UBHxpgBGAI+JUymtjMbSZ180/TYmcNPpVzRhIW39JRvdvUacMD3TQ6AQ== X-Received: by 2002:a0c:c784:: with SMTP id k4mr36501162qvj.1.1637068430658; Tue, 16 Nov 2021 05:13:50 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-24a1-dfd8-1438-caaa.res6.spectrum.com. [2603:6081:7b01:cbda:24a1:dfd8:1438:caaa]) by smtp.gmail.com with ESMTPSA id p18sm4853482qtk.54.2021.11.16.05.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 05:13:49 -0800 (PST) Date: Tue, 16 Nov 2021 08:13:47 -0500 From: Tom Rini To: Fabio Estevam Cc: Ariel D'Alessandro , U-Boot-Denx , dl-uboot-imx , Adam Ford , Andre Przywara , ZHIZHIKIN Andrey , Christian Hewitt , Heiko Schocher , Ilko Iliev , Jagan Teki , Marcel Ziswiler , Neil Armstrong , Patrick Delaunay , Peter Robinson , Peng Fan , Rick Chen , Stefano Babic , Sean Anderson , Simon Glass , Teresa Remmet , Tim Harvey Subject: Re: [PATCH v3 1/1] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board Message-ID: <20211116131347.GA24579@bill-the-cat> References: <20211116035055.1194673-1-ariel.dalessandro@collabora.com> <20211116035055.1194673-2-ariel.dalessandro@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dsOG/KnxnmRAEFEh" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --dsOG/KnxnmRAEFEh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 16, 2021 at 08:37:06AM -0300, Fabio Estevam wrote: > Hi Ariel, >=20 > The patch looks good. Only some minor comments: >=20 > On Tue, Nov 16, 2021 at 12:51 AM Ariel D'Alessandro > wrote: > > > > Add support for iMX8MN VAR-SOM-MX8M-NANO board. Enables support for: > > > > - 1GiB DDR4 RAM > > - 16 GiB eMMC > > - SD card > > - Gigabit ethernet > > - USBOTG1 peripheral - fastboot > > > > Signed-off-by: Ariel D'Alessandro >=20 > It would be nice to have a README file so that the users can know how > to build and flash mainline > U-Boot in this board. And that means an entry under doc/board/variscite/ to be clear. --=20 Tom --dsOG/KnxnmRAEFEh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGTrocACgkQFHw5/5Y0 tyy8lQv/d2sB2t4oFhofvmtuBC7mfcvNwc0dIEdZFNyHXSC2hGmOqAiksrEW1G6r HiFeZEbaFTsFoA17TzySJ/kyLEMyhFNVzblDtYdNY/yUfXmW+/8HVronrMa7+2pA 3fM4FRJsSWh240nnuM1nd1h3oJXrvtLHVrdHQeRkhD+5UtfYgqJ9Q9q+RLRTAkJV eQOa/dTmWeR0YdyI2nm0uGcSF6hiiFKQZ3dZFrtr0gipn4MlVK17MDN8R0pnRhZa 1d7cXh+WOes75vfyQc+M3WqwyjtKKDc8TCHQOFI8THHkHkvLyWAwWYAxdJtI002k Ax0cXjo5lteP9E3mNuB5jZJDJmNVrlmh/tLGYVuFeK3wNvFlT/f68j0dSacH8IyT iyAFg6sSJsFd6GCa8vLh+iOEGPKLbpmjwSvYrfy43Z7Glx0h5Ejt9xNV32hEh+XD eDh0mJQ5MqWWeq7TvTNakiFb2PM5qCpcZau1SP9cMK0GcE3qIO8xa1xSyjPT6HNQ GozDOz/6 =u8mW -----END PGP SIGNATURE----- --dsOG/KnxnmRAEFEh--