Re: ethdev: hide internal structures

From: Stephen Hemminger <stephen@networkplumber.org>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: ethdev: hide internal structures
Date: Tue, 16 Nov 2021 13:25:10 -0800	[thread overview]
Message-ID: <20211116132510.49731a0c@hermes.local> (raw)
In-Reply-To: <20211116191018.GA31070@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

On Tue, 16 Nov 2021 11:10:18 -0800
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:

> On Tue, Nov 16, 2021 at 10:32:55AM +0000, Ananyev, Konstantin wrote:
> >  
> > rte_eth_dev,  rte_eth_dev_data, rte_eth_rxtx_callback are internal
> > data structures that were used by public inline ethdev functions. 
> > Well behaving app should not access these data structures directly.
> > So, for well behaving app there should no changes in the code required.
> > That what I meant by 'transparent' above.
> > But it is still an ABI change, so yes, the app has to be re-compiled.   
> 
> so it appears the application was establishing a private context /
> vendor extension between the application and a pmd. the application
> was abusing access to the rte_eth_devices[] to get the private context
> from the rte_eth_dev.
> 
> is there a proper / supported way of providing this functionality
> through the public api?
> 
> > 
> > Konstantin  

Keep a array in application?  Portid is universally
available.

struct my_portdata *my_ports[RTE_ETH_MAXPORTS];