From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947D2C433F5 for ; Wed, 17 Nov 2021 06:27:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63F966124B for ; Wed, 17 Nov 2021 06:27:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231559AbhKQGaG (ORCPT ); Wed, 17 Nov 2021 01:30:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbhKQGaF (ORCPT ); Wed, 17 Nov 2021 01:30:05 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A7B3C061570 for ; Tue, 16 Nov 2021 22:27:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=u9TsPfVua2pwgRzMzKBVPHm36omW56UbBxtvj9Ocw54=; b=njoPg6BUseWHQbB5/AdOoGllFW wq2z+48UGzdBL4b1Yi6fsYRMo46LYrahgc76iif1KX3VRanpst2g3djxbUw3VRokOHInqKb+Jt0Gd F8CZl5FvvBlU0s5x9Uqp4hswI47kD89reJ3fxVXvTn1JW8PPPPGk3z6jM/MaKoqlMaW3mZVnP/71W nBJaOoCCl7qmJBmPhMvv4ueMHBoHcC5p2JlGAn9J9OaBfi2fxSh2oqkBr9awRZTwCytKDrL4o1fqB yjNzwMdmlHdM573FNKsP1vHf6E7vzSDRpqeBPpSfgv39Ltkmhy1ZAF2NekmoNpZS7UhkvIy8SrSs4 KsVlb5Mw==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnEPR-003TQW-5q; Wed, 17 Nov 2021 06:27:05 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Arnd Bergmann , Daniel Vetter , Javier Martinez Canillas , Sam Ravnborg , Douglas Anderson , Linus Walleij , Thierry Reding , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/panel-edp: modify Kconfig to prevent build error Date: Tue, 16 Nov 2021 22:27:04 -0800 Message-Id: <20211117062704.14671-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_DRM_KMS_HELPER=m and CONFIG_DRM_PANEL_EDP=y, there is a build error in gpu/drm/panel/panel-edp.o: arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-edp.o: in function `panel_edp_probe': panel-edp.c:(.text+0xf38): undefined reference to `drm_panel_dp_aux_backlight' Fix this by limiting DRM_PANEL_DEP by the value of the DRM_KMS_HELPER symbol. Fixes: 5f04e7ce392d ("drm/panel-edp: Split eDP panels out of panel-simple") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Arnd Bergmann Cc: Daniel Vetter Cc: Javier Martinez Canillas Cc: Sam Ravnborg Cc: Douglas Anderson Cc: Linus Walleij Cc: Thierry Reding Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/panel/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20211117.orig/drivers/gpu/drm/panel/Kconfig +++ linux-next-20211117/drivers/gpu/drm/panel/Kconfig @@ -104,6 +104,7 @@ config DRM_PANEL_EDP depends on OF depends on BACKLIGHT_CLASS_DEVICE depends on PM + depends on DRM_KMS_HELPER select VIDEOMODE_HELPERS select DRM_DP_AUX_BUS help From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0213EC433EF for ; Wed, 17 Nov 2021 06:27:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BD6E6124B for ; Wed, 17 Nov 2021 06:27:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8BD6E6124B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B54AC6E406; Wed, 17 Nov 2021 06:27:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9483E6E406 for ; Wed, 17 Nov 2021 06:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=u9TsPfVua2pwgRzMzKBVPHm36omW56UbBxtvj9Ocw54=; b=njoPg6BUseWHQbB5/AdOoGllFW wq2z+48UGzdBL4b1Yi6fsYRMo46LYrahgc76iif1KX3VRanpst2g3djxbUw3VRokOHInqKb+Jt0Gd F8CZl5FvvBlU0s5x9Uqp4hswI47kD89reJ3fxVXvTn1JW8PPPPGk3z6jM/MaKoqlMaW3mZVnP/71W nBJaOoCCl7qmJBmPhMvv4ueMHBoHcC5p2JlGAn9J9OaBfi2fxSh2oqkBr9awRZTwCytKDrL4o1fqB yjNzwMdmlHdM573FNKsP1vHf6E7vzSDRpqeBPpSfgv39Ltkmhy1ZAF2NekmoNpZS7UhkvIy8SrSs4 KsVlb5Mw==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnEPR-003TQW-5q; Wed, 17 Nov 2021 06:27:05 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Subject: [PATCH] drm/panel-edp: modify Kconfig to prevent build error Date: Tue, 16 Nov 2021 22:27:04 -0800 Message-Id: <20211117062704.14671-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , Arnd Bergmann , Daniel Vetter , Randy Dunlap , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, Douglas Anderson , Thierry Reding , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When CONFIG_DRM_KMS_HELPER=m and CONFIG_DRM_PANEL_EDP=y, there is a build error in gpu/drm/panel/panel-edp.o: arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-edp.o: in function `panel_edp_probe': panel-edp.c:(.text+0xf38): undefined reference to `drm_panel_dp_aux_backlight' Fix this by limiting DRM_PANEL_DEP by the value of the DRM_KMS_HELPER symbol. Fixes: 5f04e7ce392d ("drm/panel-edp: Split eDP panels out of panel-simple") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Arnd Bergmann Cc: Daniel Vetter Cc: Javier Martinez Canillas Cc: Sam Ravnborg Cc: Douglas Anderson Cc: Linus Walleij Cc: Thierry Reding Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/panel/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20211117.orig/drivers/gpu/drm/panel/Kconfig +++ linux-next-20211117/drivers/gpu/drm/panel/Kconfig @@ -104,6 +104,7 @@ config DRM_PANEL_EDP depends on OF depends on BACKLIGHT_CLASS_DEVICE depends on PM + depends on DRM_KMS_HELPER select VIDEOMODE_HELPERS select DRM_DP_AUX_BUS help