* [PATCH v2] drm/bridge: anx7625: Check GPIO description to avoid crash
@ 2021-11-18 5:45 Xin Ji
0 siblings, 0 replies; 6+ messages in thread
From: Xin Ji @ 2021-11-18 5:45 UTC (permalink / raw)
To: narmstrong, dan.carpenter, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, sam, pihsun, tzungbi, maxime,
drinkcat, hsinyi, dri-devel, linux-kernel, bliang, qwen
Cc: Xin Ji
As GPIO probe function "devm_gpiod_get_optional()" may return error
code, driver should identify GPIO desc as NULL to avoid crash.
Acked-by: Tzung-Bi Shih <tzungbi@google.com>
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 001fb39d9919..a872cfaf6257 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1098,9 +1098,18 @@ static void anx7625_init_gpio(struct anx7625_data *platform)
/* Gpio for chip power enable */
platform->pdata.gpio_p_on =
devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
+ if (IS_ERR_OR_NULL(platform->pdata.gpio_p_on)) {
+ DRM_DEV_DEBUG_DRIVER(dev, "no enable gpio found\n");
+ platform->pdata.gpio_p_on = NULL;
+ }
+
/* Gpio for chip reset */
platform->pdata.gpio_reset =
devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
+ if (IS_ERR_OR_NULL(platform->pdata.gpio_reset)) {
+ DRM_DEV_DEBUG_DRIVER(dev, "no reset gpio found\n");
+ platform->pdata.gpio_p_on = NULL;
+ }
if (platform->pdata.gpio_p_on && platform->pdata.gpio_reset) {
platform->pdata.low_power_mode = 1;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Check GPIO description to avoid crash
2022-01-04 13:37 ` Robert Foss
@ 2022-01-04 13:39 ` Robert Foss
-1 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-01-04 13:39 UTC (permalink / raw)
To: Xin Ji
Cc: narmstrong, dan.carpenter, laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, sam, pihsun, tzungbi, maxime,
drinkcat, hsinyi, dri-devel, linux-kernel, bliang, qwen
Applied to drm-misc-next
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Check GPIO description to avoid crash
@ 2022-01-04 13:39 ` Robert Foss
0 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-01-04 13:39 UTC (permalink / raw)
To: Xin Ji
Cc: drinkcat, pihsun, jonas, airlied, bliang, dri-devel, narmstrong,
linux-kernel, jernej.skrabec, tzungbi, laurent.pinchart, hsinyi,
sam, qwen, dan.carpenter, maxime
Applied to drm-misc-next
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Check GPIO description to avoid crash
2021-11-19 1:58 Xin Ji
@ 2022-01-04 13:37 ` Robert Foss
0 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-01-04 13:37 UTC (permalink / raw)
To: Xin Ji
Cc: narmstrong, dan.carpenter, laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, sam, pihsun, tzungbi, maxime,
drinkcat, hsinyi, dri-devel, linux-kernel, bliang, qwen
On Fri, 19 Nov 2021 at 02:58, Xin Ji <xji@analogixsemi.com> wrote:
>
> As GPIO probe function "devm_gpiod_get_optional()" may return error
> code, driver should identify GPIO desc as NULL to avoid crash.
>
> Acked-by: Tzung-Bi Shih <tzungbi@google.com>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 001fb39d9919..652ae814246d 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1098,9 +1098,18 @@ static void anx7625_init_gpio(struct anx7625_data *platform)
> /* Gpio for chip power enable */
> platform->pdata.gpio_p_on =
> devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
> + if (IS_ERR_OR_NULL(platform->pdata.gpio_p_on)) {
> + DRM_DEV_DEBUG_DRIVER(dev, "no enable gpio found\n");
> + platform->pdata.gpio_p_on = NULL;
> + }
> +
> /* Gpio for chip reset */
> platform->pdata.gpio_reset =
> devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
> + if (IS_ERR_OR_NULL(platform->pdata.gpio_reset)) {
> + DRM_DEV_DEBUG_DRIVER(dev, "no reset gpio found\n");
> + platform->pdata.gpio_reset = NULL;
> + }
>
> if (platform->pdata.gpio_p_on && platform->pdata.gpio_reset) {
> platform->pdata.low_power_mode = 1;
> --
> 2.25.1
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Check GPIO description to avoid crash
@ 2022-01-04 13:37 ` Robert Foss
0 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-01-04 13:37 UTC (permalink / raw)
To: Xin Ji
Cc: drinkcat, pihsun, jonas, airlied, bliang, dri-devel, narmstrong,
linux-kernel, jernej.skrabec, tzungbi, laurent.pinchart, hsinyi,
sam, qwen, dan.carpenter, maxime
On Fri, 19 Nov 2021 at 02:58, Xin Ji <xji@analogixsemi.com> wrote:
>
> As GPIO probe function "devm_gpiod_get_optional()" may return error
> code, driver should identify GPIO desc as NULL to avoid crash.
>
> Acked-by: Tzung-Bi Shih <tzungbi@google.com>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 001fb39d9919..652ae814246d 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1098,9 +1098,18 @@ static void anx7625_init_gpio(struct anx7625_data *platform)
> /* Gpio for chip power enable */
> platform->pdata.gpio_p_on =
> devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
> + if (IS_ERR_OR_NULL(platform->pdata.gpio_p_on)) {
> + DRM_DEV_DEBUG_DRIVER(dev, "no enable gpio found\n");
> + platform->pdata.gpio_p_on = NULL;
> + }
> +
> /* Gpio for chip reset */
> platform->pdata.gpio_reset =
> devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
> + if (IS_ERR_OR_NULL(platform->pdata.gpio_reset)) {
> + DRM_DEV_DEBUG_DRIVER(dev, "no reset gpio found\n");
> + platform->pdata.gpio_reset = NULL;
> + }
>
> if (platform->pdata.gpio_p_on && platform->pdata.gpio_reset) {
> platform->pdata.low_power_mode = 1;
> --
> 2.25.1
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] drm/bridge: anx7625: Check GPIO description to avoid crash
@ 2021-11-19 1:58 Xin Ji
2022-01-04 13:37 ` Robert Foss
0 siblings, 1 reply; 6+ messages in thread
From: Xin Ji @ 2021-11-19 1:58 UTC (permalink / raw)
To: narmstrong, dan.carpenter, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, sam, pihsun, tzungbi, maxime,
drinkcat, hsinyi, dri-devel, linux-kernel, bliang, qwen
Cc: Xin Ji
As GPIO probe function "devm_gpiod_get_optional()" may return error
code, driver should identify GPIO desc as NULL to avoid crash.
Acked-by: Tzung-Bi Shih <tzungbi@google.com>
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 001fb39d9919..652ae814246d 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1098,9 +1098,18 @@ static void anx7625_init_gpio(struct anx7625_data *platform)
/* Gpio for chip power enable */
platform->pdata.gpio_p_on =
devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
+ if (IS_ERR_OR_NULL(platform->pdata.gpio_p_on)) {
+ DRM_DEV_DEBUG_DRIVER(dev, "no enable gpio found\n");
+ platform->pdata.gpio_p_on = NULL;
+ }
+
/* Gpio for chip reset */
platform->pdata.gpio_reset =
devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
+ if (IS_ERR_OR_NULL(platform->pdata.gpio_reset)) {
+ DRM_DEV_DEBUG_DRIVER(dev, "no reset gpio found\n");
+ platform->pdata.gpio_reset = NULL;
+ }
if (platform->pdata.gpio_p_on && platform->pdata.gpio_reset) {
platform->pdata.low_power_mode = 1;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-04 13:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 5:45 [PATCH v2] drm/bridge: anx7625: Check GPIO description to avoid crash Xin Ji
2021-11-19 1:58 Xin Ji
2022-01-04 13:37 ` Robert Foss
2022-01-04 13:37 ` Robert Foss
2022-01-04 13:39 ` Robert Foss
2022-01-04 13:39 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.