From: Stephen Hemminger <stephen@networkplumber.org>
To: Parav Pandit <parav@nvidia.com>
Cc: <dsahern@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next iproute2] vdpa: Remove duplicate vdpa UAPI header file
Date: Thu, 18 Nov 2021 08:18:44 -0800 [thread overview]
Message-ID: <20211118081844.19bb7a96@hermes.local> (raw)
In-Reply-To: <20211106064152.313417-1-parav@nvidia.com>
On Sat, 6 Nov 2021 08:41:52 +0200
Parav Pandit <parav@nvidia.com> wrote:
> vdpa header file is already present in the tree at
> vdpa/include/uapi/linux/vdpa.h and used by vdpa/vdpa.c.
>
> As we discussed in thread [1] vdpa header comes from a different
> tree, similar to rdma subsystem. Hence remove the duplicate vdpa
> UAPI header file.
>
> [1] https://www.spinics.net/lists/netdev/msg748458.html
>
> Fixes: b5a6ed9cc9fc ("uapi: add missing virtio related headers")
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> include/uapi/linux/vdpa.h | 40 ---------------------------------------
> 1 file changed, 40 deletions(-)
> delete mode 100644 include/uapi/linux/vdpa.h
Ok, but the vdpa.h needs to be kept updated, let me add that
subtree to my update-headers script.
The update headers script does 'make install_headers' in the
Linux kernel tree then clones them to iproute2.
I would prefer that Rdma and Vdpa do not have their own
headers. The future chance of version skew is too high.
For now, the tool will update all three locations.
next prev parent reply other threads:[~2021-11-18 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 6:41 [PATCH net-next iproute2] vdpa: Remove duplicate vdpa UAPI header file Parav Pandit
2021-11-18 4:21 ` Parav Pandit
2021-11-18 16:18 ` Stephen Hemminger [this message]
2021-11-18 17:51 ` David Ahern
2021-11-18 18:00 ` [PATCH iproute2] vdpa: align uapi headers Stephen Hemminger
2021-11-18 18:10 ` patchwork-bot+netdevbpf
2021-11-22 2:52 ` Parav Pandit
2021-11-22 4:11 ` Stephen Hemminger
2021-11-22 5:18 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118081844.19bb7a96@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.