From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7DCBC433F5 for ; Fri, 19 Nov 2021 01:14:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B65B0611C7 for ; Fri, 19 Nov 2021 01:14:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B65B0611C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F3008128D; Fri, 19 Nov 2021 02:14:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ck4v8on7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B616282FB8; Fri, 19 Nov 2021 02:14:31 +0100 (CET) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3DD63805F9 for ; Fri, 19 Nov 2021 02:14:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id a2so8037417qtx.11 for ; Thu, 18 Nov 2021 17:14:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nzhEzpGEJB7HqSCODPAC/L9Jc50hX6queuCQRT+rIGY=; b=ck4v8on79ZkQ8Pe9fgMC8vrfzhMzF2q9XJ97NyS5tdq3/3Pe6PqM8lYS2cVMYJyDI+ adXnLB50wFCHFxWnYSrbDpyt/7jGRvZuPaJT/alXaOIVkt6E3rDGJ5h/1fJRE2zqFY4q K9nseiGdAfGMpzVd/uOxoGZNN+ss7EgA0eoww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nzhEzpGEJB7HqSCODPAC/L9Jc50hX6queuCQRT+rIGY=; b=GivUzn/CWK32I84OyXJCaTro/V366yF3b5ogdG8m+MYaBlJGDAA+5lgm8q6XbrmVYK pz56WxP+Rbak6FAXLDzbHjphiEWQfueCrPc6rQhzttWUOkbQ9ARmgE28qvj/KwA3NCtt CIwllnDG4RJ+QROCkqtM9/xd3C1a5v7/tvqPBr6SCH9ZhhrbbAtdESVz4TIrrIEikDTd In6bULMrma2k6mK9xwyk1gAR3MNUWmMZ0c0ZDPIRcHhAl6ifl3QK0McmETkrR8MSfX1F lVURDuXMhqtpfvHb4kbMd4RTmpx/BgGA96/b5RBTyHXWbLktpZk4dOeSLBmnS0npkFR/ A3rg== X-Gm-Message-State: AOAM532axRpuIyADmbCtzZXlioezakzy8psixJjKgLFXg3mhBLjvb8F1 IHFhLdDYNW7b49oZFY/eeAWfLw== X-Google-Smtp-Source: ABdhPJw9Y119YaIMV3hSSNqZhKq1MYrMcb3iH+1N678YI/z3DT5CV00uWziJR3SiY5bkfwGU8Ggm3w== X-Received: by 2002:a05:622a:1487:: with SMTP id t7mr2052090qtx.326.1637284467047; Thu, 18 Nov 2021 17:14:27 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-6986-0eb7-a1cc-35fa.res6.spectrum.com. [2603:6081:7b01:cbda:6986:eb7:a1cc:35fa]) by smtp.gmail.com with ESMTPSA id 139sm787328qkn.37.2021.11.18.17.14.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Nov 2021 17:14:26 -0800 (PST) Date: Thu, 18 Nov 2021 20:14:24 -0500 From: Tom Rini To: Bin Meng Cc: Jon Lin , U-Boot Mailing List , xxm@rock-chips.com, Lin Shawn , zyf@rock-chips.com, Kever Yang Subject: Re: [PATCH v3 1/2] nvme: Enable FUA Message-ID: <20211119011424.GG24579@bill-the-cat> References: <20211019104049.v3.1.Ic581ec99f46b6dfa2e0b1922e670a333ac859e82@changeid> <20211118191449.GI24579@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uLx7neljFSTKPRzN" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --uLx7neljFSTKPRzN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 19, 2021 at 08:56:08AM +0800, Bin Meng wrote: > Hi Tom, >=20 > On Fri, Nov 19, 2021 at 3:14 AM Tom Rini wrote: > > > > On Tue, Oct 19, 2021 at 10:40:53AM +0800, Jon Lin wrote: > > > > > Most NVME devcies maintain data in internal cache for an uncertain > > > times, and u-boot has no method to force NVME to flush cache. > > > So this patch adds FUA to avoid data loss caused by power off after d= ata > > > programming. > > > > > > Signed-off-by: Jon Lin > > > Reviewed-by: Stefan Agner > > > > Applied to u-boot/next, thanks! >=20 > I don't see my review comment being addressed. Please drop the patch > until all things are clear. Missed your comments, sorry. --=20 Tom --uLx7neljFSTKPRzN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGW+mkACgkQFHw5/5Y0 tyzpVAwAmRYDO9rMoFMm7vDWtjMGGhHMEprYK0ONPpijf9AC7jMgRFHHq/0HIm9J rxqdvgJel9bu/bQUxj5tG82newrW7K9jQi0YOTf6YUIlaJCgNmOQ6XhNZq+cWlwA cZbfS50ypAHKEWNLspqcv2WzNcxaE2fXAeHSCbWF4Q77eMrjR2oHSf0vr9nJmBNb GymiIUAJQuO+Xr25EaUPqFg4gbRmPm+yoevsYSf5J60+DgHXdf+L2lwhRIZzMBWK lz6Elg+EDeeWUMAsLniZwyYXM0VtuM+gh9rfP9QaPoChpSdwCpbIwZo0i35Jbk4x /6x2OJfJOBitdi3MBGnkeb8NWok9XsNYZTyPvLQRx60tvSpOWCOdoIzXgFmUsUwk j/qo/xyBYNeJv8Fb2sIH9ASbi6nhrvwqS6e2/9VW9mrApx7Ed7AVBrlzxI2Wu8he gmCW8tPqmwKge1RXwx7o3ovHbmo4moIMM6nnvljOnYafCHLVI4sVT2SM8ANUZ2e3 QG5h1D/3 =oNyV -----END PGP SIGNATURE----- --uLx7neljFSTKPRzN--