From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A8F24C433EF
	for <linux-kernel@archiver.kernel.org>; Fri, 19 Nov 2021 14:28:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 8D9DD61B1B
	for <linux-kernel@archiver.kernel.org>; Fri, 19 Nov 2021 14:28:26 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235885AbhKSObZ (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 19 Nov 2021 09:31:25 -0500
Received: from mail.kernel.org ([198.145.29.99]:33214 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S234650AbhKSObY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 19 Nov 2021 09:31:24 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 3785E61A38;
        Fri, 19 Nov 2021 14:28:20 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1637332101;
        bh=OFaXsXbqNsodMyHbMXGvTAb/UJPFuJVmSWmOLu5Rhig=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=tJxFmnYjI2yLO5Xy8kxdYrtSSgXYSlFcWIWSeOyBnoiGjCfn6n8IfWOMwqE1VXPaI
         Ye3fPj9Dfd/1M9C0yyquNTzVjt9eE5m+LyjKyf9VL/iIexQpM0TYtc1Hk0I2gPPTJz
         z8lSQsUJ1OB9TQAQbK6Z7yX+rgxpNtcTWdtAgYq0Fz/elSla+p7O7nfYTuE4WCdZ76
         Dz1PHrnk30JmiBUSIpXDVA0V7ciGx2/aWSsIIZzdFrM/iRbb40YtFY+A4tHr35oG99
         Gcc5pXsOACts5raJHpgMyGeEf+PP7MUZa4sUOWNajmQXbdmgSKGgyauUQvxgXQAmI7
         LQnehED2nWuiw==
Date:   Fri, 19 Nov 2021 06:28:19 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jiang Wang <jiang.wang@bytedance.com>, <cong.wang@bytedance.com>
Cc:     Vincent Whitchurch <vincent.whitchurch@axis.com>,
        <bpf@vger.kernel.org>, Casey Schaufler <casey@schaufler-ca.com>,
        "David S. Miller" <davem@davemloft.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Eric Dumazet <edumazet@google.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Rao Shoaib <Rao.Shoaib@oracle.com>,
        Kuniyuki Iwashima <kuniyu@amazon.co.jp>,
        Jakub Sitnicki <jakub@cloudflare.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf v1] unix: fix an issue in unix_shutdown causing the
 other end read/write failures
Message-ID: <20211119062819.54ff4cdd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20211119061419.270007d9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
References: <20211004232530.2377085-1-jiang.wang@bytedance.com>
        <20211111140000.GA10779@axis.com>
        <20211119061419.270007d9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 19 Nov 2021 06:14:19 -0800 Jakub Kicinski wrote:
> On Thu, 11 Nov 2021 15:00:02 +0100 Vincent Whitchurch wrote:
> > On Mon, Oct 04, 2021 at 11:25:28PM +0000, Jiang Wang wrote:  
> > > Commit 94531cfcbe79 ("af_unix: Add unix_stream_proto for sockmap")
> > > sets unix domain socket peer state to TCP_CLOSE
> > > in unix_shutdown. This could happen when the local end is shutdown
> > > but the other end is not. Then the other end will get read or write
> > > failures which is not expected.
> > > 
> > > Fix the issue by setting the local state to shutdown.
> > > 
> > > Fixes: 94531cfcbe79 (af_unix: Add unix_stream_proto for sockmap)
> > > Suggested-by: Cong Wang <cong.wang@bytedance.com>
> > > Reported-by: Casey Schaufler <casey@schaufler-ca.com>
> > > Signed-off-by: Jiang Wang <jiang.wang@bytedance.com>    
> > 
> > This patch changed the behaviour of read(2) after a shutdown(2) on the
> > local end of a UDS.  Before this patch, reading from a UDS after a local
> > shutdown(SHUT_RDWR) would return the data written or EOF if there is no
> > data, but now it always returns -EINVAL.
> > 
> > For example, the following test program succeeds with "read 16 bytes" on
> > v5.14 but fails with "read: Invalid argument" on v5.15 and mainline:  
> 
> Cong, Jiang, was this regression addressed?

Ah, just saw the patch. What timing.

Thanks Vincent!