From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8548768 for ; Fri, 19 Nov 2021 06:56:49 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id F18E168AFE; Fri, 19 Nov 2021 07:56:45 +0100 (CET) Date: Fri, 19 Nov 2021 07:56:45 +0100 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , Mike Snitzer , Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Subject: Re: [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem Message-ID: <20211119065645.GB15524@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-2-hch@lst.de> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Nov 17, 2021 at 09:44:25AM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > > > dax_attribute_group is only used by the pmem driver, and can avoid the > > completely pointless lookup by the disk name if moved there. This > > leaves just a single caller of dax_get_by_host, so move dax_get_by_host > > into the same ifdef block as that caller. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Dan Williams > > Link: https://lore.kernel.org/r/20210922173431.2454024-3-hch@lst.de > > Signed-off-by: Dan Williams > > This one already made v5.16-rc1. Yes, but 5.16-rc1 did not exist yet when I pointed the series. Note that the series also has a conflict against 5.16-rc1 in pmem.c, and buildbot pointed out the file systems need explicit dax.h includes in a few files for some configurations. The current branch is here, I just did not bother to repost without any comments: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dax-block-cleanup no functional changes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 106CFC433F5 for ; Fri, 19 Nov 2021 06:56:55 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEA2261AA7 for ; Fri, 19 Nov 2021 06:56:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AEA2261AA7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5EFD081CE1; Fri, 19 Nov 2021 06:56:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B1YJbC5xU1vS; Fri, 19 Nov 2021 06:56:53 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 043C481CD0; Fri, 19 Nov 2021 06:56:53 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D82E4C002E; Fri, 19 Nov 2021 06:56:52 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id A2AB3C0012 for ; Fri, 19 Nov 2021 06:56:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7F9BF4096F for ; Fri, 19 Nov 2021 06:56:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9fY_gfEW6J2I for ; Fri, 19 Nov 2021 06:56:50 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp4.osuosl.org (Postfix) with ESMTPS id B276E4095F for ; Fri, 19 Nov 2021 06:56:50 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id F18E168AFE; Fri, 19 Nov 2021 07:56:45 +0100 (CET) Date: Fri, 19 Nov 2021 07:56:45 +0100 From: Christoph Hellwig To: Dan Williams Subject: Re: [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem Message-ID: <20211119065645.GB15524@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-2-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, Nov 17, 2021 at 09:44:25AM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > > > dax_attribute_group is only used by the pmem driver, and can avoid the > > completely pointless lookup by the disk name if moved there. This > > leaves just a single caller of dax_get_by_host, so move dax_get_by_host > > into the same ifdef block as that caller. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Dan Williams > > Link: https://lore.kernel.org/r/20210922173431.2454024-3-hch@lst.de > > Signed-off-by: Dan Williams > > This one already made v5.16-rc1. Yes, but 5.16-rc1 did not exist yet when I pointed the series. Note that the series also has a conflict against 5.16-rc1 in pmem.c, and buildbot pointed out the file systems need explicit dax.h includes in a few files for some configurations. The current branch is here, I just did not bother to repost without any comments: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dax-block-cleanup no functional changes. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B4CDC433EF for ; Fri, 19 Nov 2021 06:56:56 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A3B961ACE for ; Fri, 19 Nov 2021 06:56:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6A3B961ACE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HwSBt15qZz3056 for ; Fri, 19 Nov 2021 17:56:54 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HwSBp5t3Bz2xYG for ; Fri, 19 Nov 2021 17:56:50 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id F18E168AFE; Fri, 19 Nov 2021 07:56:45 +0100 (CET) Date: Fri, 19 Nov 2021 07:56:45 +0100 From: Christoph Hellwig To: Dan Williams Subject: Re: [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem Message-ID: <20211119065645.GB15524@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Wed, Nov 17, 2021 at 09:44:25AM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > > > dax_attribute_group is only used by the pmem driver, and can avoid the > > completely pointless lookup by the disk name if moved there. This > > leaves just a single caller of dax_get_by_host, so move dax_get_by_host > > into the same ifdef block as that caller. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Dan Williams > > Link: https://lore.kernel.org/r/20210922173431.2454024-3-hch@lst.de > > Signed-off-by: Dan Williams > > This one already made v5.16-rc1. Yes, but 5.16-rc1 did not exist yet when I pointed the series. Note that the series also has a conflict against 5.16-rc1 in pmem.c, and buildbot pointed out the file systems need explicit dax.h includes in a few files for some configurations. The current branch is here, I just did not bother to repost without any comments: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dax-block-cleanup no functional changes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 202C7C433F5 for ; Fri, 19 Nov 2021 06:57:05 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3990611C3 for ; Fri, 19 Nov 2021 06:57:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B3990611C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-70-eMExcTAwPYax3OBFPIoncA-1; Fri, 19 Nov 2021 01:56:59 -0500 X-MC-Unique: eMExcTAwPYax3OBFPIoncA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EEC37100C609; Fri, 19 Nov 2021 06:56:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2207D10016F5; Fri, 19 Nov 2021 06:56:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1C35A4E9F5; Fri, 19 Nov 2021 06:56:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AJ6upBB009060 for ; Fri, 19 Nov 2021 01:56:51 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9A71140CFD12; Fri, 19 Nov 2021 06:56:51 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95A2640CFD02 for ; Fri, 19 Nov 2021 06:56:51 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 812B3185A7BA for ; Fri, 19 Nov 2021 06:56:51 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-256-xiIMh9LBPY-d3TqzZztlZA-1; Fri, 19 Nov 2021 01:56:49 -0500 X-MC-Unique: xiIMh9LBPY-d3TqzZztlZA-1 Received: by verein.lst.de (Postfix, from userid 2407) id F18E168AFE; Fri, 19 Nov 2021 07:56:45 +0100 (CET) Date: Fri, 19 Nov 2021 07:56:45 +0100 From: Christoph Hellwig To: Dan Williams Message-ID: <20211119065645.GB15524@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-2-hch@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: dm-devel@redhat.com Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig Subject: Re: [dm-devel] [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Nov 17, 2021 at 09:44:25AM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > > > dax_attribute_group is only used by the pmem driver, and can avoid the > > completely pointless lookup by the disk name if moved there. This > > leaves just a single caller of dax_get_by_host, so move dax_get_by_host > > into the same ifdef block as that caller. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Dan Williams > > Link: https://lore.kernel.org/r/20210922173431.2454024-3-hch@lst.de > > Signed-off-by: Dan Williams > > This one already made v5.16-rc1. Yes, but 5.16-rc1 did not exist yet when I pointed the series. Note that the series also has a conflict against 5.16-rc1 in pmem.c, and buildbot pointed out the file systems need explicit dax.h includes in a few files for some configurations. The current branch is here, I just did not bother to repost without any comments: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dax-block-cleanup no functional changes. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel