Hi Eric, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/gro-get-out-of-core-files/20211116-010906 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1274a4eb318debe33e395bb8bcf8b98e6eb4670f config: csky-defconfig (attached as .config) compiler: csky-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4a142ba0812a293afcb259b08c89ab80cb3dac6d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Eric-Dumazet/gro-get-out-of-core-files/20211116-010906 git checkout 4a142ba0812a293afcb259b08c89ab80cb3dac6d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=csky If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from net/ipv4/af_inet.c:102: include/net/gro.h: In function 'ip6_gro_compute_pseudo': include/net/gro.h:413:29: error: implicit declaration of function 'csum_ipv6_magic'; did you mean 'csum_tcpudp_magic'? [-Werror=implicit-function-declaration] 413 | return ~csum_unfold(csum_ipv6_magic(&iph->saddr, &iph->daddr, | ^~~~~~~~~~~~~~~ | csum_tcpudp_magic In file included from include/net/udplite.h:8, from net/ipv4/af_inet.c:105: include/net/ip6_checksum.h: At top level: >> include/net/ip6_checksum.h:34:9: error: conflicting types for 'csum_ipv6_magic'; have '__sum16(const struct in6_addr *, const struct in6_addr *, __u32, __u8, __wsum)' {aka 'short unsigned int(const struct in6_addr *, const struct in6_addr *, unsigned int, unsigned char, unsigned int)'} 34 | __sum16 csum_ipv6_magic(const struct in6_addr *saddr, | ^~~~~~~~~~~~~~~ In file included from net/ipv4/af_inet.c:102: include/net/gro.h:413:29: note: previous implicit declaration of 'csum_ipv6_magic' with type 'int()' 413 | return ~csum_unfold(csum_ipv6_magic(&iph->saddr, &iph->daddr, | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +34 include/net/ip6_checksum.h ^1da177e4c3f41 Linus Torvalds 2005-04-16 32 ^1da177e4c3f41 Linus Torvalds 2005-04-16 33 #ifndef _HAVE_ARCH_IPV6_CSUM acb3e04119fbf9 Cong Wang 2013-01-07 @34 __sum16 csum_ipv6_magic(const struct in6_addr *saddr, 56649d5d3c4cb0 Al Viro 2006-11-14 35 const struct in6_addr *daddr, 1e94082963747b Alexander Duyck 2016-03-11 36 __u32 len, __u8 proto, __wsum csum); ^1da177e4c3f41 Linus Torvalds 2005-04-16 37 #endif 8663e02aba154e Vlad Yasevich 2012-11-15 38 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org