From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A06CC433F5 for ; Sat, 20 Nov 2021 04:07:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231579AbhKTEKM (ORCPT ); Fri, 19 Nov 2021 23:10:12 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:56892 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230436AbhKTEKI (ORCPT ); Fri, 19 Nov 2021 23:10:08 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1moHeF-0001Cs-8q; Sat, 20 Nov 2021 12:06:43 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1moHdx-0006ga-HG; Sat, 20 Nov 2021 12:06:25 +0800 Date: Sat, 20 Nov 2021 12:06:25 +0800 From: Herbert Xu To: Julia Lawall Cc: Megha Dey , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Tomasz Kantecki , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-crypto@vger.kernel.org Subject: Re: [PATCH] crypto: fix flexible_array.cocci warnings Message-ID: <20211120040625.GA25678@gondor.apana.org.au> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote: > From: kernel test robot > > Zero-length and one-element arrays are deprecated, see > Documentation/process/deprecated.rst > Flexible-array members should be used instead. > > Generated by: scripts/coccinelle/misc/flexible_array.cocci > > Reported-by: kernel test robot > Signed-off-by: kernel test robot > Signed-off-by: Julia Lawall > --- > > tree: https://github.com/meghadey/crypto crypto-avx512 > head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71 > commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ > :::::: branch date: 7 weeks ago > :::::: commit date: 7 weeks ago > > aesni-intel_glue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/x86/crypto/aesni-intel_glue.c > +++ b/arch/x86/crypto/aesni-intel_glue.c > @@ -87,7 +87,7 @@ struct gcm_context_data { > u64 partial_block_len; > u64 unused; > /* Allocate space for hash_keys later */ > - u8 hash_keys[0]; > + u8 hash_keys[]; Which tree did this come from? Not only is this not zero in my tree, but it seems to have never been zero in the git history. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7893546345982751155==" MIME-Version: 1.0 From: Herbert Xu To: kbuild-all@lists.01.org Subject: Re: [PATCH] crypto: fix flexible_array.cocci warnings Date: Sat, 20 Nov 2021 12:06:25 +0800 Message-ID: <20211120040625.GA25678@gondor.apana.org.au> In-Reply-To: List-Id: --===============7893546345982751155== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote: > From: kernel test robot > = > Zero-length and one-element arrays are deprecated, see > Documentation/process/deprecated.rst > Flexible-array members should be used instead. > = > Generated by: scripts/coccinelle/misc/flexible_array.cocci > = > Reported-by: kernel test robot > Signed-off-by: kernel test robot > Signed-off-by: Julia Lawall > --- > = > tree: https://github.com/meghadey/crypto crypto-avx512 > head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71 > commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AV= X512 version of AESNI-GCM using VPCLMULQDQ > :::::: branch date: 7 weeks ago > :::::: commit date: 7 weeks ago > = > aesni-intel_glue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > --- a/arch/x86/crypto/aesni-intel_glue.c > +++ b/arch/x86/crypto/aesni-intel_glue.c > @@ -87,7 +87,7 @@ struct gcm_context_data { > u64 partial_block_len; > u64 unused; > /* Allocate space for hash_keys later */ > - u8 hash_keys[0]; > + u8 hash_keys[]; Which tree did this come from? Not only is this not zero in my tree, but it seems to have never been zero in the git history. Thanks, -- = Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --===============7893546345982751155==--