Hi Colin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Colin-Foster/prepare-ocelot-for-external-interface-control/20211120-064530
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 520fbdf7fb19b7744e370d36d9244a446299ceb7
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a5f13354942bd393fe1014a9c1b3d34dd8ec5f52
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Colin-Foster/prepare-ocelot-for-external-interface-control/20211120-064530
        git checkout a5f13354942bd393fe1014a9c1b3d34dd8ec5f52
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/net/ethernet/mscc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:28:17: error: 'vsc7514_ana_regmap' undeclared here (not in a function); did you mean 'ocelot_ana_regmap'?
      28 |         [ANA] = vsc7514_ana_regmap,
         |                 ^~~~~~~~~~~~~~~~~~
         |                 ocelot_ana_regmap
>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:29:16: error: 'vsc7514_qs_regmap' undeclared here (not in a function)
      29 |         [QS] = vsc7514_qs_regmap,
         |                ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:30:18: error: 'vsc7514_qsys_regmap' undeclared here (not in a function); did you mean 'ocelot_qsys_regmap'?
      30 |         [QSYS] = vsc7514_qsys_regmap,
         |                  ^~~~~~~~~~~~~~~~~~~
         |                  ocelot_qsys_regmap
>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:31:17: error: 'vsc7514_rew_regmap' undeclared here (not in a function); did you mean 'ocelot_rew_regmap'?
      31 |         [REW] = vsc7514_rew_regmap,
         |                 ^~~~~~~~~~~~~~~~~~
         |                 ocelot_rew_regmap
>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:32:17: error: 'vsc7514_sys_regmap' undeclared here (not in a function); did you mean 'ocelot_sys_regmap'?
      32 |         [SYS] = vsc7514_sys_regmap,
         |                 ^~~~~~~~~~~~~~~~~~
         |                 ocelot_sys_regmap
>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:33:16: error: 'vsc7514_vcap_regmap' undeclared here (not in a function); did you mean 'ocelot_vcap_regmap'?
      33 |         [S0] = vsc7514_vcap_regmap,
         |                ^~~~~~~~~~~~~~~~~~~
         |                ocelot_vcap_regmap
>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:36:17: error: 'vsc7514_ptp_regmap' undeclared here (not in a function); did you mean 'ocelot_ptp_regmap'?
      36 |         [PTP] = vsc7514_ptp_regmap,
         |                 ^~~~~~~~~~~~~~~~~~
         |                 ocelot_ptp_regmap
>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:37:22: error: 'vsc7514_dev_gmii_regmap' undeclared here (not in a function); did you mean 'ocelot_dev_gmii_regmap'?
      37 |         [DEV_GMII] = vsc7514_dev_gmii_regmap,
         |                      ^~~~~~~~~~~~~~~~~~~~~~~
         |                      ocelot_dev_gmii_regmap


vim +28 drivers/net/ethernet/mscc/ocelot_vsc7514.c

    26	
    27	static const u32 *ocelot_regmap[TARGET_MAX] = {
  > 28		[ANA] = vsc7514_ana_regmap,
  > 29		[QS] = vsc7514_qs_regmap,
  > 30		[QSYS] = vsc7514_qsys_regmap,
  > 31		[REW] = vsc7514_rew_regmap,
  > 32		[SYS] = vsc7514_sys_regmap,
  > 33		[S0] = vsc7514_vcap_regmap,
    34		[S1] = vsc7514_vcap_regmap,
    35		[S2] = vsc7514_vcap_regmap,
  > 36		[PTP] = vsc7514_ptp_regmap,
  > 37		[DEV_GMII] = vsc7514_dev_gmii_regmap,
    38	};
    39	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org