From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9106C433EF for ; Sat, 20 Nov 2021 15:13:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BE1C482A68; Sat, 20 Nov 2021 16:13:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HQ7Qu605"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0637082A65; Sat, 20 Nov 2021 16:13:25 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 65A0882A68 for ; Sat, 20 Nov 2021 16:13:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id 8so12330750qtx.5 for ; Sat, 20 Nov 2021 07:13:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=20ng0Icfnyrq3/5uH0hRqmxy2DBeNk0OOeTK2zsjGbM=; b=HQ7Qu605ZblqxxjQEMHrhT89SYaDA9pbpBxG1IL1KLybqCElu/cmPE6BXXaD2FLSeN NV6eitqsHDilWVi4hhjwQ7u5HXwL1EVWB8M2WlodLtw3QwBHA5HERYFSWD6YtZuftPDE bqMdq1uvP73v7OXx9OcZs6qkiY5/IgsZT1PWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=20ng0Icfnyrq3/5uH0hRqmxy2DBeNk0OOeTK2zsjGbM=; b=Uku3d4e3l/BzB8hlBYplSIJQq74qdIPV4xZYW02mLrnxqeId1W/YiVyxL6Qay0x0m+ XysLUNmrXPOVIPBaNpZLmcGZ7troahLhLWmRkP7AjUxNeJdBFenIUyRElenFjlQvNO63 3Tlleqfahn2jkSShCCcrfzTbvkAWyfxpFdn1mNaRVsJQdSk+KZT3RmWbjMIsy3WJWD0M 702r/A0eE4uZ3CiGeiXHX7he6MB5EG2Q/tcPEVXcCMhrJG2iNoWHpOap8Rq4MD5dLWrg ZzLOyFqsxujMEHYY/BqhNmXMzypbkjQKzMvMscjph1R/yTcZ2BwPtIQ58QENuDClkNcw 1/bg== X-Gm-Message-State: AOAM530J+9EcKrHusZ+INl3lCkSpUbdtJJinzI0bvBM+aKeExsHzMjsn Y29Na5KZ43VqQuBSY+HWceuBOw== X-Google-Smtp-Source: ABdhPJw588gAgXqtbYNfgzU3dpyOhz7InGAkl78mHiKOVkqZV1ku1HYzJH2/3bwx/3lLuKsrJlac7g== X-Received: by 2002:a05:622a:44a:: with SMTP id o10mr15616941qtx.212.1637421199103; Sat, 20 Nov 2021 07:13:19 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-d980-7ed6-84cb-4d93.res6.spectrum.com. [2603:6081:7b01:cbda:d980:7ed6:84cb:4d93]) by smtp.gmail.com with ESMTPSA id v15sm1659421qkl.91.2021.11.20.07.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Nov 2021 07:13:18 -0800 (PST) Date: Sat, 20 Nov 2021 10:13:16 -0500 From: Tom Rini To: Sean Anderson Cc: "Peng Fan (OSS)" , Peng Fan , "lukma@denx.de" , "sjg@chromium.org" , "u-boot@lists.denx.de" Subject: Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults Message-ID: <20211120151316.GP24579@bill-the-cat> References: <20211029012801.15193-1-peng.fan@oss.nxp.com> <20211120125711.GO24579@bill-the-cat> <3d3603ac-d949-ab9b-3045-6f8a6aa25127@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lPa4LZgl2SyrhJbo" Content-Disposition: inline In-Reply-To: <3d3603ac-d949-ab9b-3045-6f8a6aa25127@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --lPa4LZgl2SyrhJbo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 20, 2021 at 10:06:55AM -0500, Sean Anderson wrote: > On 11/20/21 7:57 AM, Tom Rini wrote: > > On Sat, Nov 20, 2021 at 12:10:54PM +0000, Peng Fan (OSS) wrote: > > > > Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > > > >=20 > > > > From: Peng Fan > > > >=20 > > > > Current code has a force clk_set_defaults in multiple stages, U-Boo= t reuse the > > > > same device tree and Linux Kernel device tree, but we not register = all the clks > > > > as Linux Kernel, so clk_set_defaults will fail and cause the clk pr= ovider > > > > registeration fail. > > > >=20 > > > > So introduce a new property to ignore the default settings which co= uld be > > > > used by any node that wanna ignore default settings. > > > >=20 > > > > Reviewed-by: Simon Glass > > > > Signed-off-by: Peng Fan > > > > --- > > > >=20 > > > > V2: > > > > Add R-b tag > > > > Tom, Simon > > > > After a thought, I think still put it as a u-boot thing. assign= ed-clock-x is > > > > actually Linux specific, however I could not add the new proper= ty to Linux, > > > > because we are supporting SystemReady-IR, we need the > > > > assigned-clock-x property > > > > in linux working and ignore it in U-Boot. > > >=20 > > > Any more thoughts? > >=20 > > Just my continued request that you treat this as generic and submit the > > binding upstream so it can be in the device tree for the platform. > >=20 >=20 > Hmm. >=20 > Could we just do >=20 > /delete-property/ assigned-clocks; >=20 > in our u-boot dtsi? As a fall back? I'm still unclear as to why the right answer isn't something along the lines of "work with upstream to get appropriate bindings accepted". I think I might have even misread the comment about SystemReady IR before even. The assigned-lock-x property isn't in the upstream binding? So now we're trying to do what exactly here? And to be clear, the situation with the layerscape dts files that's just now getting sorted out has me extra skeptical of "just modify the dts in U-Boot to ..." changes. The goal within U-Boot is that our bindings are accepted upstream (as upstream accepts non-Linux bindings) and I prefer to start asking "is this a binding that's applicable to other firmwares too?". --=20 Tom --lPa4LZgl2SyrhJbo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGZEIgACgkQFHw5/5Y0 tyz8VQv/SBstIRUKW7JEbprV0Xiz3lV3FggLLYlTyouZretHjOzBOmc4dHPlLYaI KD64VleNHduLWpxBua318CnHyS9W1g1jS8vdmTilQoohz5zCG/CxwX8PWb9AJoKQ tqriO6WFQ5XrDHQtj6/Vsh89Ccxci6o7kwA+q+1Vuf5bGs3mj5KfPuuvSRNjtMBp eL9kUbmpnGEBtMC0NV5UZs8f/vvgLw6vRs2oCVt3Z5m61Y404UVLlU+TFyegBLle 1hFkiB0EnmghTojQVxCiNRf8/+1JZb+8ZZoE/KdKDx8u4NdS5dFwp3ahKAFu8xwf 71C5eeTXV6q7zLtkeeZmzLmrWRL6W57ICEnmWLzZR3UOHlun5UPnr6Zr0zoK0vC8 TyYbAz4lX0VSXPE2e/cqjHTI+pLBmO5B6ktPQW5qo8dX9RkIp6hGYp616/oGKCRS fV+SaqaC6pH8GdEVyMuA531X64m1JDt1DW+BC6aExGU1Dzqph3XhVdotzj02jX1i Kgvo6lOJ =5xHw -----END PGP SIGNATURE----- --lPa4LZgl2SyrhJbo--