From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7D18C433F5 for ; Mon, 22 Nov 2021 10:08:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A06189EBD; Mon, 22 Nov 2021 10:08:03 +0000 (UTC) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id B16B589EBD for ; Mon, 22 Nov 2021 10:08:02 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id CE1F33201C3F; Mon, 22 Nov 2021 05:08:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Nov 2021 05:08:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=dSpFuLXHzLd9s6qVEKMoKCZA44t Tq39Im0wyAEqj2w8=; b=Ql5ZOKln5yQ7kYrY4713oE9ZCTNG4H5Rbv3IUMlP0iT jVtdkwQhWbFbTuxeFCvKsMrIZ0ch98T0Mqx0WJ8/+Dy1LBif9XujIcH6dWkYkfix MJPEMGF5gblcgWvT0229DUpXwzDR5kBOfsCuieJdfKXlZV9Of2gwWWbFYKixAHRe pvlpAOxg3F3hWywWX/z5QyTeEwdPbmFd32OUnRmrHB+py6B/jHD/LpFtzqUmSbTM sTUvZeP4djcCKuNcRz3kQQ5YvvebK2dIknvjDLykI7zZU0vMlfBDVWYpcz4cdUSN rQhwDWaq0j2dVSzP1bhxhEJqpIE5AHs4h9sHcVDLZBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=dSpFuL XHzLd9s6qVEKMoKCZA44tTq39Im0wyAEqj2w8=; b=EpyGUDmhbVfxIuVUVJLJAd GmJz61UvbMAo38ouWP5yzchvz12he5QzqDGKcWvccBhogISm6bOC/89ZHTfY8qzA qUWN+bDZrXJIFdh506/2wmHC2+O2srZmedYdOBh5S6UHxaRrMxDJ8wSupt7tGyaD PCwy3sc4SPuTrxlZ0+j0b0UzC6M/uAfxPtbl2rI2Lq3LoziRkQP5su0PSh+A8NsS EZRbfk9UoLJi0nyM2kvYG2JobPprmIuD01mSGYV8svnlZc8aXKQf80kUHkTJ9GxF ILFLZxLP8hPnoXcMyAS+x0qDtsIkjddbhOqXrcn0w9Tlt97Ixu8gquPgKqPnngrw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeeggdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Nov 2021 05:08:00 -0500 (EST) Date: Mon, 22 Nov 2021 11:07:59 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function Message-ID: <20211122100759.qw6lvwb33ciemg2y@gilmour> References: <20211122065223.88059-1-jagan@amarulasolutions.com> <20211122065223.88059-5-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5dwnarnf2cksejho" Content-Disposition: inline In-Reply-To: <20211122065223.88059-5-jagan@amarulasolutions.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Laurent Pinchart , Sam Ravnborg , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --5dwnarnf2cksejho Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 22, 2021 at 12:22:20PM +0530, Jagan Teki wrote: > Get the display mode settings via mode_set bridge function > instead of explicitly de-reference. What's wrong with dereferencing the mode? Maxime --5dwnarnf2cksejho Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYZtr/wAKCRDj7w1vZxhR xZQ+AQC5cdLRirXcVFC1Kt9yN6IhNBxQnJ3IYozu+FBSD+grIAEA802WV9RfuiEV z5QPUlM7peWb7KXhniG+amGEIX6boQw= =OsoH -----END PGP SIGNATURE----- --5dwnarnf2cksejho-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB293C433F5 for ; Mon, 22 Nov 2021 11:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lCtMLX6qbU7fg/y+6V3Ul3wewFjWE2nKkezZ7BpawJA=; b=gzPK3mB2BPZi1w6HLIUTUBpWnu 4KWhIWalJEAqlXLP6Ij0hfFEV0Lg1aHmnMydXsq0WgA+w5pyH0nivhCeuOG4Mkxr1P4SNZMpzDFHb IiS7sHQX6+BEFWuY/6n4kKLTikYlPaNP0wnBCyaLJTsjnqO+C3QUwwZ69vaRpAd99G47LISIjHzrB TFdykTxRZXALzlNyyef/aHnk3TvtMsIbmAdCZ8kTr/Q78Cb9R2E/81mAQ6Jl3MWNN5WNT4gQfTAeq 18QeqCOtN3BStf+BvTRzGX4PG2qlRCozcf/3+AlTssgF1glumGWPy85iysAGAglNU0km7qGysnWdR 9H1GVioQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mp7N3-00G1aN-Ue; Mon, 22 Nov 2021 11:20:27 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mp6F0-00FllN-Tw for linux-arm-kernel@lists.infradead.org; Mon, 22 Nov 2021 10:08:04 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id CE1F33201C3F; Mon, 22 Nov 2021 05:08:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Nov 2021 05:08:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=dSpFuLXHzLd9s6qVEKMoKCZA44t Tq39Im0wyAEqj2w8=; b=Ql5ZOKln5yQ7kYrY4713oE9ZCTNG4H5Rbv3IUMlP0iT jVtdkwQhWbFbTuxeFCvKsMrIZ0ch98T0Mqx0WJ8/+Dy1LBif9XujIcH6dWkYkfix MJPEMGF5gblcgWvT0229DUpXwzDR5kBOfsCuieJdfKXlZV9Of2gwWWbFYKixAHRe pvlpAOxg3F3hWywWX/z5QyTeEwdPbmFd32OUnRmrHB+py6B/jHD/LpFtzqUmSbTM sTUvZeP4djcCKuNcRz3kQQ5YvvebK2dIknvjDLykI7zZU0vMlfBDVWYpcz4cdUSN rQhwDWaq0j2dVSzP1bhxhEJqpIE5AHs4h9sHcVDLZBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=dSpFuL XHzLd9s6qVEKMoKCZA44tTq39Im0wyAEqj2w8=; b=EpyGUDmhbVfxIuVUVJLJAd GmJz61UvbMAo38ouWP5yzchvz12he5QzqDGKcWvccBhogISm6bOC/89ZHTfY8qzA qUWN+bDZrXJIFdh506/2wmHC2+O2srZmedYdOBh5S6UHxaRrMxDJ8wSupt7tGyaD PCwy3sc4SPuTrxlZ0+j0b0UzC6M/uAfxPtbl2rI2Lq3LoziRkQP5su0PSh+A8NsS EZRbfk9UoLJi0nyM2kvYG2JobPprmIuD01mSGYV8svnlZc8aXKQf80kUHkTJ9GxF ILFLZxLP8hPnoXcMyAS+x0qDtsIkjddbhOqXrcn0w9Tlt97Ixu8gquPgKqPnngrw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeeggdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Nov 2021 05:08:00 -0500 (EST) Date: Mon, 22 Nov 2021 11:07:59 +0100 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Laurent Pinchart , Neil Armstrong , Robert Foss , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-amarula@amarulasolutions.com Subject: Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function Message-ID: <20211122100759.qw6lvwb33ciemg2y@gilmour> References: <20211122065223.88059-1-jagan@amarulasolutions.com> <20211122065223.88059-5-jagan@amarulasolutions.com> MIME-Version: 1.0 In-Reply-To: <20211122065223.88059-5-jagan@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211122_020803_033185_0C9251B9 X-CRM114-Status: UNSURE ( 8.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4135065114920615453==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4135065114920615453== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5dwnarnf2cksejho" Content-Disposition: inline --5dwnarnf2cksejho Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 22, 2021 at 12:22:20PM +0530, Jagan Teki wrote: > Get the display mode settings via mode_set bridge function > instead of explicitly de-reference. What's wrong with dereferencing the mode? Maxime --5dwnarnf2cksejho Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYZtr/wAKCRDj7w1vZxhR xZQ+AQC5cdLRirXcVFC1Kt9yN6IhNBxQnJ3IYozu+FBSD+grIAEA802WV9RfuiEV z5QPUlM7peWb7KXhniG+amGEIX6boQw= =OsoH -----END PGP SIGNATURE----- --5dwnarnf2cksejho-- --===============4135065114920615453== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4135065114920615453==--