From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4F11C433F5 for ; Mon, 22 Nov 2021 13:22:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F1410834CB; Mon, 22 Nov 2021 14:22:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="WWX5ltkG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 528E7834CB; Mon, 22 Nov 2021 14:22:13 +0100 (CET) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6BE01836B7 for ; Mon, 22 Nov 2021 14:22:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id d2so17962546qki.12 for ; Mon, 22 Nov 2021 05:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PsKEQr2U+BP0SK2WL831wuDROU5FsuZSDGG6lELpjbc=; b=WWX5ltkGAf3xw0pIWAitPTboEcVPFEJIwuTZV/S0BRAFjc/11S7FaXlPxXeHjbO/To ZO7g8nvzOq+swZC1jQhYGafuJ3D3riNjaKyWp4JN7/amjhP83zP03k0XDE1tNJn9KVcA MFJUrROQtMj0IT0r6/ue9T6wo3gVe/Lr38ekE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PsKEQr2U+BP0SK2WL831wuDROU5FsuZSDGG6lELpjbc=; b=gEPYcEaSmEgpEf92aWVvzFvQPJel0+Genw2EWtiHA79ibdAF/nSgNx/GmSBLZosYOs F/6bYKxfq74b1baHbE+Uv8KT0JfDCFASyj0n6YeijuKtEwqvmpW7NaUNexROp9eJCs+B /PrJjzdzF62uRZM+JDajvNXQW8XOYcWqWbxLp9upWs5q/ZwBpybz8HAamaQQWHOgT6Zu veNWDnAcX7PIwFSstSkMfbV248ZC0QqTYJinD81WKKn0JhuNSNtRNDwfWEivUTPAHx44 8mQyXtp3t2ZT3AKAM0Z5iv5SC+gqtcLELU2UIapIe4D17wl+a1B91Q3XdC+kcGAJd51v bsfg== X-Gm-Message-State: AOAM530upXY8PqS3wMktQd3Q2wb6ixT90+mD0rI3iG7lkKxqLehENB54 NFqJokERthSukGyO22czttmm1Q== X-Google-Smtp-Source: ABdhPJxAE/Y7PSLJC1jNZEofS1VkLjALBR/WSqLoavBgXJ1b/tLpGhZdsczACRLWAgaYvKOBzaxgqg== X-Received: by 2002:a37:a5d3:: with SMTP id o202mr48867878qke.384.1637587328201; Mon, 22 Nov 2021 05:22:08 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-d1dd-c96e-a218-ce5d.res6.spectrum.com. [2603:6081:7b01:cbda:d1dd:c96e:a218:ce5d]) by smtp.gmail.com with ESMTPSA id d5sm4543412qte.27.2021.11.22.05.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Nov 2021 05:22:06 -0800 (PST) Date: Mon, 22 Nov 2021 08:22:04 -0500 From: Tom Rini To: "Peng Fan (OSS)" Cc: Rob Herring , Peng Fan , "lukma@denx.de" , "sjg@chromium.org" , "seanga2@gmail.com" , "u-boot@lists.denx.de" Subject: Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults Message-ID: <20211122132204.GV24579@bill-the-cat> References: <20211029012801.15193-1-peng.fan@oss.nxp.com> <20211120125711.GO24579@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2kPS9oLXDLT6LUTO" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --2kPS9oLXDLT6LUTO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 22, 2021 at 11:33:27AM +0800, Peng Fan (OSS) wrote: > + Rob >=20 > On 2021/11/20 20:57, Tom Rini wrote: > > On Sat, Nov 20, 2021 at 12:10:54PM +0000, Peng Fan (OSS) wrote: > > > > Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > > > >=20 > > > > From: Peng Fan > > > >=20 > > > > Current code has a force clk_set_defaults in multiple stages, U-Boo= t reuse the > > > > same device tree and Linux Kernel device tree, but we not register = all the clks > > > > as Linux Kernel, so clk_set_defaults will fail and cause the clk pr= ovider > > > > registeration fail. > > > >=20 > > > > So introduce a new property to ignore the default settings which co= uld be > > > > used by any node that wanna ignore default settings. > > > >=20 > > > > Reviewed-by: Simon Glass > > > > Signed-off-by: Peng Fan > > > > --- > > > >=20 > > > > V2: > > > > Add R-b tag > > > > Tom, Simon > > > > After a thought, I think still put it as a u-boot thing. assign= ed-clock-x is > > > > actually Linux specific, however I could not add the new proper= ty to Linux, > > > > because we are supporting SystemReady-IR, we need the > > > > assigned-clock-x property > > > > in linux working and ignore it in U-Boot. > > >=20 > > > Any more thoughts? > >=20 > > Just my continued request that you treat this as generic and submit the > > binding upstream so it can be in the device tree for the platform. > >=20 >=20 > As Sean said, this is to serve cast that linux and U-Boot use the same > device tree, I mean U-Boot runtime export device tree to linux for SR-IR > (system-ready IR) booting. >=20 > Linux needs assigned-clocks to some reason, but U-Boot not need that beca= use > the driver not added the support or not a must to have that. >=20 > Because assigned-clocks failure in U-Boot will cause probe fail now, > the device driver will report failure. >=20 > You mean rename this to "ignore-clk-defaults" or keep > "u-boot,ignore-clk-defauls" or "firmware,ignore-clk-defaults" to linux > device tree binding? >=20 > I could try to send to linux kernel with "firmware" as a prefix. What I mean is that first I'm not seeing the description of the property as being clear enough, either in commit message or the binding itself. That's why in my mind I keep seeing this as "we set the properties linux,assigned-clocks and u-boot,ignore-clk-defaults" and I don't know why = we need both. Is there not something we can do based on seeing linux,assigned-clocks ? Showing something that makes use of the property you're wishing to add would be helpful. In fact, some specific dts snippets would be helpful to understand what's going on here. Second, if we need a new property here then yes, it goes upstream and you put u-boot,has-not-clk-foo or firmware,has-not-clk-foo or whatever in the boards dts file. --=20 Tom --2kPS9oLXDLT6LUTO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGbmXkACgkQFHw5/5Y0 tyyBsQv+Nl6JQ3zzpogjeq0h4ViDU9tGuSzpLASg8SAhKrTEHup/D+p0acF23y/A DJ3JWOAzatSXdyW/CCHjrLLJIpzb1uR/fEXaPYm2cKxaEyeBXCwWCmwxRDTsStgK 7zFbzQUBIKQftheWsBwOa/sU2UJ08FtzTO5dqoI04xhVwH/2EnL7iVFE/vVdISeO gEZIHWKomthASse8t3AlE6dSgMgowqWeC9k20b73ruzrK8UfQGrdguxXbsZMcUVx s0dt2P/oGWSMUqdXG+brvPQhfbRqhcijpIJdnjmRz+JwPehB6df4Gi62mQlLSZSq FTGbfY3IzLiTPDq2stWHefOkwLSk0F+Y/VvAGcnoOpjGy+DbH6p71E002NrPUXxX 7pOcWytPlvWd2T90CRovD6w1pxI41myTpqzh1/cXhrHGqF4W2Tn62j6F9FGi++5n w3U6FnyZcMcpR2op/TdKEf2BJE4SRaZ+1suvGrf/vnh5AyD9wSFaIUAguN8patel vjdIT9CQ =Jr5a -----END PGP SIGNATURE----- --2kPS9oLXDLT6LUTO--