From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3515C433EF for ; Mon, 22 Nov 2021 14:09:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2C2F89C93; Mon, 22 Nov 2021 14:09:33 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id A5BEA89C93 for ; Mon, 22 Nov 2021 14:09:32 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EBC7F5C01F5; Mon, 22 Nov 2021 09:09:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Nov 2021 09:09:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=j xxN5b1YOQwiAkxp613+8q24NggXlkcYxWYUbf7zZYc=; b=m0N0uG0plcY3Ok1t0 x/PF+Htvex7tdBECQGtQmkKHDNmm7d9NS4zhXHCuOjoAWJr4pyi6kQ7yg2e+wdZy yf0Sk3QLyoAi/R8yrgcc+uAHniHl7ifyYgPBt0DvCHD17U9Zlf/vtFtbPXPcKqH0 wR/2y+JqIZHuet1gBRvh1ibzDMLio1DnkNoBj4X7JFq+7XEeLN2crWUCXzNQX7a5 +LVcCWTH6qYUIH4PaoU4CThE90xfE8Y6yJhA95pwMoeff/2nfAwK0NKhaCWNwRrt qOYDPCMfixZzBew9AYrlxHBYGwondZYlAC1WUiB+SKIHUjop36+FL3d5a7p6rlBP DmVUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=jxxN5b1YOQwiAkxp613+8q24NggXlkcYxWYUbf7zZ Yc=; b=Wmh0dioUwMh1rwWOh3IrEw/lIXhx/PEu8mbTniy4ezI38qsHF0/ChHPnm cRsl7n3w7cSmrhmo28HLGDNXoT7wc9r5GdPWSX98gJjN4gyoDo/MlQuUTCoLlO/s xnCtjaKLsxt2hM44qCoeu1I+0dT0u2yk3xrQcbwE5gXeWKsCt/p5NbZJSC6nguaC W/YM4tCBHj68ZA97WbS3BnqwILTi8At1d3Pr4bmAenVgpvKSf78Has/jAG6Zh4aU ZPXdTI67jhj6H9fI+ywpLJ51WrkNutP18AjYJiF/auXYINwU1Xvcc15yGKOxILsh 3ndjaHd61bhWBMzRy4Ewhv8Ng/btw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeeggdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeeludeg vddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Nov 2021 09:09:30 -0500 (EST) Date: Mon, 22 Nov 2021 15:09:29 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function Message-ID: <20211122140929.22cmvnxxapp752ic@gilmour> References: <20211122065223.88059-1-jagan@amarulasolutions.com> <20211122065223.88059-5-jagan@amarulasolutions.com> <20211122100759.qw6lvwb33ciemg2y@gilmour> <20211122132847.ds4gtk2unq3fkagy@gilmour> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Laurent Pinchart , Sam Ravnborg , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Nov 22, 2021 at 07:21:57PM +0530, Jagan Teki wrote: > > It's perfectly valid to dereference the pointer in atomic_enable, and > > that patch would consume memory for no particular reason. >=20 > Again, I'm not pointing any mistake in dereference and certainly not > understand about what memory consumption issue here. You add a struct drm_display_mode field to struct sun6i_dsi. It increases the size of struct sun6i_dsi of sizeof(struct drm_display_mode). > I'm doing it here since I'm doing it via mode_set in other drivers. No > problem for me either way. But *why* are you doing so? There might be a valid reason in other drivers, but there's none here (that you mentioned at least). Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ADF1C433F5 for ; Mon, 22 Nov 2021 14:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8oFdmyiyirB8I6R7dQvu8X8InyMLa5VJL5jpP7Bk+D4=; b=bWpsODGIR5DtQT 6upZIvamof/gahgNqf3RR62fKQRlHTLRQ7reHkb6l2a/4RnuQ09/UszT+YmBlDJKiRqb42GDEZf33 huahQgeOVaYkH0Tl0fj+2VXlxaNSmo36SDuk7PRf+XKmr6Niyh+3zUBn0xpwlcuUIdCV4Q3TuDPku O+/WfwDm+TS+bwF1oXYvdgN1woQsuN2qe6mBlEGM2y/dqB9y5U1jFe7/dNQ+RXYsfdNRSu1rXgzIZ TnVFVUR88zcWAbRdVwgG4k/auUOVN0HBYFMJpC9lobgJUtCYLRtlA+7qvtBfE23jIGoGWOFgBfMuP DFZ2ZoxGOXB7r5ZjHTcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpA0m-00GneD-E1; Mon, 22 Nov 2021 14:09:36 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpA0i-00Gnd7-LC for linux-arm-kernel@lists.infradead.org; Mon, 22 Nov 2021 14:09:34 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EBC7F5C01F5; Mon, 22 Nov 2021 09:09:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Nov 2021 09:09:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=j xxN5b1YOQwiAkxp613+8q24NggXlkcYxWYUbf7zZYc=; b=m0N0uG0plcY3Ok1t0 x/PF+Htvex7tdBECQGtQmkKHDNmm7d9NS4zhXHCuOjoAWJr4pyi6kQ7yg2e+wdZy yf0Sk3QLyoAi/R8yrgcc+uAHniHl7ifyYgPBt0DvCHD17U9Zlf/vtFtbPXPcKqH0 wR/2y+JqIZHuet1gBRvh1ibzDMLio1DnkNoBj4X7JFq+7XEeLN2crWUCXzNQX7a5 +LVcCWTH6qYUIH4PaoU4CThE90xfE8Y6yJhA95pwMoeff/2nfAwK0NKhaCWNwRrt qOYDPCMfixZzBew9AYrlxHBYGwondZYlAC1WUiB+SKIHUjop36+FL3d5a7p6rlBP DmVUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=jxxN5b1YOQwiAkxp613+8q24NggXlkcYxWYUbf7zZ Yc=; b=Wmh0dioUwMh1rwWOh3IrEw/lIXhx/PEu8mbTniy4ezI38qsHF0/ChHPnm cRsl7n3w7cSmrhmo28HLGDNXoT7wc9r5GdPWSX98gJjN4gyoDo/MlQuUTCoLlO/s xnCtjaKLsxt2hM44qCoeu1I+0dT0u2yk3xrQcbwE5gXeWKsCt/p5NbZJSC6nguaC W/YM4tCBHj68ZA97WbS3BnqwILTi8At1d3Pr4bmAenVgpvKSf78Has/jAG6Zh4aU ZPXdTI67jhj6H9fI+ywpLJ51WrkNutP18AjYJiF/auXYINwU1Xvcc15yGKOxILsh 3ndjaHd61bhWBMzRy4Ewhv8Ng/btw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeeggdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeeludeg vddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Nov 2021 09:09:30 -0500 (EST) Date: Mon, 22 Nov 2021 15:09:29 +0100 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Laurent Pinchart , Neil Armstrong , Robert Foss , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-amarula@amarulasolutions.com Subject: Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function Message-ID: <20211122140929.22cmvnxxapp752ic@gilmour> References: <20211122065223.88059-1-jagan@amarulasolutions.com> <20211122065223.88059-5-jagan@amarulasolutions.com> <20211122100759.qw6lvwb33ciemg2y@gilmour> <20211122132847.ds4gtk2unq3fkagy@gilmour> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211122_060932_806238_8CB7A95D X-CRM114-Status: GOOD ( 11.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 22, 2021 at 07:21:57PM +0530, Jagan Teki wrote: > > It's perfectly valid to dereference the pointer in atomic_enable, and > > that patch would consume memory for no particular reason. > > Again, I'm not pointing any mistake in dereference and certainly not > understand about what memory consumption issue here. You add a struct drm_display_mode field to struct sun6i_dsi. It increases the size of struct sun6i_dsi of sizeof(struct drm_display_mode). > I'm doing it here since I'm doing it via mode_set in other drivers. No > problem for me either way. But *why* are you doing so? There might be a valid reason in other drivers, but there's none here (that you mentioned at least). Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel