From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7DF7C433EF for ; Mon, 22 Nov 2021 15:06:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D75D089FAD; Mon, 22 Nov 2021 15:06:15 +0000 (UTC) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by gabe.freedesktop.org (Postfix) with ESMTPS id E560489FAD for ; Mon, 22 Nov 2021 15:06:13 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 505D55C016D; Mon, 22 Nov 2021 10:06:13 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 22 Nov 2021 10:06:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=K iR+UZv1p+Lkivlzd22q2DRYBosZiCpsvvTZHi2S6j8=; b=O1TM9DOZR99iF+wxN iS5q8NonDhxGgJQMurqK8CGbfMkgXeD9brIT2XZFXaHw2nSW3FPHrUUjQU8wvRaM E4Yu6sVXv+LNmz9dQ7LHrvIYBxD4t8+hK49RcssSW6hlkrB2zMz4oP+CUPpjXMvh CtXZk+GzhSsF6SIwzJ46ENOO1mpdnRt4xXweLSUm/CvxDWVYtbYMwQdTUBif+tuL 12/BRpi4XcvlmLSGwRosJ8/eNPebxX0Tct5D8fJTsaAdRX/aBJMQTkoGyjVyb4pv I9OHr0IUCr9wqrJLVV+oDyet3MxSqiz97lrWT2gRMe19BX07UhNxSidA0pMFfqnF cZbiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=KiR+UZv1p+Lkivlzd22q2DRYBosZiCpsvvTZHi2S6 j8=; b=MgpjcD4l177qGKD4D6Tq/NaJVgAOAeK+ztC98D+cdUOsvxXQknO7/g7/Z 0bl9XQFe32KuMDu6ZhRgXXGVqFP/2r/bVFPbgLWSrAjlqStAPZKPUgj7nOBwVkzq d1MwDyhm+xLswS6otX7PNqk9Vefb2xGFKE7/arPXVGrvy/5DfkfF3gGBqSzV/E/+ A3FuOKCAMEywhPTfYVuLx+URTO8Zwo/uFZQYyC7Ub+aW9rmQirepabCbpvqREoom ciQ+V0rmvO8ddxPxOPpVYt+bYzTo67ImcF+aMjqsVDObPKhmj0/J472MluoBO+Pn 13TpRkYcFi10z/X0rjqxbSyo3D6hw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeeggdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeeludeg vddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Nov 2021 10:06:12 -0500 (EST) Date: Mon, 22 Nov 2021 16:06:10 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function Message-ID: <20211122150610.mvltgil3yquli4qp@gilmour> References: <20211122065223.88059-1-jagan@amarulasolutions.com> <20211122065223.88059-5-jagan@amarulasolutions.com> <20211122100759.qw6lvwb33ciemg2y@gilmour> <20211122132847.ds4gtk2unq3fkagy@gilmour> <20211122140929.22cmvnxxapp752ic@gilmour> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Laurent Pinchart , Sam Ravnborg , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Nov 22, 2021 at 08:01:47PM +0530, Jagan Teki wrote: > On Mon, Nov 22, 2021 at 7:39 PM Maxime Ripard wrote: > > > > On Mon, Nov 22, 2021 at 07:21:57PM +0530, Jagan Teki wrote: > > > > It's perfectly valid to dereference the pointer in atomic_enable, a= nd > > > > that patch would consume memory for no particular reason. > > > > > > Again, I'm not pointing any mistake in dereference and certainly not > > > understand about what memory consumption issue here. > > > > You add a struct drm_display_mode field to struct sun6i_dsi. It > > increases the size of struct sun6i_dsi of sizeof(struct > > drm_display_mode). > > > > > I'm doing it here since I'm doing it via mode_set in other drivers. No > > > problem for me either way. > > > > But *why* are you doing so? > > > > There might be a valid reason in other drivers, but there's none here > > (that you mentioned at least). >=20 > The reason is to use existing bridge function instead of dereference > ie what I've mentioned. I don't have any other reasons. This discussion is going in circles. Unless you have a reason other than "because we can", NAK for the reasons already stated above. Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27C23C433F5 for ; Mon, 22 Nov 2021 15:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vZP5AEv456+6whv0VYOyHCzhgbBEX3DJHDNgaKPsW0Q=; b=NwgFULosXRudIJ j3b434+l3P32DgSGFN72nL5585/3t7mfL3ulzJ5WrkRpeOhtubZ5M5igqdUTV28mGMgdlio5rJyh4 7dlgjuvL8wXqjuOOqkujTD8UkNmEpDzdSn56XE04Zm7JYAJyk0RFSQ3X0ByfudouFo6SOt4bP8O7y eTQ/BkgDxUaMGzBZ+VMCG9dj4anoTs/J+XkYO522rM5K8/i/RYoFQcIvhQmK6CMyngCJ8T+GQIrpe 3vG49B94Vjv0HjDDv0ZQY0Ek+pTssjUMgw0miqL5P7wy4+yEjKnm1FBggOd7YJ+ySv/fBZeC6mepp qmvkLEXff9HrnyvoYwQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpAtj-00GyYQ-1I; Mon, 22 Nov 2021 15:06:23 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpAta-00GyUt-1V for linux-arm-kernel@lists.infradead.org; Mon, 22 Nov 2021 15:06:15 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 505D55C016D; Mon, 22 Nov 2021 10:06:13 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 22 Nov 2021 10:06:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=K iR+UZv1p+Lkivlzd22q2DRYBosZiCpsvvTZHi2S6j8=; b=O1TM9DOZR99iF+wxN iS5q8NonDhxGgJQMurqK8CGbfMkgXeD9brIT2XZFXaHw2nSW3FPHrUUjQU8wvRaM E4Yu6sVXv+LNmz9dQ7LHrvIYBxD4t8+hK49RcssSW6hlkrB2zMz4oP+CUPpjXMvh CtXZk+GzhSsF6SIwzJ46ENOO1mpdnRt4xXweLSUm/CvxDWVYtbYMwQdTUBif+tuL 12/BRpi4XcvlmLSGwRosJ8/eNPebxX0Tct5D8fJTsaAdRX/aBJMQTkoGyjVyb4pv I9OHr0IUCr9wqrJLVV+oDyet3MxSqiz97lrWT2gRMe19BX07UhNxSidA0pMFfqnF cZbiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=KiR+UZv1p+Lkivlzd22q2DRYBosZiCpsvvTZHi2S6 j8=; b=MgpjcD4l177qGKD4D6Tq/NaJVgAOAeK+ztC98D+cdUOsvxXQknO7/g7/Z 0bl9XQFe32KuMDu6ZhRgXXGVqFP/2r/bVFPbgLWSrAjlqStAPZKPUgj7nOBwVkzq d1MwDyhm+xLswS6otX7PNqk9Vefb2xGFKE7/arPXVGrvy/5DfkfF3gGBqSzV/E/+ A3FuOKCAMEywhPTfYVuLx+URTO8Zwo/uFZQYyC7Ub+aW9rmQirepabCbpvqREoom ciQ+V0rmvO8ddxPxOPpVYt+bYzTo67ImcF+aMjqsVDObPKhmj0/J472MluoBO+Pn 13TpRkYcFi10z/X0rjqxbSyo3D6hw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeeggdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeeludeg vddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Nov 2021 10:06:12 -0500 (EST) Date: Mon, 22 Nov 2021 16:06:10 +0100 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Laurent Pinchart , Neil Armstrong , Robert Foss , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-amarula@amarulasolutions.com Subject: Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function Message-ID: <20211122150610.mvltgil3yquli4qp@gilmour> References: <20211122065223.88059-1-jagan@amarulasolutions.com> <20211122065223.88059-5-jagan@amarulasolutions.com> <20211122100759.qw6lvwb33ciemg2y@gilmour> <20211122132847.ds4gtk2unq3fkagy@gilmour> <20211122140929.22cmvnxxapp752ic@gilmour> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211122_070614_199684_7DC5CFBA X-CRM114-Status: GOOD ( 19.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 22, 2021 at 08:01:47PM +0530, Jagan Teki wrote: > On Mon, Nov 22, 2021 at 7:39 PM Maxime Ripard wrote: > > > > On Mon, Nov 22, 2021 at 07:21:57PM +0530, Jagan Teki wrote: > > > > It's perfectly valid to dereference the pointer in atomic_enable, and > > > > that patch would consume memory for no particular reason. > > > > > > Again, I'm not pointing any mistake in dereference and certainly not > > > understand about what memory consumption issue here. > > > > You add a struct drm_display_mode field to struct sun6i_dsi. It > > increases the size of struct sun6i_dsi of sizeof(struct > > drm_display_mode). > > > > > I'm doing it here since I'm doing it via mode_set in other drivers. No > > > problem for me either way. > > > > But *why* are you doing so? > > > > There might be a valid reason in other drivers, but there's none here > > (that you mentioned at least). > > The reason is to use existing bridge function instead of dereference > ie what I've mentioned. I don't have any other reasons. This discussion is going in circles. Unless you have a reason other than "because we can", NAK for the reasons already stated above. Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel