From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC454C4332F for ; Tue, 23 Nov 2021 15:38:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 48C0D83679; Tue, 23 Nov 2021 16:38:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="IpKDJuJH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DE798811DE; Tue, 23 Nov 2021 16:38:14 +0100 (CET) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E26D982F80 for ; Tue, 23 Nov 2021 16:38:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72e.google.com with SMTP id t6so22265028qkg.1 for ; Tue, 23 Nov 2021 07:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2NkLTxcN+ZiCFuwt3Z03mx7HmV8cnOfmyyKb7IiOXNY=; b=IpKDJuJHTMYYM8rVvCCLImVOBdv+FlNm4zwDOUxW4z3x40rzEpavqIjgKsp96XkSNk ymJTjJdkahWRvp+ZHVcCRh5EuHS74K3vSqMQsGFO2jZv0gsAiKzHhs4Ok2eTKJy9QZo0 FFulIKJc9sbT1gjENP5coI70ypQZv2iVxI/ao= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2NkLTxcN+ZiCFuwt3Z03mx7HmV8cnOfmyyKb7IiOXNY=; b=Pc4xNGTEPKVfMHAUO82espC8QEHWfA14gi4e5z6taPVJNEne7uoNgAs2TbRfivysFT 8qinNmKoPmIeD3EJYjgQdxOJVpa+BRjLRNiTA5pC/4s77PbrHtabUOOUPVkrEcmWKURm aFYu8cY0SlfLpz3+EuSdJdHkzvhhEK36htM5HlOT8HrpJtVXcQkoqxhxIjo/ft8ZBN7u 7MCuqV4mjMaSauyHii4SBE4A6H8msDUo8DwwQLyoilRyge4O5aDpaPUGXQeyEHCELf9G cwrlKzz7KpOOEluGPYSvKL6jm2z55KrtB+EK7lYcYnwNytrO5ZBi9eh5MtyAQAqmX/c7 HrNQ== X-Gm-Message-State: AOAM533e9Y+wE9VjQwcoioHz2svnu8G/tHoGa9DzpV3Gs6oLfobYV3dY jECFsTfiZnxrLBmN8q+vT84GcQ== X-Google-Smtp-Source: ABdhPJzgj9NCcmzsW09c9YIlt6V0tJ+Dz6+YEQ6W2uQpS48r3qdO5Gbew6mIein345RBAdPmRaDlCQ== X-Received: by 2002:a05:620a:2711:: with SMTP id b17mr5451776qkp.57.1637681886602; Tue, 23 Nov 2021 07:38:06 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2132-1e2a-3644-57ec.res6.spectrum.com. [2603:6081:7b01:cbda:2132:1e2a:3644:57ec]) by smtp.gmail.com with ESMTPSA id az16sm6612717qkb.124.2021.11.23.07.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 07:38:05 -0800 (PST) Date: Tue, 23 Nov 2021 10:38:03 -0500 From: Tom Rini To: "Peng Fan (OSS)" Cc: Rob Herring , "lukma@denx.de" , "sjg@chromium.org" , "seanga2@gmail.com" , "u-boot@lists.denx.de" Subject: Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults Message-ID: <20211123153803.GK24579@bill-the-cat> References: <20211029012801.15193-1-peng.fan@oss.nxp.com> <20211120125711.GO24579@bill-the-cat> <20211122132204.GV24579@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dVUrXUjE+ke2Ara+" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --dVUrXUjE+ke2Ara+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 23, 2021 at 03:02:45AM +0000, Peng Fan (OSS) wrote: > > Subject: Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > >=20 > > On Mon, Nov 22, 2021 at 11:33:27AM +0800, Peng Fan (OSS) wrote: > > > + Rob > > > > > > On 2021/11/20 20:57, Tom Rini wrote: > > > > On Sat, Nov 20, 2021 at 12:10:54PM +0000, Peng Fan (OSS) wrote: > > > > > > Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > > > > > > > > > > > > From: Peng Fan > > > > > > > > > > > > Current code has a force clk_set_defaults in multiple stages, > > > > > > U-Boot reuse the same device tree and Linux Kernel device tree, > > > > > > but we not register all the clks as Linux Kernel, so > > > > > > clk_set_defaults will fail and cause the clk provider registera= tion fail. > > > > > > > > > > > > So introduce a new property to ignore the default settings which > > > > > > could be used by any node that wanna ignore default settings. > > > > > > > > > > > > Reviewed-by: Simon Glass > > > > > > Signed-off-by: Peng Fan > > > > > > --- > > > > > > > > > > > > V2: > > > > > > Add R-b tag > > > > > > Tom, Simon > > > > > > After a thought, I think still put it as a u-boot thing. > > assigned-clock-x is > > > > > > actually Linux specific, however I could not add the new pr= operty > > to Linux, > > > > > > because we are supporting SystemReady-IR, we need the > > > > > > assigned-clock-x property > > > > > > in linux working and ignore it in U-Boot. > > > > > > > > > > Any more thoughts? > > > > > > > > Just my continued request that you treat this as generic and submit > > > > the binding upstream so it can be in the device tree for the platfo= rm. > > > > > > > > > > As Sean said, this is to serve cast that linux and U-Boot use the same > > > device tree, I mean U-Boot runtime export device tree to linux for > > > SR-IR (system-ready IR) booting. > > > > > > Linux needs assigned-clocks to some reason, but U-Boot not need that > > > because the driver not added the support or not a must to have that. > > > > > > Because assigned-clocks failure in U-Boot will cause probe fail now, > > > the device driver will report failure. > > > > > > You mean rename this to "ignore-clk-defaults" or keep > > > "u-boot,ignore-clk-defauls" or "firmware,ignore-clk-defaults" to linux > > > device tree binding? > > > > > > I could try to send to linux kernel with "firmware" as a prefix. > >=20 > > What I mean is that first I'm not seeing the description of the propert= y as > > being clear enough, either in commit message or the binding itself. > > That's why in my mind I keep seeing this as "we set the properties > > linux,assigned-clocks and u-boot,ignore-clk-defaults" and I don't know = why > > we need both. Is there not something we can do based on seeing > > linux,assigned-clocks ? Showing something that makes use of the proper= ty > > you're wishing to add would be helpful. In fact, some specific dts sni= ppets > > would be helpful to understand what's going on here. >=20 > clk: clock-controller@30380000 { > compatible =3D "fsl,imx8mp-ccm"; > reg =3D <0x30380000 0x10000>; > #clock-cells =3D <1>; > clocks =3D <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, > <&clk_ext3>, <&clk_ext4>; > clock-names =3D "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", > "clk_ext3", "clk_ext4"; > assigned-clocks =3D <&clk IMX8MP_CLK_A53_SRC>, > <&clk IMX8MP_CLK_A53_CORE>, > <&clk IMX8MP_CLK_NOC>, > <&clk IMX8MP_CLK_NOC_IO>, > <&clk IMX8MP_CLK_GIC>, > <&clk IMX8MP_CLK_AUDIO_AHB>, > <&clk IMX8MP_CLK_AUDIO_AXI_SRC>, > <&clk IMX8MP_CLK_IPG_AUDIO_ROOT>, > <&clk IMX8MP_AUDIO_PLL1>, > <&clk IMX8MP_AUDIO_PLL2>; > assigned-clock-parents =3D <&clk IMX8MP_SYS_PLL1_800M>, > <&clk IMX8MP_ARM_PLL_OUT>, > <&clk IMX8MP_SYS_PLL2_1000M>, > <&clk IMX8MP_SYS_PLL1_800M>, > <&clk IMX8MP_SYS_PLL2_500M>, > <&clk IMX8MP_SYS_PLL1_800M>, > <&clk IMX8MP_SYS_PLL1_800M>; > assigned-clock-rates =3D <0>, <0>, > <1000000000>, > <800000000>, > <500000000>, > <400000000>, > <800000000>, > <400000000>, > <393216000>, > <361267200>; > u-boot,ignore-clk-defaults; > }; >=20 > The above node is that I wanna have in U-Boot device tree. > This node is same as the one used in linux device tree except the new > property introduced here. That property must be in the Linux device tree too. > In i.MX U-Boot, we not support the clks here in the clk driver, but linux= needs the assigned-clocks property, so I could not delete it > because U-Boot runtime export the device tree to Linux. >=20 > So add a new property here for U-Boot specific usage, if the property > is there, U-Boot ignore the assigned-clock settings for a node. OK, so what does U-Boot do instead now? And why can U-Boot not infer that it should ignore this node without this property? --=20 Tom --dVUrXUjE+ke2Ara+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGdCtsACgkQFHw5/5Y0 tywNKQv+NQrAbWo2ahpycrr0NB2/0br5eSyF8SOfv68IvIQ0XcTU/jIQwv9vmuAY KZlm/j7lCTmkWKS0MjNDXuBsBMtYbghOfJjC8TehsB1+V7mYL3Maa1Ff+y+bwrAA oje4xvnklXOetUBY63KwVJdpZmKhQfXjp5k8rm45saBKfB0NsLnkP1AaxfmP9jgc eqYYORp5JkFOftKB1nSZS2O4p9CA9aVpQkpIkweXy6nIPbtxEeJZMX9zTAtqMUk6 zfLc5IwU8yS1kpEa7EtRs/fLmIKkJBVxU7DOsPscJEf0v9UPUN3MO7OU2Ua2LgrB x/F/PBKkqpvy6F2gdtL8AALN6haradFbCZtHFiN5PhNFjvYbAUzHpaAdA3KtIPGe QoOm/IZoI9jzDONXrhwVz00RIhtuAMhDDPjirOshcvkgbUoljLnhXc9aaWlMyRIQ 40TDgnzXAe+wjQ4tXKAVZFK3MpdEDGV9FcjBCDDXj/G08OXw/AuxPkB9nvVMLbx8 j0CTvH63 =qbaB -----END PGP SIGNATURE----- --dVUrXUjE+ke2Ara+--