From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D93742C81 for ; Wed, 24 Nov 2021 06:59:41 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2A62068AFE; Wed, 24 Nov 2021 07:59:38 +0100 (CET) Date: Wed, 24 Nov 2021 07:59:38 +0100 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , Mike Snitzer , Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Subject: Re: [PATCH 25/29] dax: return the partition offset from fs_dax_get_by_bdev Message-ID: <20211124065938.GB7229@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-26-hch@lst.de> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Nov 23, 2021 at 06:56:29PM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > > > Prepare from removing the block_device from the DAX I/O path by returning > > s/from removing/for the removal of/ Fixed. > > td->dm_dev.bdev = bdev; > > - td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev); > > + td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev, &part_off); > > Perhaps allow NULL as an argument for callers that do not care about > the start offset? All callers currently care, dm just has another way to get at the information. So for now I'd like to not add the NULL special case, but we can reconsider that as needed if/when more callers show up. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E5BCC433EF for ; Wed, 24 Nov 2021 06:59:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id CB2FA80CDA; Wed, 24 Nov 2021 06:59:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JevnHgG533ij; Wed, 24 Nov 2021 06:59:45 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8D76880C8F; Wed, 24 Nov 2021 06:59:44 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 60A20C001E; Wed, 24 Nov 2021 06:59:44 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 47C5CC0012 for ; Wed, 24 Nov 2021 06:59:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2F4EC4023B for ; Wed, 24 Nov 2021 06:59:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1jlhg1ViPL18 for ; Wed, 24 Nov 2021 06:59:41 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9C55D40233 for ; Wed, 24 Nov 2021 06:59:41 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2A62068AFE; Wed, 24 Nov 2021 07:59:38 +0100 (CET) Date: Wed, 24 Nov 2021 07:59:38 +0100 From: Christoph Hellwig To: Dan Williams Subject: Re: [PATCH 25/29] dax: return the partition offset from fs_dax_get_by_bdev Message-ID: <20211124065938.GB7229@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-26-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Nov 23, 2021 at 06:56:29PM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > > > Prepare from removing the block_device from the DAX I/O path by returning > > s/from removing/for the removal of/ Fixed. > > td->dm_dev.bdev = bdev; > > - td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev); > > + td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev, &part_off); > > Perhaps allow NULL as an argument for callers that do not care about > the start offset? All callers currently care, dm just has another way to get at the information. So for now I'd like to not add the NULL special case, but we can reconsider that as needed if/when more callers show up. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B01CC433EF for ; Wed, 24 Nov 2021 06:59:48 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HzX1v0j3Bz2yms for ; Wed, 24 Nov 2021 17:59:47 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HzX1q1S6pz2xrS for ; Wed, 24 Nov 2021 17:59:42 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id 2A62068AFE; Wed, 24 Nov 2021 07:59:38 +0100 (CET) Date: Wed, 24 Nov 2021 07:59:38 +0100 From: Christoph Hellwig To: Dan Williams Subject: Re: [PATCH 25/29] dax: return the partition offset from fs_dax_get_by_bdev Message-ID: <20211124065938.GB7229@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-26-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Tue, Nov 23, 2021 at 06:56:29PM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > > > Prepare from removing the block_device from the DAX I/O path by returning > > s/from removing/for the removal of/ Fixed. > > td->dm_dev.bdev = bdev; > > - td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev); > > + td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev, &part_off); > > Perhaps allow NULL as an argument for callers that do not care about > the start offset? All callers currently care, dm just has another way to get at the information. So for now I'd like to not add the NULL special case, but we can reconsider that as needed if/when more callers show up. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27ED3C433EF for ; Wed, 24 Nov 2021 06:59:54 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-18-EASi-LLgOpG3I73yaz09YQ-1; Wed, 24 Nov 2021 01:59:52 -0500 X-MC-Unique: EASi-LLgOpG3I73yaz09YQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 522EE1853026; Wed, 24 Nov 2021 06:59:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E4515DF2E; Wed, 24 Nov 2021 06:59:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 674671809C89; Wed, 24 Nov 2021 06:59:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AO6xj0J003572 for ; Wed, 24 Nov 2021 01:59:45 -0500 Received: by smtp.corp.redhat.com (Postfix) id BA6C840CFD11; Wed, 24 Nov 2021 06:59:45 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5D7040CFD0E for ; Wed, 24 Nov 2021 06:59:45 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A11008007B1 for ; Wed, 24 Nov 2021 06:59:45 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-QVTLmqRUMMG_cseULAw1qQ-1; Wed, 24 Nov 2021 01:59:41 -0500 X-MC-Unique: QVTLmqRUMMG_cseULAw1qQ-1 Received: by verein.lst.de (Postfix, from userid 2407) id 2A62068AFE; Wed, 24 Nov 2021 07:59:38 +0100 (CET) Date: Wed, 24 Nov 2021 07:59:38 +0100 From: Christoph Hellwig To: Dan Williams Message-ID: <20211124065938.GB7229@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-26-hch@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: dm-devel@redhat.com Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig Subject: Re: [dm-devel] [PATCH 25/29] dax: return the partition offset from fs_dax_get_by_bdev X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Nov 23, 2021 at 06:56:29PM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > > > Prepare from removing the block_device from the DAX I/O path by returning > > s/from removing/for the removal of/ Fixed. > > td->dm_dev.bdev = bdev; > > - td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev); > > + td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev, &part_off); > > Perhaps allow NULL as an argument for callers that do not care about > the start offset? All callers currently care, dm just has another way to get at the information. So for now I'd like to not add the NULL special case, but we can reconsider that as needed if/when more callers show up. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel