From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58794C433EF for ; Wed, 24 Nov 2021 12:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244938AbhKXNBO (ORCPT ); Wed, 24 Nov 2021 08:01:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:39082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347460AbhKXM6u (ORCPT ); Wed, 24 Nov 2021 07:58:50 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id ABE856104F; Wed, 24 Nov 2021 12:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637757231; bh=25jiBG1ykyFIvh1S9ZIFgDtxICbjEu2CanOLhX6GUrA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MdtfCOWDQiPAbDAypqCF2cUrBWeOCuMk/82wDatcvVQPYZFnamH1Rw4Av1lS/6BXR tXKnMGc57MNduWp/RHzCKpeGcZ6Pmhf+o3SQ+JWFZtFPxk/hIv1W1f3ZM3AdDiL8UA GrBqcu7hVeRKkC/An3e3PLSt+SHm5kF2Awywolgw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com, Rajat Asthana , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 100/323] media: mceusb: return without resubmitting URB in case of -EPROTO error. Date: Wed, 24 Nov 2021 12:54:50 +0100 Message-Id: <20211124115722.341394324@linuxfoundation.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124115718.822024889@linuxfoundation.org> References: <20211124115718.822024889@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rajat Asthana [ Upstream commit 476db72e521983ecb847e4013b263072bb1110fc ] Syzkaller reported a warning called "rcu detected stall in dummy_timer". The error seems to be an error in mceusb_dev_recv(). In the case of -EPROTO error, the routine immediately resubmits the URB. Instead it should return without resubmitting URB. Reported-by: syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com Signed-off-by: Rajat Asthana Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/rc/mceusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index 845583e2af4d5..cf4bcf7c62f2e 100644 --- a/drivers/media/rc/mceusb.c +++ b/drivers/media/rc/mceusb.c @@ -1323,6 +1323,7 @@ static void mceusb_dev_recv(struct urb *urb) case -ECONNRESET: case -ENOENT: case -EILSEQ: + case -EPROTO: case -ESHUTDOWN: usb_unlink_urb(urb); return; -- 2.33.0