All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Kacur <jkacur@redhat.com>, Daniel Wagner <wagi@monom.org>,
	Tom Zanussi <zanussi@kernel.org>,
	"Srivatsa S. Bhat" <srivatsa@csail.mit.edu>,
	stable-rt@vger.kernel.org
Subject: [PATCH RT 03/13] sched: Switch wait_task_inactive to HRTIMER_MODE_REL_HARD
Date: Wed, 24 Nov 2021 13:03:06 -0500	[thread overview]
Message-ID: <20211124180326.627400767@goodmis.org> (raw)
In-Reply-To: 20211124180303.574562279@goodmis.org

5.10.78-rt56-rc3 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

With PREEMPT_RT enabled all hrtimers callbacks will be invoked in
softirq mode unless they are explicitly marked as HRTIMER_MODE_HARD.
During boot kthread_bind() is used for the creation of per-CPU threads
and then hangs in wait_task_inactive() if the ksoftirqd is not
yet up and running.
The hang disappeared since commit
   26c7295be0c5e ("kthread: Do not preempt current task if it is going to call schedule()")

but enabling function trace on boot reliably leads to the freeze on boot
behaviour again.
The timer in wait_task_inactive() can not be directly used by an user
interface to abuse it and create a mass wake of several tasks at the
same time which would to long sections with disabled interrupts.
Therefore it is safe to make the timer HRTIMER_MODE_REL_HARD.

Switch the timer to HRTIMER_MODE_REL_HARD.

Cc: stable-rt@vger.kernel.org
Link: https://lkml.kernel.org/r/20210826170408.vm7rlj7odslshwch@linutronix.de
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index f638d9420553..54fa3bb1b7c4 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2734,7 +2734,7 @@ unsigned long wait_task_inactive(struct task_struct *p, long match_state)
 			ktime_t to = NSEC_PER_SEC / HZ;
 
 			set_current_state(TASK_UNINTERRUPTIBLE);
-			schedule_hrtimeout(&to, HRTIMER_MODE_REL);
+			schedule_hrtimeout(&to, HRTIMER_MODE_REL_HARD);
 			continue;
 		}
 
-- 
2.33.0

  parent reply	other threads:[~2021-11-24 18:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 18:03 [PATCH RT 00/13] Linux 5.10.78-rt56-rc3 Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 01/13] mm, zsmalloc: Convert zsmalloc_handle.lock to spinlock_t Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 02/13] sched: Fix get_push_task() vs migrate_disable() Steven Rostedt
2021-11-24 18:03 ` Steven Rostedt [this message]
2021-11-24 18:03 ` [PATCH RT 04/13] preempt: Move preempt_enable_no_resched() to the RT block Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 05/13] mm: Disable NUMA_BALANCING_DEFAULT_ENABLED and TRANSPARENT_HUGEPAGE on PREEMPT_RT Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 06/13] fscache: Use only one fscache_object_cong_wait Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 07/13] fscache: Use only one fscache_object_cong_wait (2) Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 08/13] locking: Drop might_resched() from might_sleep_no_state_check() Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 09/13] drm/i915/gt: Queue and wait for the irq_work item Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 10/13] irq_work: Allow irq_work_sync() to sleep if irq_work() no IRQ support Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 11/13] irq_work: Handle some irq_work in a per-CPU thread on PREEMPT_RT Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 12/13] irq_work: Also rcuwait for !IRQ_WORK_HARD_IRQ " Steven Rostedt
2021-11-24 18:03 ` [PATCH RT 13/13] Linux 5.10.78-rt56-rc3 Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211124180326.627400767@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=srivatsa@csail.mit.edu \
    --cc=stable-rt@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wagi@monom.org \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.