From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mqElq-0001l2-R2
	for mharc-grub-devel@gnu.org; Thu, 25 Nov 2021 08:26:38 -0500
Received: from eggs.gnu.org ([209.51.188.92]:38882)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1mqElq-0001kr-0o
 for grub-devel@gnu.org; Thu, 25 Nov 2021 08:26:38 -0500
Received: from dibed.net-space.pl ([84.10.22.86]:45022)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1mqElo-0000AU-DR
 for grub-devel@gnu.org; Thu, 25 Nov 2021 08:26:37 -0500
Received: from router-fw.i.net-space.pl ([192.168.52.1]:45396 "EHLO
 tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP
 id S2119137AbhKYNXw (ORCPT <rfc822;grub-devel@gnu.org>);
 Thu, 25 Nov 2021 14:23:52 +0100
X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity
 as: dkiper
Date: Thu, 25 Nov 2021 14:23:50 +0100
From: Daniel Kiper <dkiper@net-space.pl>
To: Nikita Ermakov <arei@altlinux.org>
Cc: GRUB development mailing list <grub-devel@gnu.org>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>,
 Heinrich Schuchardt <xypron.glpk@gmx.de>,
 Leif Lindholm <leif.lindholm@linaro.org>, Fu Wei <tekkamanninja@gmail.com>
Subject: Re: [PATCH v3 1/7] loader: drop argv[] argument in grub_initrd_load()
Message-ID: <20211125132350.jyi6745p2m2xshf4@tomti.i.net-space.pl>
References: <20211028203118.7908-1-arei@altlinux.org>
 <20211028203118.7908-2-arei@altlinux.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211028203118.7908-2-arei@altlinux.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl;
 helo=dibed.net-space.pl
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Nov 2021 13:26:38 -0000

On Thu, Oct 28, 2021 at 11:31:13PM +0300, Nikita Ermakov wrote:
> In the case of an error grub_initrd_load() uses argv[] to print the
> filename that caused the error. It is also possible to obtain the
> filename from the file handles and there is no need to duplicate that
> information in argv[], so let's drop it.
>
> Signed-off-by: Nikita Ermakov <arei@altlinux.org>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel