From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCC95C433F5 for ; Thu, 25 Nov 2021 14:15:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B65596E4E3; Thu, 25 Nov 2021 14:15:26 +0000 (UTC) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 341F56E4E3 for ; Thu, 25 Nov 2021 14:15:25 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id B0E1F3201A17; Thu, 25 Nov 2021 09:15:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 25 Nov 2021 09:15:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=1bqkC8/u8upZp5cpgt6rGNqrfgj od8S+Z8qXsVjJBGQ=; b=W+ErM4l65qzbNC1EHEKSytGo7ze0yBfFB7Kro0MRIA2 4cJEVceI4ZA4M4Sc2kuDAdHseY0Wfmig5csG4ZMftstoun6zV4VgwU9TJHY3rcok AiPNSqVkejpGpjvP3hpt9ZU4f/JB5fcfBwmPUZ5wkP94FcMWyxrIVY+Sv6cJRLQ8 RJKjea/Sg1N+lQhvaOEI1vEwAbPyHA+9zJ1mdWkSpqlAZV/mc9KM6gjqPpDx0bE4 I/O/sdqFxj5cTXJGFLbuwaPXE1L3yQNW8vJ2i4/k0XfBBRxJz3Uj8mlMOS9DVVSB BrV836g7+th9wtyNAYOzbPkROPe8iAGQ3LPSJV4JOuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1bqkC8 /u8upZp5cpgt6rGNqrfgjod8S+Z8qXsVjJBGQ=; b=DM7cp/WEfBhSVhH55cYNnw TixX0tDF50qhL7qQxHn6OXggxseLkQsU0QoTHWiIdsjXPkzPMeGclwOwUb7Kv89W eHKsaDgThQImYqp+1M5sNCscixso9h3OFnwqcj4VBH7NpGvhsBiMhgW1wekPWA+V yPm0WZNVmFVlG/4nl8X4wDadyQYBX2tCSmmQexgOd+trGbbc9y18/8VxYY5Ajg0w jN/yMpfplhoX8k0qHKlTzEKWvKUnV+l1T687IrxFhBvn55AeTEw0ScVh6p/BN6xc mMGxtiWdXVtYK7LschXP4RCI8p8NKkaokjBwK6OghQJ6ncx/XzbENKHxpGVbG/+w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrhedtgdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeevveefffduveeitdegtefhhfetueffteefffdvheevvdehteethedvleffgfej vdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Nov 2021 09:15:18 -0500 (EST) Date: Thu, 25 Nov 2021 15:15:16 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v5 3/7] drm: sun4i: dsi: Convert to bridge driver Message-ID: <20211125141516.oymscgs3xcjqmgce@gilmour> References: <20211122065223.88059-1-jagan@amarulasolutions.com> <20211122065223.88059-4-jagan@amarulasolutions.com> <20211122100712.dls4eqsu6o5gcc5k@gilmour> <20211122140457.jm7cwpp2h3fkf2nd@gilmour> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6smyeew6pbusr3fy" Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Laurent Pinchart , Sam Ravnborg , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --6smyeew6pbusr3fy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 24, 2021 at 12:02:47AM +0530, Jagan Teki wrote: > > > > > > + dsi->panel =3D of_drm_find_panel(remote); > > > > > > + if (IS_ERR(dsi->panel)) { > > > > > > + dsi->panel =3D NULL; > > > > > > + > > > > > > + dsi->next_bridge =3D of_drm_find_bridge(remote); > > > > > > + if (IS_ERR(dsi->next_bridge)) { > > > > > > + dev_err(dsi->dev, "failed to find bridge\= n"); > > > > > > + return PTR_ERR(dsi->next_bridge); > > > > > > + } > > > > > > + } else { > > > > > > + dsi->next_bridge =3D NULL; > > > > > > + } > > > > > > + > > > > > > + of_node_put(remote); > > > > > > > > > > Using devm_drm_of_get_bridge would greatly simplify the driver > > > > > > > > I'm aware of this and this would break the existing sunxi dsi bindi= ng, > > > > we are not using ports based pipeline in dsi node. Of-course you ha= ve > > > > pointed the same before, please check below > > > > https://patchwork.kernel.org/project/dri-devel/patch/20210322140152= =2E101709-2-jagan@amarulasolutions.com/ > > > > > > Then drm_of_find_panel_or_bridge needs to be adjusted to handle the D= SI > > > bindings and look for a panel or bridge not only through the OF graph, > > > but also on the child nodes > > > > Okay. I need to check this. >=20 > devm_drm_of_get_bridge is not working with legacy binding like the one > used in sun6i dsi There's nothing legacy about it. > https://patchwork.kernel.org/project/dri-devel/patch/20211122065223.88059= -6-jagan@amarulasolutions.com/ >=20 > dsi->next_bridge =3D devm_drm_of_get_bridge(dsi->dev, dsi->dev->of_node, = 0, 0); > if (IS_ERR(dsi->next_bridge)) > return PTR_ERR(dsi->next_bridge); >=20 > It is only working if we have ports on the pipeline, something like this > https://patchwork.kernel.org/project/dri-devel/patch/20210214194102.12614= 6-8-jagan@amarulasolutions.com/ >=20 > Please have a look and let me know if I miss anything? Yes, you're missing the answer you quoted earlier: > > > Then drm_of_find_panel_or_bridge needs to be adjusted to handle the D= SI > > > bindings and look for a panel or bridge not only through the OF graph, > > > but also on the child nodes Maxime --6smyeew6pbusr3fy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYZ+adAAKCRDj7w1vZxhR xexJAQCJm5Ec5ViUoV/nSK/egM4QxFA+5f25aDtP8QywVffgZwD/Vdan4K7IFhYc SwA3NE7AuNs+SkYQ/JI/OVRHL8kaIQY= =lNtS -----END PGP SIGNATURE----- --6smyeew6pbusr3fy-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E41A8C433EF for ; Thu, 25 Nov 2021 14:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=osSVHGXKersItH1jTtzRhCDng/7SLm245E7w0p6MQZ8=; b=VdLw+i19CdFJm65SAr6+kE1NAp Y61hJC5U1v+e09zgJlIb9d0B22ptFP6IuO2ZVhbHvueHIK4IPB0AuCddj0m+/r52ZcQTGjfNMlaeH QuCSaRYjdvYfKx2u0LD/RxCN6fhDeOqHz1AksVPwwzVTKaXKduCneWIrWjEiF3dXL5WfatUKewM4P Mjw2raqPtw85XLmaGR5wxkVCw5wYfp4ZOLIRgu2U/nIhUnQzDi5TujO0V5/M7E8poTNah/cwNoBYD y/pTgndxFuP5ctsQeHFZDwHgS7NW9PznmYcCUfHfBZU+5A0DugBh1pe/WkFLWCB8LbZCu9kY1FChc pL6XEhSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqFXA-007nEr-Jj; Thu, 25 Nov 2021 14:15:32 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqFX7-007nCv-DE for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 14:15:31 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id B0E1F3201A17; Thu, 25 Nov 2021 09:15:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 25 Nov 2021 09:15:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=1bqkC8/u8upZp5cpgt6rGNqrfgj od8S+Z8qXsVjJBGQ=; b=W+ErM4l65qzbNC1EHEKSytGo7ze0yBfFB7Kro0MRIA2 4cJEVceI4ZA4M4Sc2kuDAdHseY0Wfmig5csG4ZMftstoun6zV4VgwU9TJHY3rcok AiPNSqVkejpGpjvP3hpt9ZU4f/JB5fcfBwmPUZ5wkP94FcMWyxrIVY+Sv6cJRLQ8 RJKjea/Sg1N+lQhvaOEI1vEwAbPyHA+9zJ1mdWkSpqlAZV/mc9KM6gjqPpDx0bE4 I/O/sdqFxj5cTXJGFLbuwaPXE1L3yQNW8vJ2i4/k0XfBBRxJz3Uj8mlMOS9DVVSB BrV836g7+th9wtyNAYOzbPkROPe8iAGQ3LPSJV4JOuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1bqkC8 /u8upZp5cpgt6rGNqrfgjod8S+Z8qXsVjJBGQ=; b=DM7cp/WEfBhSVhH55cYNnw TixX0tDF50qhL7qQxHn6OXggxseLkQsU0QoTHWiIdsjXPkzPMeGclwOwUb7Kv89W eHKsaDgThQImYqp+1M5sNCscixso9h3OFnwqcj4VBH7NpGvhsBiMhgW1wekPWA+V yPm0WZNVmFVlG/4nl8X4wDadyQYBX2tCSmmQexgOd+trGbbc9y18/8VxYY5Ajg0w jN/yMpfplhoX8k0qHKlTzEKWvKUnV+l1T687IrxFhBvn55AeTEw0ScVh6p/BN6xc mMGxtiWdXVtYK7LschXP4RCI8p8NKkaokjBwK6OghQJ6ncx/XzbENKHxpGVbG/+w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrhedtgdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeevveefffduveeitdegtefhhfetueffteefffdvheevvdehteethedvleffgfej vdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Nov 2021 09:15:18 -0500 (EST) Date: Thu, 25 Nov 2021 15:15:16 +0100 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Laurent Pinchart , Neil Armstrong , Robert Foss , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-amarula@amarulasolutions.com Subject: Re: [PATCH v5 3/7] drm: sun4i: dsi: Convert to bridge driver Message-ID: <20211125141516.oymscgs3xcjqmgce@gilmour> References: <20211122065223.88059-1-jagan@amarulasolutions.com> <20211122065223.88059-4-jagan@amarulasolutions.com> <20211122100712.dls4eqsu6o5gcc5k@gilmour> <20211122140457.jm7cwpp2h3fkf2nd@gilmour> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_061529_555327_86C1A7F5 X-CRM114-Status: GOOD ( 22.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3982747617434706917==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3982747617434706917== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6smyeew6pbusr3fy" Content-Disposition: inline --6smyeew6pbusr3fy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 24, 2021 at 12:02:47AM +0530, Jagan Teki wrote: > > > > > > + dsi->panel =3D of_drm_find_panel(remote); > > > > > > + if (IS_ERR(dsi->panel)) { > > > > > > + dsi->panel =3D NULL; > > > > > > + > > > > > > + dsi->next_bridge =3D of_drm_find_bridge(remote); > > > > > > + if (IS_ERR(dsi->next_bridge)) { > > > > > > + dev_err(dsi->dev, "failed to find bridge\= n"); > > > > > > + return PTR_ERR(dsi->next_bridge); > > > > > > + } > > > > > > + } else { > > > > > > + dsi->next_bridge =3D NULL; > > > > > > + } > > > > > > + > > > > > > + of_node_put(remote); > > > > > > > > > > Using devm_drm_of_get_bridge would greatly simplify the driver > > > > > > > > I'm aware of this and this would break the existing sunxi dsi bindi= ng, > > > > we are not using ports based pipeline in dsi node. Of-course you ha= ve > > > > pointed the same before, please check below > > > > https://patchwork.kernel.org/project/dri-devel/patch/20210322140152= =2E101709-2-jagan@amarulasolutions.com/ > > > > > > Then drm_of_find_panel_or_bridge needs to be adjusted to handle the D= SI > > > bindings and look for a panel or bridge not only through the OF graph, > > > but also on the child nodes > > > > Okay. I need to check this. >=20 > devm_drm_of_get_bridge is not working with legacy binding like the one > used in sun6i dsi There's nothing legacy about it. > https://patchwork.kernel.org/project/dri-devel/patch/20211122065223.88059= -6-jagan@amarulasolutions.com/ >=20 > dsi->next_bridge =3D devm_drm_of_get_bridge(dsi->dev, dsi->dev->of_node, = 0, 0); > if (IS_ERR(dsi->next_bridge)) > return PTR_ERR(dsi->next_bridge); >=20 > It is only working if we have ports on the pipeline, something like this > https://patchwork.kernel.org/project/dri-devel/patch/20210214194102.12614= 6-8-jagan@amarulasolutions.com/ >=20 > Please have a look and let me know if I miss anything? Yes, you're missing the answer you quoted earlier: > > > Then drm_of_find_panel_or_bridge needs to be adjusted to handle the D= SI > > > bindings and look for a panel or bridge not only through the OF graph, > > > but also on the child nodes Maxime --6smyeew6pbusr3fy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYZ+adAAKCRDj7w1vZxhR xexJAQCJm5Ec5ViUoV/nSK/egM4QxFA+5f25aDtP8QywVffgZwD/Vdan4K7IFhYc SwA3NE7AuNs+SkYQ/JI/OVRHL8kaIQY= =lNtS -----END PGP SIGNATURE----- --6smyeew6pbusr3fy-- --===============3982747617434706917== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3982747617434706917==--