From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1459291858936428204==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v6 09/10] device-dax: set mapping prior to vmf_insert_pfn{, _pmd, pud}() Date: Fri, 26 Nov 2021 02:02:22 +0800 Message-ID: <202111260142.vX4mNkxP-lkp@intel.com> In-Reply-To: <20211124191005.20783-10-joao.m.martins@oracle.com> List-Id: --===============1459291858936428204== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Joao, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] url: https://github.com/0day-ci/linux/commits/Joao-Martins/mm-device-dax= -Introduce-compound-pages-in-devmap/20211125-031335 base: https://github.com/hnaz/linux-mm master config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211126/= 202111260142.vX4mNkxP-lkp(a)intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/44ce2eab00a4dc12253e01dd0= 1be15b7e4d7d1ea git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Joao-Martins/mm-device-dax-Introdu= ce-compound-pages-in-devmap/20211125-031335 git checkout 44ce2eab00a4dc12253e01dd01be15b7e4d7d1ea # save the config file to linux build tree COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= ARCH=3Darc = If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/dax/device.c: In function 'dev_dax_huge_fault': >> drivers/dax/device.c:226:23: warning: variable 'fault_size' set but not = used [-Wunused-but-set-variable] 226 | unsigned long fault_size; | ^~~~~~~~~~ drivers/dax/device.c: At top level: drivers/dax/device.c:396:5: warning: no previous prototype for 'dev_dax_= probe' [-Wmissing-prototypes] 396 | int dev_dax_probe(struct dev_dax *dev_dax) | ^~~~~~~~~~~~~ vim +/fault_size +226 drivers/dax/device.c 9557feee39b75ce drivers/dax/dax.c Dave Jiang 2017-02-24 221 = 226ab561075f6f8 drivers/dax/device.c Dan Williams 2018-07-13 222 st= atic vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, c791ace1e747371 drivers/dax/dax.c Dave Jiang 2017-02-24 223 = enum page_entry_size pe_size) dee410792419aaa drivers/dax/dax.c Dan Williams 2016-05-14 224 { f42003917b4569a drivers/dax/dax.c Dave Jiang 2017-02-22 225 s= truct file *filp =3D vmf->vma->vm_file; 2232c6382a453db drivers/dax/device.c Dan Williams 2018-07-13 @226 u= nsigned long fault_size; 36bdac1e674debd drivers/dax/device.c Souptick Joarder 2018-09-04 227 v= m_fault_t rc =3D VM_FAULT_SIGBUS; 36bdac1e674debd drivers/dax/device.c Souptick Joarder 2018-09-04 228 i= nt id; 2232c6382a453db drivers/dax/device.c Dan Williams 2018-07-13 229 p= fn_t pfn; 5f0694b300b9fb8 drivers/dax/dax.c Dan Williams 2017-01-30 230 s= truct dev_dax *dev_dax =3D filp->private_data; dee410792419aaa drivers/dax/dax.c Dan Williams 2016-05-14 231 = 6daaca522ab464d drivers/dax/device.c Dan Williams 2018-03-05 232 d= ev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) size =3D %d\n", current->comm, 6daaca522ab464d drivers/dax/device.c Dan Williams 2018-03-05 233 = (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", 762026203c0b87b drivers/dax/dax.c Oliver O'Halloran 2017-04-12 234 = vmf->vma->vm_start, vmf->vma->vm_end, pe_size); dee410792419aaa drivers/dax/dax.c Dan Williams 2016-05-14 235 = 7b6be8444e0f0dd drivers/dax/device.c Dan Williams 2017-04-11 236 i= d =3D dax_read_lock(); c791ace1e747371 drivers/dax/dax.c Dave Jiang 2017-02-24 237 s= witch (pe_size) { c791ace1e747371 drivers/dax/dax.c Dave Jiang 2017-02-24 238 c= ase PE_SIZE_PTE: 2232c6382a453db drivers/dax/device.c Dan Williams 2018-07-13 239 = fault_size =3D PAGE_SIZE; 2232c6382a453db drivers/dax/device.c Dan Williams 2018-07-13 240 = rc =3D __dev_dax_pte_fault(dev_dax, vmf, &pfn); a2d581675d485eb drivers/dax/dax.c Dave Jiang 2017-02-24 241 = break; c791ace1e747371 drivers/dax/dax.c Dave Jiang 2017-02-24 242 c= ase PE_SIZE_PMD: 2232c6382a453db drivers/dax/device.c Dan Williams 2018-07-13 243 = fault_size =3D PMD_SIZE; 2232c6382a453db drivers/dax/device.c Dan Williams 2018-07-13 244 = rc =3D __dev_dax_pmd_fault(dev_dax, vmf, &pfn); 9557feee39b75ce drivers/dax/dax.c Dave Jiang 2017-02-24 245 = break; c791ace1e747371 drivers/dax/dax.c Dave Jiang 2017-02-24 246 c= ase PE_SIZE_PUD: 2232c6382a453db drivers/dax/device.c Dan Williams 2018-07-13 247 = fault_size =3D PUD_SIZE; 2232c6382a453db drivers/dax/device.c Dan Williams 2018-07-13 248 = rc =3D __dev_dax_pud_fault(dev_dax, vmf, &pfn); a2d581675d485eb drivers/dax/dax.c Dave Jiang 2017-02-24 249 = break; a2d581675d485eb drivers/dax/dax.c Dave Jiang 2017-02-24 250 d= efault: 54eafcc9e339aff drivers/dax/dax.c Pushkar Jambhlekar 2017-04-11 251 = rc =3D VM_FAULT_SIGBUS; a2d581675d485eb drivers/dax/dax.c Dave Jiang 2017-02-24 252 } 2232c6382a453db drivers/dax/device.c Dan Williams 2018-07-13 253 = 7b6be8444e0f0dd drivers/dax/device.c Dan Williams 2017-04-11 254 d= ax_read_unlock(id); dee410792419aaa drivers/dax/dax.c Dan Williams 2016-05-14 255 = dee410792419aaa drivers/dax/dax.c Dan Williams 2016-05-14 256 r= eturn rc; dee410792419aaa drivers/dax/dax.c Dan Williams 2016-05-14 257 } dee410792419aaa drivers/dax/dax.c Dan Williams 2016-05-14 258 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============1459291858936428204==--