All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: stylon.wang@amd.com, Jun Lei <Jun.Lei@amd.com>,
	solomon.chiu@amd.com, Sunpeng.Li@amd.com, Harry.Wentland@amd.com,
	qingqing.zhuo@amd.com, George Shen <George.Shen@amd.com>,
	Rodrigo.Siqueira@amd.com, roman.li@amd.com, Anson.Jacob@amd.com,
	Aurabindo.Pillai@amd.com, wayne.lin@amd.com,
	mikita.lipski@amd.com, Bhawanpreet.Lakha@amd.com,
	agustin.gutierrez@amd.com, pavle.kotarac@amd.com
Subject: [PATCH 14/16] drm/amd/display: Add 16ms AUX RD interval W/A for specific LTTPR
Date: Fri, 26 Nov 2021 14:49:20 -0500	[thread overview]
Message-ID: <20211126194922.816835-15-Bhawanpreet.Lakha@amd.com> (raw)
In-Reply-To: <20211126194922.816835-1-Bhawanpreet.Lakha@amd.com>

From: George Shen <George.Shen@amd.com>

[Why]
Certain display configurations require an extra delay before
reading lane status with certain LTTPR.

[How]
Add temporary workaround to force AUX RD interval to
16ms for CR and EQ. Needs to be refactored later.

Reviewed-by: Jun Lei <Jun.Lei@amd.com>
Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: George Shen <George.Shen@amd.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 026ce0839719..28baa84102da 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -1384,6 +1384,12 @@ static enum link_training_result perform_channel_equalization_sequence(
 					dp_translate_training_aux_read_interval(
 						link->dpcd_caps.lttpr_caps.aux_rd_interval[offset - 1]);
 
+		if (link->dc->debug.apply_vendor_specific_lttpr_wa &&
+				(link->chip_caps & EXT_DISPLAY_PATH_CAPS__DP_FIXED_VS_EN) &&
+				link->lttpr_mode == LTTPR_MODE_TRANSPARENT) {
+			wait_time_microsec = 16000;
+		}
+
 		dp_wait_for_training_aux_rd_interval(
 				link,
 				wait_time_microsec);
@@ -1487,6 +1493,12 @@ static enum link_training_result perform_clock_recovery_sequence(
 		if (link->lttpr_mode == LTTPR_MODE_NON_TRANSPARENT)
 			wait_time_microsec = TRAINING_AUX_RD_INTERVAL;
 
+		if (link->dc->debug.apply_vendor_specific_lttpr_wa &&
+				(link->chip_caps & EXT_DISPLAY_PATH_CAPS__DP_FIXED_VS_EN) &&
+				link->lttpr_mode == LTTPR_MODE_TRANSPARENT) {
+			wait_time_microsec = 16000;
+		}
+
 		dp_wait_for_training_aux_rd_interval(
 				link,
 				wait_time_microsec);
-- 
2.25.1


  parent reply	other threads:[~2021-11-26 19:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26 19:49 [PATCH 00/16] DC Patches Nov 26, 2021 Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 01/16] drm/amd/display: Enable P010 for DCN3x ASICs Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 02/16] drm/amd/display: Allow DSC on supported MST branch devices Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 03/16] drm/amd/display: add hdmi disable debug check Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 04/16] drm/amd/display: Clear DPCD lane settings after repeater training Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 05/16] drm/amd/display: Fix for otg synchronization logic Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 06/16] drm/amd/display: Fix for the no Audio bug with Tiled Displays Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 07/16] drm/amd/display: add function for eDP and backlight power on Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 08/16] drm/amd/display: Add work around for tunneled MST Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 09/16] drm/amd/display: Fix dual eDP abnormal display issue Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 10/16] drm/amd/display: PSR panel capability debugfs Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 11/16] drm/amd/display: Add vendor specific LTTPR workarounds for DCN31 Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 12/16] drm/amd/display: Skip vendor specific LTTPR w/a outside link training Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 13/16] drm/amd/display: Add force detile buffer size debug flag Bhawanpreet Lakha
2021-11-26 19:49 ` Bhawanpreet Lakha [this message]
2021-11-26 19:49 ` [PATCH 15/16] drm/amd/display: [FW Promotion] Release 0.0.95 Bhawanpreet Lakha
2021-11-26 19:49 ` [PATCH 16/16] drm/amd/display: 3.2.164 Bhawanpreet Lakha
2021-11-29 14:16 ` [PATCH 00/16] DC Patches Nov 26, 2021 Wheeler, Daniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211126194922.816835-15-Bhawanpreet.Lakha@amd.com \
    --to=bhawanpreet.lakha@amd.com \
    --cc=Anson.Jacob@amd.com \
    --cc=Aurabindo.Pillai@amd.com \
    --cc=George.Shen@amd.com \
    --cc=Harry.Wentland@amd.com \
    --cc=Jun.Lei@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Sunpeng.Li@amd.com \
    --cc=agustin.gutierrez@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=mikita.lipski@amd.com \
    --cc=pavle.kotarac@amd.com \
    --cc=qingqing.zhuo@amd.com \
    --cc=roman.li@amd.com \
    --cc=solomon.chiu@amd.com \
    --cc=stylon.wang@amd.com \
    --cc=wayne.lin@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.