All of lore.kernel.org
 help / color / mirror / Atom feed
From: mwilck@suse.com
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
	Benjamin Marzinski <bmarzins@redhat.com>
Cc: lixiaokeng@huawei.com, Chongyun Wu <wu.chongyun@h3c.com>,
	dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [dm-devel] [PATCH v3 08/35] multipathd: cli.h: formatting improvements
Date: Sat, 27 Nov 2021 16:19:01 +0100	[thread overview]
Message-ID: <20211127151929.7727-9-mwilck@suse.com> (raw)
In-Reply-To: <20211127151929.7727-1-mwilck@suse.com>

From: Martin Wilck <mwilck@suse.com>

No functional changes. Just make the code a little easier to read.

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 multipathd/cli.h | 82 ++++++++++++++++++++++++------------------------
 1 file changed, 41 insertions(+), 41 deletions(-)

diff --git a/multipathd/cli.h b/multipathd/cli.h
index d224a2d..6a68107 100644
--- a/multipathd/cli.h
+++ b/multipathd/cli.h
@@ -4,83 +4,83 @@
 #include <stdint.h>
 
 enum {
-	__LIST,
+	__LIST,			/*  0 */
 	__ADD,
 	__DEL,
 	__SWITCH,
 	__SUSPEND,
-	__RESUME,
+	__RESUME,			/*  5 */
 	__REINSTATE,
 	__FAIL,
 	__RESIZE,
 	__RESET,
-	__RELOAD,
+	__RELOAD,			/* 10 */
 	__FORCEQ,
 	__DISABLEQ,
 	__RESTOREQ,
 	__PATHS,
-	__MAPS,
+	__MAPS,			/* 15 */
 	__PATH,
 	__MAP,
 	__GROUP,
 	__RECONFIGURE,
-	__DAEMON,
+	__DAEMON,			/* 20 */
 	__STATUS,
 	__STATS,
 	__TOPOLOGY,
 	__CONFIG,
-	__BLACKLIST,
+	__BLACKLIST,			/* 25 */
 	__DEVICES,
 	__RAW,
 	__WILDCARDS,
 	__QUIT,
-	__SHUTDOWN,
+	__SHUTDOWN,			/* 30 */
 	__GETPRSTATUS,
 	__SETPRSTATUS,
 	__UNSETPRSTATUS,
 	__FMT,
-	__JSON,
+	__JSON,			/* 35 */
 	__GETPRKEY,
 	__SETPRKEY,
 	__UNSETPRKEY,
 	__KEY,
-	__LOCAL,
+	__LOCAL,			/* 40 */
 	__SETMARGINAL,
 	__UNSETMARGINAL,
 };
 
-#define LIST		(1 << __LIST)
-#define ADD		(1 << __ADD)
-#define DEL		(1 << __DEL)
-#define SWITCH		(1 << __SWITCH)
-#define SUSPEND		(1 << __SUSPEND)
-#define RESUME		(1 << __RESUME)
-#define REINSTATE	(1 << __REINSTATE)
-#define FAIL		(1 << __FAIL)
-#define RESIZE		(1 << __RESIZE)
-#define RESET		(1 << __RESET)
-#define RELOAD		(1 << __RELOAD)
-#define FORCEQ		(1 << __FORCEQ)
-#define DISABLEQ	(1 << __DISABLEQ)
-#define RESTOREQ	(1 << __RESTOREQ)
-#define PATHS		(1 << __PATHS)
-#define MAPS		(1 << __MAPS)
-#define PATH		(1 << __PATH)
-#define MAP		(1 << __MAP)
-#define GROUP		(1 << __GROUP)
-#define RECONFIGURE	(1 << __RECONFIGURE)
-#define DAEMON		(1 << __DAEMON)
-#define STATUS		(1 << __STATUS)
-#define STATS		(1 << __STATS)
-#define TOPOLOGY	(1 << __TOPOLOGY)
-#define CONFIG		(1 << __CONFIG)
-#define BLACKLIST	(1 << __BLACKLIST)
-#define DEVICES		(1 << __DEVICES)
-#define RAW		(1 << __RAW)
-#define COUNT		(1 << __COUNT)
-#define WILDCARDS	(1 << __WILDCARDS)
-#define QUIT		(1 << __QUIT)
-#define SHUTDOWN	(1 << __SHUTDOWN)
+#define LIST		(1ULL << __LIST)
+#define ADD		(1ULL << __ADD)
+#define DEL		(1ULL << __DEL)
+#define SWITCH		(1ULL << __SWITCH)
+#define SUSPEND	(1ULL << __SUSPEND)
+#define RESUME		(1ULL << __RESUME)
+#define REINSTATE	(1ULL << __REINSTATE)
+#define FAIL		(1ULL << __FAIL)
+#define RESIZE		(1ULL << __RESIZE)
+#define RESET		(1ULL << __RESET)
+#define RELOAD		(1ULL << __RELOAD)
+#define FORCEQ		(1ULL << __FORCEQ)
+#define DISABLEQ	(1ULL << __DISABLEQ)
+#define RESTOREQ	(1ULL << __RESTOREQ)
+#define PATHS		(1ULL << __PATHS)
+#define MAPS		(1ULL << __MAPS)
+#define PATH		(1ULL << __PATH)
+#define MAP		(1ULL << __MAP)
+#define GROUP		(1ULL << __GROUP)
+#define RECONFIGURE	(1ULL << __RECONFIGURE)
+#define DAEMON		(1ULL << __DAEMON)
+#define STATUS		(1ULL << __STATUS)
+#define STATS		(1ULL << __STATS)
+#define TOPOLOGY	(1ULL << __TOPOLOGY)
+#define CONFIG		(1ULL << __CONFIG)
+#define BLACKLIST	(1ULL << __BLACKLIST)
+#define DEVICES	(1ULL << __DEVICES)
+#define RAW		(1ULL << __RAW)
+#define COUNT		(1ULL << __COUNT)
+#define WILDCARDS	(1ULL << __WILDCARDS)
+#define QUIT		(1ULL << __QUIT)
+#define SHUTDOWN	(1ULL << __SHUTDOWN)
 #define GETPRSTATUS	(1ULL << __GETPRSTATUS)
 #define SETPRSTATUS	(1ULL << __SETPRSTATUS)
 #define UNSETPRSTATUS	(1ULL << __UNSETPRSTATUS)
-- 
2.33.1


--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  parent reply	other threads:[~2021-11-27 15:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-27 15:18 [dm-devel] [PATCH v3 00/35] multipathd: uxlsnr overhaul mwilck
2021-11-27 15:18 ` [dm-devel] [PATCH v3 01/35] libmultipath: add timespeccmp() utility function mwilck
2021-11-27 15:18 ` [dm-devel] [PATCH v3 02/35] libmultipath: add trylock() helper mwilck
2021-11-27 15:18 ` [dm-devel] [PATCH v3 03/35] libmultipath: add optional wakeup functionality to lock.c mwilck
2021-11-27 15:18 ` [dm-devel] [PATCH v3 04/35] libmultipath: print: add __snprint_config() mwilck
2021-11-27 15:18 ` [dm-devel] [PATCH v3 05/35] libmultipath: improve cleanup of uevent queues on exit mwilck
2021-11-27 15:18 ` [dm-devel] [PATCH v3 06/35] multipathd: fix systemd notification when stopping while reloading mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 07/35] multipathd: improve delayed reconfigure mwilck
2021-11-27 15:19 ` mwilck [this message]
2021-11-27 15:19 ` [dm-devel] [PATCH v3 09/35] multipathd: cli_del_map: fix reply for delayed action mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 10/35] multipathd: add prototype for cli_handler functions mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 11/35] multipathd: make all cli_handlers static mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 12/35] multipathd: add and set cli_handlers in a single step mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 13/35] multipathd: cli.c: use ESRCH for "command not found" mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 14/35] multipathd: uxlsnr: avoid stalled clients during reconfigure mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 15/35] multipathd: uxlsnr: handle client HUP mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 16/35] multipathd: uxlsnr: use symbolic values for pollfd indices mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 17/35] multipathd: uxlsnr: avoid using fd -1 in ppoll() mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 18/35] multipathd: uxlsnr: data structure for stateful client connection mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 19/35] multipathd: move uxsock_trigger() to uxlsnr.c mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 20/35] multipathd: move parse_cmd() " mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 21/35] multipathd: uxlsnr: remove check_timeout() mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 22/35] multipathd: uxlsnr: move client handling to separate function mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 23/35] multipathd: uxlsnr: use main poll loop for receiving mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 24/35] multipathd: use strbuf in cli_handler functions mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 25/35] multipathd: uxlsnr: check root on connection startup mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 26/35] multipathd: uxlsnr: pass struct client to uxsock_trigger() and parse_cmd() mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 27/35] multipathd: uxlsnr: move handler execution to separate function mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 28/35] multipathd: uxlsnr: use parser to determine non-root commands mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 29/35] multipathd: uxlsnr: merge uxsock_trigger() into state machine mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 30/35] multipathd: uxlsnr: add idle notification mwilck
2021-11-29 20:16   ` Benjamin Marzinski
2021-11-27 15:19 ` [dm-devel] [PATCH v3 31/35] multipathd: uxlsnr: add timeout handling mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 31/35] rmultipathd: " mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 32/35] multipathd: uxlsnr: use poll loop for sending, too mwilck
2021-11-29 20:29   ` Benjamin Marzinski
2021-11-29 20:57     ` Martin Wilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 33/35] multipathd: uxlsnr: drop client_lock mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 34/35] multipathd: uxclt: allow client mode for non-root, too mwilck
2021-11-27 15:19 ` [dm-devel] [PATCH v3 35/35] multipathd: uxlsnr: use recv() for command length mwilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211127151929.7727-9-mwilck@suse.com \
    --to=mwilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    --cc=lixiaokeng@huawei.com \
    --cc=wu.chongyun@h3c.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.