From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D207EC433F5 for ; Mon, 29 Nov 2021 12:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MJKivpjBbCzHjEPvsxk7U3H5MbGqRM51waJKInyg0D4=; b=mIJkgZht3YeZEa NBKNmRiX0iiQpqJV9/BkWFCvMnWMYSF4TGNRiQoK2FX7qwQI2NQ1wzQ9MmTf6PaityD1HuRs+XBI5 BHpa8uPvEMQTGf9WzaYyd117AdS0QjUVtRTQC+63QSarDyDayBqf9gkuHjIMQVtDoFSqOoOh5TFgz peo5Ur/jN0LtvTMDnSS7xAF53qjTPPe85el5xqxZmmTMtgBaZreKE19Bnj21OssY7X4pHm/XaUszC PAN+zPmzbJ1R7UBI58J6YOdQ2ulQqV5P64RK6p7yGMNYjdjaGIqEf2b3kgZfIfIRGkM25L9u1W+Af w117UO59knIJEJEQdDfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrfqL-000i6M-Hm; Mon, 29 Nov 2021 12:33:13 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrfqI-000i5b-GQ for linux-arm-kernel@lists.infradead.org; Mon, 29 Nov 2021 12:33:11 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AT8k0St028222; Mon, 29 Nov 2021 13:33:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=sjSsap/99PK+qLLv6/E8NRXNL95MRU5g3ZSQAhekza0=; b=GVk4/HLmeJqSpE3xH1R0B0CVFAONWg4SFcg5KUIIDuVXL8WgimzpPYDSeeW8H5rDomdH xnK0cj1kr5QgNxUYjQGb845llErAqtrjUrI0dwzG5eO0j0rycsgNboU4IVlcWjjZQhzm BlkzIymn1fDb+LoT2UhhE32MLvOaJ9ku6dYc2ApOxeGJUmwvXnlOUQL48AjAoUXFrYNk ol7HvGG88HZ90YaKw30xUsw+RC+ui2/lIU06+y+4vFo16izDffSVIHF548H6xyTVaJQk 36LCuHTthigq0UbJxySk4JGELygB0fM46lqI2/2+pjzqXgqVgDHBSY55Y6Yh/7PziN5P 3A== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3cmnj9k46c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Nov 2021 13:33:04 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0056610002A; Mon, 29 Nov 2021 13:33:03 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id E88B6215130; Mon, 29 Nov 2021 13:33:03 +0100 (CET) Received: from gnbcxd0016.gnb.st.com (10.75.127.44) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Mon, 29 Nov 2021 13:33:03 +0100 Date: Mon, 29 Nov 2021 13:33:02 +0100 From: Alain Volmat To: Wolfram Sang , , , , , , , , Subject: Re: [PATCH 2/4] i2c: stm32f7: recover the bus on access timeout Message-ID: <20211129123302.GB486850@gnbcxd0016.gnb.st.com> Mail-Followup-To: Wolfram Sang , pierre-yves.mordret@foss.st.com, alexandre.torgue@foss.st.com, linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@foss.st.com, amelie.delaunay@foss.st.com References: <1632151292-18503-1-git-send-email-alain.volmat@foss.st.com> <1632151292-18503-3-git-send-email-alain.volmat@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-29_07,2021-11-28_01,2020-04-07_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_043310_865226_F0F0EA0C X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Wolfram On Mon, Nov 29, 2021 at 01:17:21PM +0100, Wolfram Sang wrote: > > > + stm32f7_i2c_wait_free_bus(i2c_dev); > > This does only a controller reset, not a bus recovery with 9 toggling > pulses, or? indeed. I might better rework this and at the same time introduce the bus recovery mechanism via the bus recovery callback in this driver. Please don't merge this patch and I will rework that. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB097C433EF for ; Mon, 29 Nov 2021 12:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244644AbhK2Mik (ORCPT ); Mon, 29 Nov 2021 07:38:40 -0500 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:41492 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243882AbhK2Mgb (ORCPT ); Mon, 29 Nov 2021 07:36:31 -0500 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AT8k0St028222; Mon, 29 Nov 2021 13:33:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=sjSsap/99PK+qLLv6/E8NRXNL95MRU5g3ZSQAhekza0=; b=GVk4/HLmeJqSpE3xH1R0B0CVFAONWg4SFcg5KUIIDuVXL8WgimzpPYDSeeW8H5rDomdH xnK0cj1kr5QgNxUYjQGb845llErAqtrjUrI0dwzG5eO0j0rycsgNboU4IVlcWjjZQhzm BlkzIymn1fDb+LoT2UhhE32MLvOaJ9ku6dYc2ApOxeGJUmwvXnlOUQL48AjAoUXFrYNk ol7HvGG88HZ90YaKw30xUsw+RC+ui2/lIU06+y+4vFo16izDffSVIHF548H6xyTVaJQk 36LCuHTthigq0UbJxySk4JGELygB0fM46lqI2/2+pjzqXgqVgDHBSY55Y6Yh/7PziN5P 3A== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3cmnj9k46c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Nov 2021 13:33:04 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0056610002A; Mon, 29 Nov 2021 13:33:03 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id E88B6215130; Mon, 29 Nov 2021 13:33:03 +0100 (CET) Received: from gnbcxd0016.gnb.st.com (10.75.127.44) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Mon, 29 Nov 2021 13:33:03 +0100 Date: Mon, 29 Nov 2021 13:33:02 +0100 From: Alain Volmat To: Wolfram Sang , , , , , , , , Subject: Re: [PATCH 2/4] i2c: stm32f7: recover the bus on access timeout Message-ID: <20211129123302.GB486850@gnbcxd0016.gnb.st.com> Mail-Followup-To: Wolfram Sang , pierre-yves.mordret@foss.st.com, alexandre.torgue@foss.st.com, linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@foss.st.com, amelie.delaunay@foss.st.com References: <1632151292-18503-1-git-send-email-alain.volmat@foss.st.com> <1632151292-18503-3-git-send-email-alain.volmat@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-29_07,2021-11-28_01,2020-04-07_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram On Mon, Nov 29, 2021 at 01:17:21PM +0100, Wolfram Sang wrote: > > > + stm32f7_i2c_wait_free_bus(i2c_dev); > > This does only a controller reset, not a bus recovery with 9 toggling > pulses, or? indeed. I might better rework this and at the same time introduce the bus recovery mechanism via the bus recovery callback in this driver. Please don't merge this patch and I will rework that.