All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Seth Forshee <sforshee@digitalocean.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 08/10] fs: port higher-level mapping helpers
Date: Tue, 30 Nov 2021 09:52:10 +0100	[thread overview]
Message-ID: <20211130085210.rqs5vkeuoo7g2bwo@wittgenstein> (raw)
In-Reply-To: <CAOQ4uxhWj_o0WFUpJn7d-YXpT_dTNFWBPzetb13N8LkyMywbDA@mail.gmail.com>

On Tue, Nov 30, 2021 at 09:15:35AM +0200, Amir Goldstein wrote:
> On Tue, Nov 23, 2021 at 3:29 PM Christian Brauner <brauner@kernel.org> wrote:
> >
> > From: Christian Brauner <christian.brauner@ubuntu.com>
> >
> > Enable the mapped_fs{g,u}id() helpers to support filesystems mounted
> > with an idmapping. Apart from core mapping helpers that use
> > mapped_fs{g,u}id() to initialize struct inode's i_{g,u}id fields xfs is
> > the only place that uses these low-level helpers directly.
> >
> > The patch only extends the helpers to be able to take the filesystem
> > idmapping into account. Since we don't actually yet pass the
> > filesystem's idmapping in no functional changes happen. This will happen
> > in a final patch.
> >
> > Cc: Seth Forshee <sforshee@digitalocean.com>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > CC: linux-fsdevel@vger.kernel.org
> > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> > ---
> >  fs/xfs/xfs_inode.c          | 10 ++++++----
> >  fs/xfs/xfs_symlink.c        |  5 +++--
> >  include/linux/fs.h          |  8 ++++----
> >  include/linux/mnt_mapping.h | 12 ++++++++----
> >  4 files changed, 21 insertions(+), 14 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> > index 64b9bf334806..7ac8247b5498 100644
> > --- a/fs/xfs/xfs_inode.c
> > +++ b/fs/xfs/xfs_inode.c
> > @@ -977,6 +977,7 @@ xfs_create(
> >         struct xfs_trans_res    *tres;
> >         uint                    resblks;
> >         xfs_ino_t               ino;
> > +       struct user_namespace   *fs_userns = &init_user_ns;
> >
> >         trace_xfs_create(dp, name);
> >
> > @@ -988,8 +989,8 @@ xfs_create(
> >         /*
> >          * Make sure that we have allocated dquot(s) on disk.
> >          */
> > -       error = xfs_qm_vop_dqalloc(dp, mapped_fsuid(mnt_userns),
> > -                       mapped_fsgid(mnt_userns), prid,
> > +       error = xfs_qm_vop_dqalloc(dp, mapped_fsuid(mnt_userns, fs_userns),
> > +                       mapped_fsgid(mnt_userns, fs_userns), prid,
> 
> I am confused.
> Do we intend to enable idmapped xfs sb?

No, I don't think we need to given that we have idmapped mount support.
I'm happy to just continue passing down the initial idmapping.


> If the answer is yes, then feel free to add:
> 
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> 
> I did a quick review pass of all the patches.
> The ones I did not reply to I felt I needed to take a close look
> so will continue with the review later.

Thank you, appreciate it!

Christian

  reply	other threads:[~2021-11-30  8:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 11:42 [PATCH 00/10] Extend and tweak mapping support Christian Brauner
2021-11-23 11:42 ` [PATCH 01/10] fs: add is_mapped_mnt() helper Christian Brauner
2021-11-30  6:25   ` Amir Goldstein
2021-11-30  8:48     ` Christian Brauner
2021-11-23 11:42 ` [PATCH 02/10] fs: move mapping helpers Christian Brauner
2021-11-30  6:35   ` Amir Goldstein
2021-11-30  8:53     ` Christian Brauner
2021-11-23 11:42 ` [PATCH 03/10] fs: tweak fsuidgid_has_mapping() Christian Brauner
2021-11-30  6:44   ` Amir Goldstein
2021-11-23 11:42 ` [PATCH 04/10] fs: account for filesystem mappings Christian Brauner
2021-11-23 11:42 ` [PATCH 05/10] docs: update mapping documentation Christian Brauner
2021-11-23 11:42 ` [PATCH 06/10] fs: use low-level mapping helpers Christian Brauner
2021-11-23 11:42 ` [PATCH 07/10] fs: remove unused " Christian Brauner
2021-11-30  6:53   ` Amir Goldstein
2021-11-23 11:42 ` [PATCH 08/10] fs: port higher-level " Christian Brauner
2021-11-30  7:15   ` Amir Goldstein
2021-11-30  8:52     ` Christian Brauner [this message]
2021-11-23 11:42 ` [PATCH 09/10] fs: add i_user_ns() helper Christian Brauner
2021-11-30  7:02   ` Amir Goldstein
2021-11-23 11:42 ` [PATCH 10/10] fs: support mapped mounts of mapped filesystems Christian Brauner
2021-11-29 10:36 ` [PATCH 00/10] Extend and tweak mapping support Christian Brauner
2021-11-30  5:51 ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211130085210.rqs5vkeuoo7g2bwo@wittgenstein \
    --to=christian.brauner@ubuntu.com \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sforshee@digitalocean.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.