From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF4A3C433F5 for ; Tue, 30 Nov 2021 14:27:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242159AbhK3Oar (ORCPT ); Tue, 30 Nov 2021 09:30:47 -0500 Received: from smtp.220.in.ua ([89.184.67.205]:51681 "EHLO smtp.220.in.ua" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237590AbhK3Oaq (ORCPT ); Tue, 30 Nov 2021 09:30:46 -0500 Received: from oleh-pc.lan (unknown [95.67.115.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.220.in.ua (Postfix) with ESMTPSA id B374B1A20D5B; Tue, 30 Nov 2021 16:27:24 +0200 (EET) From: Oleh Kravchenko To: Avri Altman , Chris Ball , Ulf Hansson , linux-mmc@vger.kernel.org, patchwork-bot@kernel.org Cc: Oleh Kravchenko , Bean Huo Subject: [PATCH v5] mmc-utils: Use printf() to extract and print fw version Date: Tue, 30 Nov 2021 16:27:15 +0200 Message-Id: <20211130142715.11014-1-oleg@kaa.org.ua> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211116105109.3830-1-oleg@kaa.org.ua> References: <20211116105109.3830-1-oleg@kaa.org.ua> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org This patch also fixes a compile error with a newer version of GCC: error: '__builtin_strncpy' output may be truncated copying 8 bytes from a string of length 511 [-Werror=stringop-truncation] Signed-off-by: Oleh Kravchenko Reviewed-by: Bean Huo Fixes: 0eea71e4f22a (mmc-utils: Fix for Firmware Version string printing) --- mmc_cmds.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) PATCH v5 Updating commit message. Adding Fixes: 0eea71e4f22a diff --git a/mmc_cmds.c b/mmc_cmds.c index 73bd32a..e07ec94 100644 --- a/mmc_cmds.c +++ b/mmc_cmds.c @@ -1392,7 +1392,6 @@ int do_read_extcsd(int nargs, char **argv) __u32 regl; int fd, ret; char *device; - char lbuf[10]; const char *str; if (nargs != 2) { @@ -1834,9 +1833,7 @@ int do_read_extcsd(int nargs, char **argv) } if (ext_csd_rev >= 7) { - memset(lbuf, 0, sizeof(lbuf)); - strncpy(lbuf, (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION], 8); - printf("eMMC Firmware Version: %s\n", lbuf); + printf("eMMC Firmware Version: %.8s\n", (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION]); printf("eMMC Life Time Estimation A [EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]: 0x%02x\n", ext_csd[EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]); printf("eMMC Life Time Estimation B [EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_B]: 0x%02x\n", -- 2.32.0