From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36FC9C433EF for ; Tue, 30 Nov 2021 16:51:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244521AbhK3QyX (ORCPT ); Tue, 30 Nov 2021 11:54:23 -0500 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:54848 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244587AbhK3QyJ (ORCPT ); Tue, 30 Nov 2021 11:54:09 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 4J3Ss43TbKz9vjJh for ; Tue, 30 Nov 2021 16:50:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e4JqsIJg3qxp for ; Tue, 30 Nov 2021 10:50:48 -0600 (CST) Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 4J3Ss41Nppz9vjJg for ; Tue, 30 Nov 2021 10:50:48 -0600 (CST) DMARC-Filter: OpenDMARC Filter v1.3.2 mta-p8.oit.umn.edu 4J3Ss41Nppz9vjJg DKIM-Filter: OpenDKIM Filter v2.11.0 mta-p8.oit.umn.edu 4J3Ss41Nppz9vjJg Received: by mail-pj1-f72.google.com with SMTP id t7-20020a17090a5d8700b001a7604b85f5so7079273pji.8 for ; Tue, 30 Nov 2021 08:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W4lvCUBRSibHXkkFm5Ye1P7mrNgQ0tt0c7dI8z7Afww=; b=Dlmdt+ElX1hlkn6am6/1pELOrapSy/t1WY9DyPuGdNODNSWoBFeg6Wg4xITA/iEoa+ j4UCUIK35xCdxg9kcWVBrMZ3+D4yib/Xz7aoYtZMWLfhcRurW28K6O3Dc1uEawwx2xWb UnRdDxZH0zR+RiLuPciO9KahoCMNO39X6DAX2bYzqXBGqfzCQrInM9FySrJV/5bIGuhy IP/zUAahOdVn7DuG4f+p5FQdh2XxsfHaNFMhPV5eeV7gilXCqx7yGBAnRoRVH5Jm8GTm OrCgXUSdH8kmb9uySd9GtUchctxqAVqYacwvcBpMg490GB/Pd2dtNfnunRAibwGRPe+w 70uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W4lvCUBRSibHXkkFm5Ye1P7mrNgQ0tt0c7dI8z7Afww=; b=59vvJubqlxlhgdrvDZJxFlL8rUwEzlJGUJd2HEx8Gm6xn/CvvUDUMOxB6NWZNQ/OsO I2tgeFKcNsNFDqI7W/1QsCf7IL72n+P4GojpxnUdl/KOY8PvMff5PyZ53iQbpPAg/KIF 5gPawWb7lr2j9F2IzWeEkYuCLrzE6c8HOp3Rin5bTuM47/KODZ51hxvVkEPkzI93CXZx e/AHn2wFR3rsSDAIc3ce4v05hTorv6Q7u9EKP6YrsqND+FCgD+i3hi60iP1+b9B5452N Lk7sB9B4ZTrMJOFUZDHwT7WjYX5qO6yirjnK9wKobsYGuv/X1v3zx2cb0/wJIUQsmYzD uI7Q== X-Gm-Message-State: AOAM5304gVaeiZouqgo9me1fr8eGfKjKK7awmOuymNsvOOlTTmM/vDbc 73Vc4GPhWBQSsSg4DkEFimTMVLvsnUot4k9BbHpqnxCtK7O/YTXJ6/hy+Sqdlt3G2tQ5Psnfh3e LmcZ/iMGxem2VTs+7w6KuEYUzDF4Q X-Received: by 2002:a63:d848:: with SMTP id k8mr219749pgj.467.1638291047477; Tue, 30 Nov 2021 08:50:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJzUoLI32LU8MqKKgo7LZRAezZSN58Vg9+5tPg/RV3rRdVJexTB/R0GhOJHYcIY2IKHynr7WlQ== X-Received: by 2002:a63:d848:: with SMTP id k8mr219736pgj.467.1638291047279; Tue, 30 Nov 2021 08:50:47 -0800 (PST) Received: from zqy787-GE5S.lan ([36.7.42.137]) by smtp.gmail.com with ESMTPSA id y4sm22832295pfi.178.2021.11.30.08.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:50:47 -0800 (PST) From: Zhou Qingyang To: zhou1615@umn.edu Cc: kjlu@umn.edu, Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] octeontx2-af: Fix a memleak bug in rvu_mbox_init() Date: Wed, 1 Dec 2021 00:50:39 +0800 Message-Id: <20211130165039.192426-1-zhou1615@umn.edu> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In rvu_mbox_init(), mbox_regions is not freed or passed out under the switch-default region, which could lead to a memory leak. Fix this bug by changing 'return err' to 'goto free_regions'. This bug was found by a static analyzer. The analysis employs differential checking to identify inconsistent security operations (e.g., checks or kfrees) between two code paths and confirms that the inconsistent operations are not recovered in the current function or the callers, so they constitute bugs. Note that, as a bug found by static analysis, it can be a false positive or hard to trigger. Multiple researchers have cross-reviewed the bug. Builds with CONFIG_OCTEONTX2_AF=y show no new warnings, and our static analyzer no longer warns about this code. Fixes: 98c561116360 (“octeontx2-af: cn10k: Add mbox support for CN10K platform”) Signed-off-by: Zhou Qingyang --- drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c index cb56e171ddd4..3ca6b942ebe2 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c @@ -2341,7 +2341,7 @@ static int rvu_mbox_init(struct rvu *rvu, struct mbox_wq_info *mw, goto free_regions; break; default: - return err; + goto free_regions; } mw->mbox_wq = alloc_workqueue(name, -- 2.25.1