From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44F16C433EF for ; Tue, 30 Nov 2021 18:47:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9531183081; Tue, 30 Nov 2021 19:47:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="JZii2t0s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7B7238308A; Tue, 30 Nov 2021 19:47:06 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EAC4B83081 for ; Tue, 30 Nov 2021 19:47:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id v22so21217153qtx.8 for ; Tue, 30 Nov 2021 10:47:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wzDsmFPMiCnPYNkINjEoRbXYIIcyZJKTkjf2FlG9K5Q=; b=JZii2t0s2TiMEZyzC6lomZsGNVS36keD5lacVqY//YKRJwsn+jDYx/sfafdQyX3Pwt Ca+NU3xG2CCD0BVpVazdOg1+25l1w3R78NP1AnqfqigNQ5XRqlBFSX2Tw3opgbw4nItE Y/AKhm35fPuu4eDDVVjC/y5fD4DWDYPu8RZ9g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wzDsmFPMiCnPYNkINjEoRbXYIIcyZJKTkjf2FlG9K5Q=; b=1gR7W+4blE5g6Uau0Qn2q/wm5oRdVWzyiyLZaD77EojVnjB9neJ8Gn69CE+HKj4fZo fo6G1JJCdBdx4+sR0omRbGlnXA7wMFBW/+xooCz1jFt9WiIuzh1Y6baC6MzLsK4QQ4Ov 88+dRdhmLqxaR6oZ11GiqgndLnTgvU3q+fJ/ErGWBcMpyiy9ZmY8ZATIBwbrmQOOC3L+ ExOBK2rK+O73Q9TrQ4fXCmxIaAifNqWD+wfveY2nBd8X1RZmUbg/yG9xMe3BMb+bkRE0 LGmVhIwONxhsEB3EMr7jAesLhuzhJv77hFQJehjZg19NuviUVQrw4pnntx51uIAAph+a sDsA== X-Gm-Message-State: AOAM5308YRsOuJuPfD+Q1jSDC2z94mMLg0Xoil39kDPT86wbOdZMh+dB F6dzvxI//AIntuHZuugKZ/pX5g== X-Google-Smtp-Source: ABdhPJwKUMXnfiZgMGEB4V8lMIwT/ZmVqOWiNgOXO8J80OR2mqNDNiLAYxT4sqS6ivCmMPSqPs+wWQ== X-Received: by 2002:a05:622a:c8:: with SMTP id p8mr1445703qtw.52.1638298021662; Tue, 30 Nov 2021 10:47:01 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-e478-4cc2-fb2f-8620.res6.spectrum.com. [2603:6081:7b01:cbda:e478:4cc2:fb2f:8620]) by smtp.gmail.com with ESMTPSA id 8sm11474605qtz.28.2021.11.30.10.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 10:47:01 -0800 (PST) Date: Tue, 30 Nov 2021 13:46:57 -0500 From: Tom Rini To: Peter Robinson Cc: Arnaud Ferraris , Martijn Braam , u-boot@lists.denx.de, ~postmarketos/upstreaming@lists.sr.ht, Andre Przywara , "Arnaud Patard (Rtp)" , Christian Hewitt , Fabio Estevam , Heiko Schocher , Hugh Cole-Baker , Jagan Teki , Kever Yang , Neil Armstrong , Philipp Tomsich , Philipp Tomsich , Rick Chen , Simon Glass , Tim Harvey Subject: Re: [PATCH] rockchip: Add initial support for the PinePhone Pro Message-ID: <20211130184657.GI24579@bill-the-cat> References: <20211021171843.6301-1-martijn@brixit.nl> <20211130173750.GD24579@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0rn8U4QAnNLiD0mS" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --0rn8U4QAnNLiD0mS Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 30, 2021 at 06:44:05PM +0000, Peter Robinson wrote: > On Tue, Nov 30, 2021 at 5:37 PM Tom Rini wrote: > > > > On Tue, Nov 30, 2021 at 05:47:25PM +0100, Arnaud Ferraris wrote: > > > Hi Martijn, > > > > > > Thanks for this patch! It looks good overall, but I have a few minor > > > comments regarding the defconfig, see below. > > > > > > Le 21/10/2021 =E0 19:18, Martijn Braam a =E9crit : > > > > This is a new device by PINE64 that's very similar to the Pinebook = Pro > > > > that's already supported. > > > > > > > > Specification: > > > > - Rockchip RK3399 > > > > - 4GB Dual-Channel LPDDR4 > > > > - 128GB eMMC > > > > - mSD card slot > > > > - AP6255 for 802.11ac WiFi and Bluetooth > > > > - 6 inch 720*1440 DSI display > > > > - Quectel EG25g usb modem > > > > - Type-C port with alt-mode display (DP 1.2) and PD charging. > > > > > > > > Signed-off-by: Martijn Braam > > > > --- > > > > > > > > arch/arm/dts/Makefile | 1 + > > > > arch/arm/dts/rk3399-pinephone-pro-u-boot.dtsi | 44 ++ > > > > arch/arm/dts/rk3399-pinephone-pro.dts | 520 ++++++++++++++= ++++ > > > > I missed the first iteration, sorry, so replying here. For v2 please > > note what kernel arch/arm/dts/rk3399-pinephone-pro.dts is a copy from, > > thanks! >=20 > I'm not sure it's even been posted upstream for review, I've certainly > not seen it. That's a red flag over here, it needs to be in linux-next or linux proper. --=20 Tom --0rn8U4QAnNLiD0mS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGmcZAACgkQFHw5/5Y0 tyyAogwAqUk2ukDuUE9QPkSmum6IF4EzYzZAB4kw2Ff1WwRVPV1bpKLz57FlFxcC dyl9Bt4ACG+S8oka8WpI+05N8Nr9Kj9XMppKJUkAgW56XWsZCFZ9t2mUwerq7spo dgyO7N+458/QKnG3d3t3mz4Bt1gLlddCRhXRV2h6jrLaBxwe7rsLmrmJOYyDGy9k E5MccffM1UPBeUdlYHoJzNZzcLTaydlebd835oO8PCn+Hii6aK+sASoN8uXGwuvE penMy2fHyYZl8zoQOoxxTkQO2OTnq/PQBxyzMShukmstq4WdYrARKKsN+jdHI6K6 EVJSrWU0hUjTWHzbyR6t526rpuaZ3kytRW3HS9OoCYebjARIihhLvgV8d7MfCgX7 3fEMxMyISsgIgpg8vzxOKCZIHWOpVy4VbdNk+ACxh0xHu9IaFeklFTmeT4J4EbnL Rj+G/u9GTF1Xqqsa4c/l4xpMULxuUnHnxQI3IkmVESG/BgS8sKuwlPYj3fNmhVJk E5DaCePt =mcg8 -----END PGP SIGNATURE----- --0rn8U4QAnNLiD0mS--