From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC43C433EF for ; Tue, 30 Nov 2021 18:56:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245662AbhK3S7U (ORCPT ); Tue, 30 Nov 2021 13:59:20 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:50298 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234268AbhK3S7U (ORCPT ); Tue, 30 Nov 2021 13:59:20 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 92F881C0BA8; Tue, 30 Nov 2021 19:55:59 +0100 (CET) Date: Tue, 30 Nov 2021 19:55:58 +0100 From: Pavel Machek To: Daniel Palmer Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/11] ARM: dts: mstar: unitv2: Wire up LEDs Message-ID: <20211130185558.GD30113@duo.ucw.cz> References: <20210923065500.2284347-1-daniel@0x0f.com> <20210923065500.2284347-8-daniel@0x0f.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jCrbxBqMcLqd4mOl" Content-Disposition: inline In-Reply-To: <20210923065500.2284347-8-daniel@0x0f.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --jCrbxBqMcLqd4mOl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Add the red and white leds present on the unitv2. Thanks for cc-ing me. > @@ -18,6 +20,18 @@ aliases { > chosen { > stdout-path =3D "serial0:115200n8"; > }; > + > + leds { > + compatible =3D "gpio-leds"; > + led-white { > + gpios =3D <&gpio SSD20XD_GPIO_GPIO0 GPIO_ACTIVE_LOW>; > + linux,default-trigger =3D "activity"; > + }; > + led-red { > + gpios =3D <&gpio SSD20XD_GPIO_GPIO1 GPIO_ACTIVE_LOW>; > + linux,default-trigger =3D "heartbeat"; > + }; > + }; How do these look in userspace (ls /sys/class/leds)? See Documentation/devicetree/bindings/leds/common.yaml . Should the first one be disk-activity? Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --jCrbxBqMcLqd4mOl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYaZzvgAKCRAw5/Bqldv6 8sZ8AJ998LOy4ySaPJQ+fkZxHdliuWUflwCgtsmz2w0+VZndz2PlVEy8Ie9cSrE= =Y2nW -----END PGP SIGNATURE----- --jCrbxBqMcLqd4mOl-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0E9FC433EF for ; Tue, 30 Nov 2021 18:57:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MkDbkKWVgeTEPCIjY1kTvRT1xhXhraLxzkrfyeNa3K4=; b=TQaDZ3DxlknFwXjKCN37um04pi ZyEditypFA/CZ8DPaGUzVQifR/bBm8PA0yOaY8EU3L3JXe8q+RA4WlmKfAsbB5iJ84dao8+1y3o+w mOLHlEe3Uo5z3VFDDz89KoShb7n+zOqvX2wdwYKW5j5kUOHufq72mQOVOjXkNzny1BiXfcTpR/P18 Dnzi9PS3WH+96n2cUp986/nHEHab++ni5gMh9YYXM7EaQZvbGsHMa4ykdrjNdthryXKbFCVcojVfu iyAOOGkwzTbUk05+mLLKhcO8x8KeJa5Vi+sy5VMz1+jwUuyxwYeeYi2m3ldQS8h2vLCZvO4RZ8CQf dm1A2yeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms8IU-006Xe7-Jy; Tue, 30 Nov 2021 18:56:10 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms8IQ-006Xcn-3c for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 18:56:08 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 92F881C0BA8; Tue, 30 Nov 2021 19:55:59 +0100 (CET) Date: Tue, 30 Nov 2021 19:55:58 +0100 From: Pavel Machek To: Daniel Palmer Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/11] ARM: dts: mstar: unitv2: Wire up LEDs Message-ID: <20211130185558.GD30113@duo.ucw.cz> References: <20210923065500.2284347-1-daniel@0x0f.com> <20210923065500.2284347-8-daniel@0x0f.com> MIME-Version: 1.0 In-Reply-To: <20210923065500.2284347-8-daniel@0x0f.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_105606_309004_3990FD16 X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1615805641780721255==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1615805641780721255== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jCrbxBqMcLqd4mOl" Content-Disposition: inline --jCrbxBqMcLqd4mOl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Add the red and white leds present on the unitv2. Thanks for cc-ing me. > @@ -18,6 +20,18 @@ aliases { > chosen { > stdout-path =3D "serial0:115200n8"; > }; > + > + leds { > + compatible =3D "gpio-leds"; > + led-white { > + gpios =3D <&gpio SSD20XD_GPIO_GPIO0 GPIO_ACTIVE_LOW>; > + linux,default-trigger =3D "activity"; > + }; > + led-red { > + gpios =3D <&gpio SSD20XD_GPIO_GPIO1 GPIO_ACTIVE_LOW>; > + linux,default-trigger =3D "heartbeat"; > + }; > + }; How do these look in userspace (ls /sys/class/leds)? See Documentation/devicetree/bindings/leds/common.yaml . Should the first one be disk-activity? Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --jCrbxBqMcLqd4mOl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYaZzvgAKCRAw5/Bqldv6 8sZ8AJ998LOy4ySaPJQ+fkZxHdliuWUflwCgtsmz2w0+VZndz2PlVEy8Ie9cSrE= =Y2nW -----END PGP SIGNATURE----- --jCrbxBqMcLqd4mOl-- --===============1615805641780721255== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1615805641780721255==--