Re: [PATCH v11 3/6] gpio: sim: new testing module

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v11 3/6] gpio: sim: new testing module
Date: Wed, 01 Dec 2021 10:55:56 +0800	[thread overview]
Message-ID: <202112011018.3gANFz4h-lkp@intel.com> (raw)
In-Reply-To: <20211130154127.12272-4-brgl@bgdev.pl>

[-- Attachment #1: Type: text/plain, Size: 3155 bytes --]

Hi Bartosz,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v5.16-rc3]
[cannot apply to shuah-kselftest/next linusw-gpio/for-next next-20211130]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bartosz-Golaszewski/gpio-sim-configfs-based-GPIO-simulator/20211130-234338
base:    d58071a8a76d779eedab38033ae4c821c30295a5
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20211201/202112011018.3gANFz4h-lkp(a)intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1e50c35dae10799b1e2bbed56f68cfbac59bea08
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bartosz-Golaszewski/gpio-sim-configfs-based-GPIO-simulator/20211130-234338
        git checkout 1e50c35dae10799b1e2bbed56f68cfbac59bea08
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/ security//

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpio/gpio-sim.c:807:23: warning: no previous prototype for 'gpio_sim_make_bank_swnode' [-Wmissing-prototypes]
     807 | struct fwnode_handle *gpio_sim_make_bank_swnode(struct gpio_sim_bank *bank,
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +/gpio_sim_make_bank_swnode +807 drivers/gpio/gpio-sim.c

   806	
 > 807	struct fwnode_handle *gpio_sim_make_bank_swnode(struct gpio_sim_bank *bank,
   808							struct fwnode_handle *parent)
   809	{
   810		struct property_entry properties[GPIO_SIM_PROP_MAX];
   811		unsigned int prop_idx = 0, line_names_size = 0;
   812		struct fwnode_handle *swnode;
   813		char **line_names;
   814	
   815		memset(properties, 0, sizeof(properties));
   816	
   817		properties[prop_idx++] = PROPERTY_ENTRY_U32("ngpios", bank->num_lines);
   818	
   819		if (bank->label)
   820			properties[prop_idx++] = PROPERTY_ENTRY_STRING("gpio-sim,label",
   821								       bank->label);
   822	
   823		line_names = gpio_sim_make_line_names(bank, &line_names_size);
   824		if (IS_ERR(line_names))
   825			return ERR_CAST(line_names);
   826	
   827		if (line_names)
   828			properties[prop_idx++] = PROPERTY_ENTRY_STRING_ARRAY_LEN(
   829							"gpio-line-names",
   830							line_names, line_names_size);
   831	
   832		swnode = fwnode_create_software_node(properties, parent);
   833		kfree(line_names);
   834		return swnode;
   835	}
   836	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org