From: mwilck@suse.com
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [dm-devel] [PATCH v2 00/21] multipath-tools: coverity fixes
Date: Wed, 1 Dec 2021 13:36:29 +0100 [thread overview]
Message-ID: <20211201123650.16240-1-mwilck@suse.com> (raw)
From: Martin Wilck <mwilck@suse.com>
Hi Christophe, hi Ben,
I have started a new attempt to fix defects reported by coverity.
With this set (on top of the previously posted one), and a number
of false positive classifications, I have been able to bring the
defect count all the way down to zero.
Most of these patches fix defects reported by coverity. Some
fix other things that occured to me while working on this.
Changes v1 -> v2 (Ben Marzinski)
- all: rebased to current "queue" branch
- 05/21: If a broken designator is encountered in VPD 83, don't
error out but try to go on as long as the designator is within
limits of the VPD page
- 06/21: adapt tests to the changes in 05/21, add some more
(note: dropped Ben's "Reviewed-by:" on this one)
- 08/21: reworked to take Ben's remarks into account
I didn't change 07/21 (see previous discussion).
Regards,
Martin
Martin Wilck (21):
multipath tools: github workflows: add coverity workflow
multipathd (coverity): check atexit() return value
multipathd (coverity): terminate uxlsnr when polls allocation fails
libmultipath: strbuf: add __get_strbuf_buf()
libmultipath (coverity): improve input checking in parse_vpd_pg83
multipath-tools: add tests for broken VPD page 83
libmultipath: use strbuf in parse_vpd_pg83()
libmultipath (coverity): fix tainted values in alua_rtpg.c
multipath, multipathd: exit if bindings file is broken
libmultipath (coverity): silence unchecked return value warning
multipath: remove pointless code from getopt processing
libmultipath (coverity): set umask before mkstemp
multipathd (coverity): simplify set_oom_adj()
kpartx: open /dev/loop-control only once
kpartx: use opened loop device immediately
kpartx: find_unused_loop_device(): add newlines
multipathd (coverity): daemonize(): use dup2
libmultipath (coverity): avoid sleeping in dm_mapname()
libmultipath (coverity): Revert "setup_map: wait for pending path
checkers to finish"
libmultipath (coverity): check return values in dm_get_multipath()
libmultipath: update_pathvec_from_dm: don't force DI_WWID
.github/workflows/coverity.yaml | 51 ++++++
kpartx/kpartx.c | 4 +-
kpartx/lopart.c | 100 +++++------
kpartx/lopart.h | 3 +-
libmultipath/alias.c | 4 +
libmultipath/configure.c | 63 +------
libmultipath/devmapper.c | 23 +--
libmultipath/discovery.c | 245 ++++++++++++++------------
libmultipath/prioritizers/alua_rtpg.c | 13 +-
libmultipath/prioritizers/alua_spc3.h | 43 ++++-
libmultipath/propsel.c | 2 +-
libmultipath/strbuf.c | 5 +
libmultipath/strbuf.h | 14 ++
libmultipath/structs_vec.c | 7 +-
multipath/main.c | 13 +-
multipathd/main.c | 91 +++++-----
multipathd/uxlsnr.c | 1 +
tests/vpd.c | 144 ++++++++++++++-
18 files changed, 500 insertions(+), 326 deletions(-)
create mode 100644 .github/workflows/coverity.yaml
--
2.33.1
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next reply other threads:[~2021-12-01 12:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 12:36 mwilck [this message]
2021-12-01 12:36 ` [dm-devel] [PATCH v2 01/21] multipath tools: github workflows: add coverity workflow mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 02/21] multipathd (coverity): check atexit() return value mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 03/21] multipathd (coverity): terminate uxlsnr when polls allocation fails mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 04/21] libmultipath: strbuf: add __get_strbuf_buf() mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 05/21] libmultipath (coverity): improve input checking in parse_vpd_pg83 mwilck
2021-12-01 18:35 ` Benjamin Marzinski
2021-12-01 12:36 ` [dm-devel] [PATCH v2 06/21] multipath-tools: add tests for broken VPD page 83 mwilck
2021-12-01 18:37 ` Benjamin Marzinski
2021-12-01 12:36 ` [dm-devel] [PATCH v2 07/21] libmultipath: use strbuf in parse_vpd_pg83() mwilck
2021-12-01 18:36 ` Benjamin Marzinski
2021-12-01 12:36 ` [dm-devel] [PATCH v2 08/21] libmultipath (coverity): fix tainted values in alua_rtpg.c mwilck
2021-12-01 19:08 ` Benjamin Marzinski
2021-12-01 12:36 ` [dm-devel] [PATCH v2 09/21] multipath, multipathd: exit if bindings file is broken mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 10/21] libmultipath (coverity): silence unchecked return value warning mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 11/21] multipath: remove pointless code from getopt processing mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 12/21] libmultipath (coverity): set umask before mkstemp mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 13/21] multipathd (coverity): simplify set_oom_adj() mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 14/21] kpartx: open /dev/loop-control only once mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 15/21] kpartx: use opened loop device immediately mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 16/21] kpartx: find_unused_loop_device(): add newlines mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 17/21] multipathd (coverity): daemonize(): use dup2 mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 18/21] libmultipath (coverity): avoid sleeping in dm_mapname() mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 19/21] libmultipath (coverity): Revert "setup_map: wait for pending path checkers to finish" mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 20/21] libmultipath (coverity): check return values in dm_get_multipath() mwilck
2021-12-01 12:36 ` [dm-devel] [PATCH v2 21/21] libmultipath: update_pathvec_from_dm: don't force DI_WWID mwilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201123650.16240-1-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.