From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D26C433EF for ; Wed, 1 Dec 2021 21:18:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344041AbhLAVWO (ORCPT ); Wed, 1 Dec 2021 16:22:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344040AbhLAVWO (ORCPT ); Wed, 1 Dec 2021 16:22:14 -0500 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94A39C061574 for ; Wed, 1 Dec 2021 13:18:52 -0800 (PST) Received: by mail-qt1-x82a.google.com with SMTP id o17so25523900qtk.1 for ; Wed, 01 Dec 2021 13:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b8vgoAoZ91QTBQeNq/7pHGnW/opI+Ut4MEnu2qhtgD4=; b=hzhORA2lw3S8x6OlyTSSZPtpX+49RWaJ5mFSze63Xv9KM80O3jFwf+h40jtWNCFr7Z D7UmNZDBSpPjWXC/sAzKfYSzNiDgiML6xec8B/WxdnkIMzWwDJUGwiHqeHDZLBMyS0Er NqJXtvOWUnz5tTmzk0lAlYUs1mEwi4Zj9xUvGZKplN6JC0csZqevljbSWwYA3rZIkr3f 5gmzVGRrgRqbjlpQu8CSTtCyT4mdOOPXHAIYoHv+YILfdDSthKogff4T6QXBF6HIeMmP 3/KUPGHFq4zk+4wPn+0ySGzRbtj2xewPBe+iHfUufj17IiFHKDdRx3pY8ZSNj2ZFKAUR TWUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b8vgoAoZ91QTBQeNq/7pHGnW/opI+Ut4MEnu2qhtgD4=; b=cdK5CDBTvAtKqMAPBXyNqc6t1N1PxnvRKY9iKDgq6Rx83IxaGD9pWH/cbg4w8T3AAX VXbzJg/9f9+Fyxjz1itfL/mpbtTlDWYsdIMcnqwRwmGQEY3OSAXuls5xYE+tf4/pS4Qe TKMmFFx6PYUE2gQTy2v8rdYTi3EHu7xRNVGOhNrev0H+aANlIHaDBCAq2hOM7uvOYNvK 9Cjrg9rrzFbR2k79iD54nUDiX48rfxaf8mlaS4saD9tXBLREUokJwpXvyMAUboo+VH22 rjO08+Pz3kAfA0HaxqM1SXrewKDPo3sZ6OxouK0Zhj/2PbMjlthgH8CcTOsgKga4zKQH ccwg== X-Gm-Message-State: AOAM532zRCEClRgjW3gTDuekKd2liBat+xdp8ixcjE9NRBQZnkH7fs/B P1OsZEyG+7fVBWIedRxlim1x5w== X-Google-Smtp-Source: ABdhPJxqGOqq/gw6JuZdVLFQOpcFbkU+SQpOD5ytqySci0rhxYTI1yg25DOl+iiS5T+fQnZLF0zf8g== X-Received: by 2002:a05:622a:186:: with SMTP id s6mr10238691qtw.477.1638393531681; Wed, 01 Dec 2021 13:18:51 -0800 (PST) Received: from localhost (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id bp38sm462037qkb.66.2021.12.01.13.18.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 13:18:51 -0800 (PST) Date: Wed, 1 Dec 2021 16:18:50 -0500 From: Ralph Siemsen To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Geert Uytterhoeven , Jimmy Lalande , Milan Stevanovic , Linux-Renesas , Magnus Damm , Gareth Williams , Phil Edworthy , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] mtd: rawnand: rzn1: Add new NAND controller driver Message-ID: <20211201211850.GA3132024@maple.netwinder.org> References: <20211126140625.351697-1-miquel.raynal@bootlin.com> <20211126140625.351697-3-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20211126140625.351697-3-miquel.raynal@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Fri, Nov 26, 2021 at 03:06:24PM +0100, Miquel Raynal wrote: >Introduce Renesas RZ/N1x NAND controller driver which supports: >- All ONFI timing modes >- Different configurations of its internal ECC controller >- On-die (not tested) and software ECC support >- Several chips (not tested) >- Subpage accesses >- DMA and PIO > >This controller was originally provided by Evatronix before being bought >by Cadence. > >Signed-off-by: Miquel Raynal I've given it a try and all seems to be well. Thus: Tested-by: Ralph Siemsen >+ mtd = nand_to_mtd(chip); >+ mtd->dev.parent = nandc->dev; >+ if (!mtd->name) { >+ dev_err(nandc->dev, "Missing MTD label\n"); >+ return -EINVAL; >+ } Minor item: could the node name be used as a fallback when label is not present? Regards, -Ralph From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 218A0C433F5 for ; Wed, 1 Dec 2021 21:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gai/G0vw7N9yvVzs8AO9Il9jmW+cFs97CB47L2OGUOE=; b=LCupcMh9WENykXG5B1fGbKAcHK KF+B+gl3nqphl84a4D2JoCjISQzt3TqT9MAjBBipgDo+FwnD6yhmChWA6TIhKUBHzrDjDvMIm3lMT aSjoegzMd8IrsUrVzVysV2GwiK+huFvrEeBdDDF1fTuazS7YgfKrOCrbLt4af5gYoIizgaVmfBZtb rCNp+AXFRUARkbt9pUupAoFh53pI23GtvVAKa5ubJSUkgvs7ff7n7LKFnN6E5f4rNQjvw/e4S5qs8 +/tZDdEUaLE4Am1kjj+izcNpsOztDU0lwRFVWWkF3BWgOku5TD4WofXTTwNirtETvNky3ir5r7cK/ hDXV6LFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msX0I-00ACF1-JH; Wed, 01 Dec 2021 21:19:02 +0000 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msX0D-00ACDr-OV for linux-mtd@lists.infradead.org; Wed, 01 Dec 2021 21:18:59 +0000 Received: by mail-qt1-x82d.google.com with SMTP id l8so25527614qtk.6 for ; Wed, 01 Dec 2021 13:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b8vgoAoZ91QTBQeNq/7pHGnW/opI+Ut4MEnu2qhtgD4=; b=hzhORA2lw3S8x6OlyTSSZPtpX+49RWaJ5mFSze63Xv9KM80O3jFwf+h40jtWNCFr7Z D7UmNZDBSpPjWXC/sAzKfYSzNiDgiML6xec8B/WxdnkIMzWwDJUGwiHqeHDZLBMyS0Er NqJXtvOWUnz5tTmzk0lAlYUs1mEwi4Zj9xUvGZKplN6JC0csZqevljbSWwYA3rZIkr3f 5gmzVGRrgRqbjlpQu8CSTtCyT4mdOOPXHAIYoHv+YILfdDSthKogff4T6QXBF6HIeMmP 3/KUPGHFq4zk+4wPn+0ySGzRbtj2xewPBe+iHfUufj17IiFHKDdRx3pY8ZSNj2ZFKAUR TWUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b8vgoAoZ91QTBQeNq/7pHGnW/opI+Ut4MEnu2qhtgD4=; b=iq1PmIK3VK7VH0la/2DBZqY/VY1TfooTghoJY1JB4LFyJw69vlFdyWxoW5z2Si5G/w GyRFiNzOftHfv39zrCpKKnzUogNMU02rLAw3TUAv1ypJHINPULJFB+ZxsTm5mxv/WquI vXt6TQ7/tV1FBXaCUhSwXBH+Chviwq4sEmfsFvXFew3tPmlBLEnSZ6kSXHOu8xC4r1Jy 8M72sNNBIFVNFJlQt7gNJNe8R9qkdrO01nS4cTiDQ5c9RDBseLLH8gIf50zlkeH0gITA 30JTeDCEsx8B+D2qnbukGeDHcDCiGmpSY+O5N61aPLAA1REIA4FXZD5wYZnsEvFWVG4T nM/w== X-Gm-Message-State: AOAM532fm+EmABGorxzXz7op4Lo7K0TKpcm0/laBJedONViZ76Ge1Qdv vSXFL4NQwv+JzlmyTmFZc3O17w== X-Google-Smtp-Source: ABdhPJxqGOqq/gw6JuZdVLFQOpcFbkU+SQpOD5ytqySci0rhxYTI1yg25DOl+iiS5T+fQnZLF0zf8g== X-Received: by 2002:a05:622a:186:: with SMTP id s6mr10238691qtw.477.1638393531681; Wed, 01 Dec 2021 13:18:51 -0800 (PST) Received: from localhost (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id bp38sm462037qkb.66.2021.12.01.13.18.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 13:18:51 -0800 (PST) Date: Wed, 1 Dec 2021 16:18:50 -0500 From: Ralph Siemsen To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Geert Uytterhoeven , Jimmy Lalande , Milan Stevanovic , Linux-Renesas , Magnus Damm , Gareth Williams , Phil Edworthy , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] mtd: rawnand: rzn1: Add new NAND controller driver Message-ID: <20211201211850.GA3132024@maple.netwinder.org> References: <20211126140625.351697-1-miquel.raynal@bootlin.com> <20211126140625.351697-3-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211126140625.351697-3-miquel.raynal@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_131857_807907_083A189C X-CRM114-Status: UNSURE ( 9.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, Nov 26, 2021 at 03:06:24PM +0100, Miquel Raynal wrote: >Introduce Renesas RZ/N1x NAND controller driver which supports: >- All ONFI timing modes >- Different configurations of its internal ECC controller >- On-die (not tested) and software ECC support >- Several chips (not tested) >- Subpage accesses >- DMA and PIO > >This controller was originally provided by Evatronix before being bought >by Cadence. > >Signed-off-by: Miquel Raynal I've given it a try and all seems to be well. Thus: Tested-by: Ralph Siemsen >+ mtd = nand_to_mtd(chip); >+ mtd->dev.parent = nandc->dev; >+ if (!mtd->name) { >+ dev_err(nandc->dev, "Missing MTD label\n"); >+ return -EINVAL; >+ } Minor item: could the node name be used as a fallback when label is not present? Regards, -Ralph ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78EC1C433EF for ; Wed, 1 Dec 2021 21:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8/yeWDk0sG5GJJwJYOnVb+A4huw4iyjGFwVH/7ECRqY=; b=R/WX+MbCkK3O+t7nFRcMsIGnnk mxWK7nWE31OuOFPhbd9ir271Wpxb27D929Gq/tOH36sSd60qh+Qr+pWeWrlga5M7E81CD3hqLjEbH Zi92J4Pj31ibZRoNbsv8Kl3qk3rJNqnSH1z9p/gcQM4xP9Nf6vrAiZEYALiNfRp7/IZasbORsrLj7 f4saVMjYSQ0guXLLXSDj1rLKqrtoSxP8x3RxW92t7uWuO+eqGOROPVW2Q/C/nx80e6uOGUXttfRm6 cqyh5dhDmkJoOPky2uKzApt0ub36kAuJUb5F3PXIOqXcALUpKYyXMBtWprLAc+Rd9jGLcdYQTr28i tt3ht0DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msX0V-00ACGJ-Ll; Wed, 01 Dec 2021 21:19:15 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msX0D-00ACDq-N8 for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 21:18:59 +0000 Received: by mail-qt1-x835.google.com with SMTP id p19so25458169qtw.12 for ; Wed, 01 Dec 2021 13:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b8vgoAoZ91QTBQeNq/7pHGnW/opI+Ut4MEnu2qhtgD4=; b=hzhORA2lw3S8x6OlyTSSZPtpX+49RWaJ5mFSze63Xv9KM80O3jFwf+h40jtWNCFr7Z D7UmNZDBSpPjWXC/sAzKfYSzNiDgiML6xec8B/WxdnkIMzWwDJUGwiHqeHDZLBMyS0Er NqJXtvOWUnz5tTmzk0lAlYUs1mEwi4Zj9xUvGZKplN6JC0csZqevljbSWwYA3rZIkr3f 5gmzVGRrgRqbjlpQu8CSTtCyT4mdOOPXHAIYoHv+YILfdDSthKogff4T6QXBF6HIeMmP 3/KUPGHFq4zk+4wPn+0ySGzRbtj2xewPBe+iHfUufj17IiFHKDdRx3pY8ZSNj2ZFKAUR TWUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b8vgoAoZ91QTBQeNq/7pHGnW/opI+Ut4MEnu2qhtgD4=; b=Sgtu9AXV5gjj/J1YiUiMdVqlEy2BbkiiwSojqwXwO8NBtSnkyoK0tD+0QMXmP0IWRO h/JTx/b+R2d0bUKRgKyG0qUadhYvBhCZJPPYGay4vfyqdJuwdMgNihnzLavPvNkdbO9h DW1u81t2vWQIIvprF5CRSJFnhwcsDr8ekFou5j8fK/03Pkpl9pl5FYnQbTZBx4RPD2+k FqEhJbaay52G7O0qERdJwILHFRDsX1VUXCZZCp27A6cCD4sEw8wR6LeFi9Vkmx84fq7L lSzZWOQ+ozo7u4iMChyfFP/o7ZuUekKIJZ7FegeAEf1rqv4Ft6GkdqM588bImz6EHw7e 05Vg== X-Gm-Message-State: AOAM533gDNrcCw/Si2J8zPJCEr2QgqgWKAHFk9RFr3wOQ+aEh22r+iyx n2x4RHp9R5FQYEDL+P3QOuZSVA== X-Google-Smtp-Source: ABdhPJxqGOqq/gw6JuZdVLFQOpcFbkU+SQpOD5ytqySci0rhxYTI1yg25DOl+iiS5T+fQnZLF0zf8g== X-Received: by 2002:a05:622a:186:: with SMTP id s6mr10238691qtw.477.1638393531681; Wed, 01 Dec 2021 13:18:51 -0800 (PST) Received: from localhost (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id bp38sm462037qkb.66.2021.12.01.13.18.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 13:18:51 -0800 (PST) Date: Wed, 1 Dec 2021 16:18:50 -0500 From: Ralph Siemsen To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Geert Uytterhoeven , Jimmy Lalande , Milan Stevanovic , Linux-Renesas , Magnus Damm , Gareth Williams , Phil Edworthy , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] mtd: rawnand: rzn1: Add new NAND controller driver Message-ID: <20211201211850.GA3132024@maple.netwinder.org> References: <20211126140625.351697-1-miquel.raynal@bootlin.com> <20211126140625.351697-3-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211126140625.351697-3-miquel.raynal@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_131857_783709_E62955A7 X-CRM114-Status: GOOD ( 10.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 26, 2021 at 03:06:24PM +0100, Miquel Raynal wrote: >Introduce Renesas RZ/N1x NAND controller driver which supports: >- All ONFI timing modes >- Different configurations of its internal ECC controller >- On-die (not tested) and software ECC support >- Several chips (not tested) >- Subpage accesses >- DMA and PIO > >This controller was originally provided by Evatronix before being bought >by Cadence. > >Signed-off-by: Miquel Raynal I've given it a try and all seems to be well. Thus: Tested-by: Ralph Siemsen >+ mtd = nand_to_mtd(chip); >+ mtd->dev.parent = nandc->dev; >+ if (!mtd->name) { >+ dev_err(nandc->dev, "Missing MTD label\n"); >+ return -EINVAL; >+ } Minor item: could the node name be used as a fallback when label is not present? Regards, -Ralph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel