All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] edid: set default resolution to 1280x800 (WXGA)
Date: Thu, 2 Dec 2021 11:54:53 +0100	[thread overview]
Message-ID: <20211202105453.h27qsc3hlnph5y76@sirius.home.kraxel.org> (raw)
In-Reply-To: <20211129140508.1745130-1-berrange@redhat.com>

On Mon, Nov 29, 2021 at 02:05:08PM +0000, Daniel P. Berrangé wrote:
> Currently QEMU defaults to a resolution of 1024x768 when exposing EDID
> info to the guest OS. The EDID default info is important as this will
> influence what resolution many guest OS will configure the screen with
> on boot. It can also potentially influence what resolution the firmware
> will configure the screen with, though until very recently EDK2 would
> not handle EDID info.

edk2 support is at "patches exist" level right now, not even merged,
will hopefully land in the next stable tag (feb 22).

Independent from that we plan to change the edk2 default resolution from
the current 800x600 to whatever qemu 7.0 will use, be that 1280x800 (as
suggested by this patch) or 1024x768 (current qemu default).

> One important thing to bear in mind is that the default graphics card
> driver provided by Windows will leave the display set to whatever
> resolution was enabled by the firmware on boot. Even if sufficient
> VRAM is available, the resolution can't be changed without installing
> new drivers. IOW, the default resolution choice is quite important
> for usability of Windows.

It's not that simple.

With uefi firmware windows sticks to whatever resolution the firmware
has initialized (without installing guest drivers).  The resolution can
be changed in the firmware setup.

With bios firmware windows can change the resolution at runtime using
vgabios calls, i.e. after completing the install you can right-click on
the desktop, pick display config in the popup menu, then change the
resolution.

So there are ways to use other resolutions.  They are not exactly
intuitive though and I think it makes sense to modernize the qemu
defaults.

> In considering what possible new default could be suitable, choices
> considered were 1280x720 (720p), 1280x800 (WXGA) and 1280x1024 (SXGA).
> 
> In many ways, vertical space is the most important, and so 720p was
> discarded due to loosing vertical space, despite being 25% wider.
> 
> The SXGA resolution would be good, but when taking into account
> window titlebars/toolbars and window manager desktop UI, this might
> be a little too tall for some users to fit the guest on their physical
> montior.

Yes, with FullHD (1920x1080) being a popular resolution these days
having a 1280x1024 guest display would leave only 56 pixes for title
bar and menus.

> This patch thus suggests a modest change to 1280x800 (WXGA). This
> only consumes 1 MB per colour channel, allowing double buffered
> framebuffer in 8 MB of VRAM. Width wise this is 25% larger than
> QEMU's current default, but height wise this only adds 5%, so the
> difference isn't massive on the QEMU side.

Looks like a good pick to me.

In case someone wants pick that up:
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Failing that I'll add that to my first post-freeze pull request.

take care,
  Gerd



  reply	other threads:[~2021-12-02 10:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 14:05 [PATCH] edid: set default resolution to 1280x800 (WXGA) Daniel P. Berrangé
2021-12-02 10:54 ` Gerd Hoffmann [this message]
2021-12-02 11:00 ` Peter Maydell
2021-12-02 11:06   ` Daniel P. Berrangé
2021-12-02 11:42     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211202105453.h27qsc3hlnph5y76@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=berrange@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.