From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD4D8C433F5 for ; Thu, 2 Dec 2021 14:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358694AbhLBOqt (ORCPT ); Thu, 2 Dec 2021 09:46:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358717AbhLBOq0 (ORCPT ); Thu, 2 Dec 2021 09:46:26 -0500 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7AECC061759; Thu, 2 Dec 2021 06:43:03 -0800 (PST) Received: by mail-oi1-x236.google.com with SMTP id 7so55820643oip.12; Thu, 02 Dec 2021 06:43:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gdDNZknPlWQXti9kxSRAtYOCyds+UvL28w+exexiozg=; b=OCZ16K/FevUJX4L7LUbXRCWsXmrNw3L1yCZGoNsb6J2OvNRApNkg/VhtLXrnIF4sRb 8+zJ5z606yzljnkehQGLmuGmXm3PUvAmekngTZg4AK0Dwzu94tPBm+7sKzAoqUAeFmCg JcrAOcR5rGll6Y8rqWltIN0e17miYMK2wwMujE7LhKutog3G/0IWe2UnXTOoyMMbINka ZKvakAIg6EejIrgz4Hw2LvQ9cNlYNahvXTj03jxuQlIXqyVxbUBtoxtPrRqdAwq0H2ay G5fg+BNcjNNjzm5EjjRAiSof0ImAGOgesIvxYoAOxYJXw9NZJwDOuRAfpSJ1lqHpeQyR VIAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=gdDNZknPlWQXti9kxSRAtYOCyds+UvL28w+exexiozg=; b=3acfiCaZuRVKDim1vXBILnxUXtfolNkF0IXv6dVtvem79biJS/WwRECpOTh3putKO9 TXx4wOTs60xDdbe7elqbnMU2kBJzx2IWuT2RUkwPRkXM9rA478QTzl6NS+/GJJhlTBeE yHeR9cGYxYp9PineH0Lq947hVJVx8DbiUZbEgvUQaVz1mpOI+fdOMhrAanB3KcDshsde mxmnCXhEUE/xocJgg4diEjq5YILx4ghGHSAQEzmWh/AG/CxTcSwaeAIBkYO+KXbco4ld C12KxlmY7Fhkbx7YjrHkFRjCK3t+wjap7o6SPqS5qNqhgt2wrTKJGrzOEP535f8qxfNt qRiA== X-Gm-Message-State: AOAM53145INbT4RN4uahankWhDmYm3J/0ENMuHDMs/YoqqOFgk5Ps+Wd nuT8xwEMs7JcCYMIGueepLI= X-Google-Smtp-Source: ABdhPJy9d9K8vQfaMrzF0NadviuLFl6VvISc3/6oMkqiDL/F5a7ieaJY8UOOdcxrdm+usctEjtxjvw== X-Received: by 2002:aca:d0d:: with SMTP id 13mr4537737oin.107.1638456183251; Thu, 02 Dec 2021 06:43:03 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id bh12sm29018oib.25.2021.12.02.06.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Dec 2021 06:43:02 -0800 (PST) Sender: Guenter Roeck Date: Thu, 2 Dec 2021 06:43:01 -0800 From: Guenter Roeck To: Sven Peter Cc: Rob Herring , devicetree@vger.kernel.org, Wim Van Sebroeck , Hector Martin , Alyssa Rosenzweig , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Janne Grunau , Mark Kettenis , Rob Herring Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog Message-ID: <20211202144301.GA829000@roeck-us.net> References: <20211130161809.64591-1-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211130161809.64591-1-sven@svenpeter.dev> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 30, 2021 at 05:18:08PM +0100, Sven Peter wrote: > Apple SoCs come with a simple embedded watchdog. This watchdog is also > required in order to reset the SoC. > > Reviewed-by: Mark Kettenis > Reviewed-by: Rob Herring > Signed-off-by: Sven Peter Reviewed-by: Guenter Roeck > --- > v1 --> v2: > - add Mark's and Rob's r-b tags > > .../bindings/watchdog/apple,wdt.yaml | 52 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/apple,wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml > new file mode 100644 > index 000000000000..e58c56a6fdf6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/apple,wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple SoC Watchdog > + > +allOf: > + - $ref: "watchdog.yaml#" > + > +maintainers: > + - Sven Peter > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t8103-wdt > + - apple,t6000-wdt > + - const: apple,wdt > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + > + wdt: watchdog@50000000 { > + compatible = "apple,t8103-wdt", "apple,wdt"; > + reg = <0x50000000 0x4000>; > + clocks = <&clk>; > + interrupts = ; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 360e9aa0205d..859201bbd4e8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1750,6 +1750,7 @@ F: Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml > F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml > F: Documentation/devicetree/bindings/pci/apple,pcie.yaml > F: Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > +F: Documentation/devicetree/bindings/watchdog/apple,wdt.yaml > F: arch/arm64/boot/dts/apple/ > F: drivers/i2c/busses/i2c-pasemi-core.c > F: drivers/i2c/busses/i2c-pasemi-platform.c > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 283B1C433EF for ; Thu, 2 Dec 2021 14:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vmZnrQrG+jzQ0ELl9WK2lo5mbW/qBGAEPMIvAF92Nig=; b=zofVCDqCh5WUp3 F1dLk6tvgOwf51eO+Nf2lVy7bjNZsvxRhfrxcLvtmEK6gxHXM595vZie/CG84jv8+u0nsYjztu/Em 7v+jHMrr8dMEB5Gl3DmXRgUFrj49W6SRcE1+jsPKm9JanBbcOaR776e4ZiRSqQJUDFH2GeL9BLuX7 w035TmvwAnz/OxwkwH1CIKHJdJW6DS/HRJpXZoFKp2fnL+ShxDmGoh6JQ0cze81yP5uExmYK01lEr LUDBokMqxEhWog2Br9IXYBCtTTZRjO50v5P/e94Ae3hIpEHIBpN8klkDjYIdn/cmQwC6Ry/1J7HYi KDwux6jSoXAV7PPhrguw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msnIk-00Cc5p-31; Thu, 02 Dec 2021 14:43:10 +0000 Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msnIe-00Cc4A-Hv for linux-arm-kernel@lists.infradead.org; Thu, 02 Dec 2021 14:43:06 +0000 Received: by mail-oi1-x232.google.com with SMTP id r26so55819455oiw.5 for ; Thu, 02 Dec 2021 06:43:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gdDNZknPlWQXti9kxSRAtYOCyds+UvL28w+exexiozg=; b=OCZ16K/FevUJX4L7LUbXRCWsXmrNw3L1yCZGoNsb6J2OvNRApNkg/VhtLXrnIF4sRb 8+zJ5z606yzljnkehQGLmuGmXm3PUvAmekngTZg4AK0Dwzu94tPBm+7sKzAoqUAeFmCg JcrAOcR5rGll6Y8rqWltIN0e17miYMK2wwMujE7LhKutog3G/0IWe2UnXTOoyMMbINka ZKvakAIg6EejIrgz4Hw2LvQ9cNlYNahvXTj03jxuQlIXqyVxbUBtoxtPrRqdAwq0H2ay G5fg+BNcjNNjzm5EjjRAiSof0ImAGOgesIvxYoAOxYJXw9NZJwDOuRAfpSJ1lqHpeQyR VIAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=gdDNZknPlWQXti9kxSRAtYOCyds+UvL28w+exexiozg=; b=mWcPWEyPfDy7ABeQtMQl37HGmW5iiV1nSPvC3geUsgVzdRtZTX+88+woMIZz9d2G0v mFvu6WxyROM4U7pySWM4ijZAsuNS2LYq4TkaF5cHdo5GDTRA7z07o6w9cAbbo0fvjs72 7l/8Emk//Wx0QE1GBecWyFdCU7rVGi7iW7h1DoIj5Vj+2KfHSRP6PlB0l+sC/av9YBGj qcCZaUpJaXv4SbkdOa8ASzZDxKM/tWuqBF6osole9ORO95gyZY02J83W1/63g41BeF5Z kseQoWuhVmSzTfSBHA0IrF/aTmGMwlwu/ZFtf2G5IhZJGO41ORO57jqwHu/3yZRaZyqX mjYw== X-Gm-Message-State: AOAM532roKorbGqoVv9znIwcwqK8FLjZLqZRbDOFKK/r6gPsSOIstd79 43LUI2Lb15fAC92Hjxf57ss= X-Google-Smtp-Source: ABdhPJy9d9K8vQfaMrzF0NadviuLFl6VvISc3/6oMkqiDL/F5a7ieaJY8UOOdcxrdm+usctEjtxjvw== X-Received: by 2002:aca:d0d:: with SMTP id 13mr4537737oin.107.1638456183251; Thu, 02 Dec 2021 06:43:03 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id bh12sm29018oib.25.2021.12.02.06.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Dec 2021 06:43:02 -0800 (PST) Date: Thu, 2 Dec 2021 06:43:01 -0800 From: Guenter Roeck To: Sven Peter Cc: Rob Herring , devicetree@vger.kernel.org, Wim Van Sebroeck , Hector Martin , Alyssa Rosenzweig , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Janne Grunau , Mark Kettenis , Rob Herring Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog Message-ID: <20211202144301.GA829000@roeck-us.net> References: <20211130161809.64591-1-sven@svenpeter.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211130161809.64591-1-sven@svenpeter.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211202_064304_633325_53410AC7 X-CRM114-Status: GOOD ( 18.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 30, 2021 at 05:18:08PM +0100, Sven Peter wrote: > Apple SoCs come with a simple embedded watchdog. This watchdog is also > required in order to reset the SoC. > > Reviewed-by: Mark Kettenis > Reviewed-by: Rob Herring > Signed-off-by: Sven Peter Reviewed-by: Guenter Roeck > --- > v1 --> v2: > - add Mark's and Rob's r-b tags > > .../bindings/watchdog/apple,wdt.yaml | 52 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/apple,wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml > new file mode 100644 > index 000000000000..e58c56a6fdf6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/apple,wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple SoC Watchdog > + > +allOf: > + - $ref: "watchdog.yaml#" > + > +maintainers: > + - Sven Peter > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t8103-wdt > + - apple,t6000-wdt > + - const: apple,wdt > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + > + wdt: watchdog@50000000 { > + compatible = "apple,t8103-wdt", "apple,wdt"; > + reg = <0x50000000 0x4000>; > + clocks = <&clk>; > + interrupts = ; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 360e9aa0205d..859201bbd4e8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1750,6 +1750,7 @@ F: Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml > F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml > F: Documentation/devicetree/bindings/pci/apple,pcie.yaml > F: Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > +F: Documentation/devicetree/bindings/watchdog/apple,wdt.yaml > F: arch/arm64/boot/dts/apple/ > F: drivers/i2c/busses/i2c-pasemi-core.c > F: drivers/i2c/busses/i2c-pasemi-platform.c > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel