All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: "Bjørn Mork" <bjorn@mork.no>,
	netdev@vger.kernel.org, 照山周一郎 <teruyama@springboard-inc.jp>
Subject: Re: [PATCH net,stable] phy: sfp: fix high power modules without diag mode
Date: Thu, 2 Dec 2021 17:58:43 -0800	[thread overview]
Message-ID: <20211202175843.0210476e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20211130073929.376942-1-bjorn@mork.no>

On Tue, 30 Nov 2021 08:39:29 +0100 Bjørn Mork wrote:
> Commit 7cfa9c92d0a3 ("net: sfp: avoid power switch on address-change
> modules") changed semantics for high power modules without diag mode.
> We repeatedly try to read the current power status from the non-existing
> 0xa2 address, in the futile hope this failure is temporary:
> 
> [    8.856051] sfp sfp-eth3: module NTT              0000000000000000 rev 0000 sn 0000000000000000 dc 160408
> [    8.865843] mvpp2 f4000000.ethernet eth3: switched to inband/1000base-x link mode
> [    8.873469] sfp sfp-eth3: Failed to read EEPROM: -5
> [    8.983251] sfp sfp-eth3: Failed to read EEPROM: -5
> [    9.103250] sfp sfp-eth3: Failed to read EEPROM: -5
> 
> Eeprom dump:
> 
> 0x0000: 03 04 01 00 00 00 80 00 00 00 00 01 0d 00 0a 64
> 0x0010: 00 00 00 00 4e 54 54 20 20 20 20 20 20 20 20 20
> 0x0020: 20 20 20 20 00 00 00 00 30 30 30 30 30 30 30 30
> 0x0030: 30 30 30 30 30 30 30 30 30 30 30 30 05 1e 00 7d
> 0x0040: 02 00 00 00 30 30 30 30 30 30 30 30 30 30 30 30
> 0x0050: 30 30 30 30 31 36 30 34 30 38 20 20 00 00 00 75
> 0x0060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x0070: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x0080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x0090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x00f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 
> Previously we assumed such modules were powered up in the correct
> mode, continuing without further configuration as long as the
> required power class was supported by the host.
> 
> Revert to that behaviour, refactoring to keep the improved
> diagnostic messages.
> 
> Fixes: 7cfa9c92d0a3 ("net: sfp: avoid power switch on address-change modules")
> Reported-and-tested-by: 照山周一郎 <teruyama@springboard-inc.jp>
> Cc: Russell King <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>

Russell, any comments?

  reply	other threads:[~2021-12-03  1:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30  7:39 [PATCH net,stable] phy: sfp: fix high power modules without diag mode Bjørn Mork
2021-12-03  1:58 ` Jakub Kicinski [this message]
2021-12-03 11:54   ` Russell King (Oracle)
2021-12-03 12:58     ` Russell King (Oracle)
2021-12-03 13:55       ` Bjørn Mork
2021-12-04 12:38         ` Russell King (Oracle)
2021-12-06 10:35           ` Bjørn Mork
2021-12-06 15:39             ` 照山周一郎
2021-12-30 11:43               ` Bjørn Mork
2021-12-30 11:55                 ` Russell King (Oracle)
2021-12-30 12:00                   ` 照山周一郎
2022-01-15 16:58       ` Christian Lamparter
2022-01-17 14:24         ` Russell King (Oracle)
2022-01-17 14:44           ` Bjørn Mork
2022-01-17 14:49           ` Christian Lamparter
2022-01-18  6:58             ` 照山周一郎
2021-12-03 13:41     ` Bjørn Mork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211202175843.0210476e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=bjorn@mork.no \
    --cc=netdev@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=teruyama@springboard-inc.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.